Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Describe the SPI NAND

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello Kumar,

>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> @@ -737,3 +737,43 @@ dpi1_out: endpoint {
>>   		};
>>   	};
>>   };
>> +
>> +&fss {
>> +	status = "okay";
>> +};
>> +
>> +&ospi0 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&ospi0_pins_default>;
>> +
>> +	flash@0 {
>> +		compatible = "spi-nand";
>
> Since this is boot flash, so please add booth-all property as well

Ok.

>
>
>> +		reg = <0>;
>> +		spi-tx-bus-width = <8>;
>> +		spi-rx-bus-width = <8>;
>> +		spi-max-frequency = <25000000>;
>> +		cdns,tshsl-ns = <60>;
>> +		cdns,tsd2d-ns = <60>;
>> +		cdns,tchsh-ns = <60>;
>> +		cdns,tslch-ns = <60>;
>> +		cdns,read-delay = <2>;
>
> Since this flash is used as boot device, I suggest if you can add
> partitions of flash as well .
>
> you can take reference from downstream version [0]

The flash is currently not the primary boot device, and the flash is
very fragmented in smaller mtd partitions, which is not ideal for wear
levelling. I prefer to let TI people propose a partitioning scheme
themselves.

Thanks,
Miquèl