devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: Keguang Zhang via B4 Relay
	<devnull+keguang.zhang.gmail.com@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org,  linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,  linux-media@vger.kernel.org
Subject: Re: [PATCH v12 2/2] mtd: rawnand: Add Loongson-1 NAND Controller Driver
Date: Tue, 04 Mar 2025 14:52:21 +0100	[thread overview]
Message-ID: <87a5a0299m.fsf@bootlin.com> (raw)
In-Reply-To: <CAJhJPsUw7YGKfBuFtUirOGuCA9hV6e-wjrL4L9b-5kmuVUW=ow@mail.gmail.com> (Keguang Zhang's message of "Tue, 4 Mar 2025 19:46:39 +0800")

Hello Keguang,

>> > +static int ls1x_nand_exec_op(struct nand_chip *chip,
>> > +                          const struct nand_operation *op,
>> > +                          bool check_only)
>> > +{
>> > +     int ret;
>> > +
>>
>>         if (check_only) ?
>
> Sorry, I'm not sure if I understand correctly.
> nand_op_parser_exec_op() only checks patterns and will skip
> pattern->exec() when check_only = true. Therefore,
> ls1x_nand_check_op() should handle all opcode checks in that case, and
> leave check_only = false to nand_op_parser_exec_op().
> Then the code will return to:
>
> if (check_only)
>         return ls1x_nand_check_op(chip, op);
>
> return nand_op_parser_exec_op(chip, &ls1x_nand_op_parser, op, check_only);
>
> Am I right?

Absolutely, yes.

Thanks,
Miquèl

      reply	other threads:[~2025-03-04 13:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 10:27 [PATCH v12 0/2] Add support for Loongson-1 NAND Keguang Zhang via B4 Relay
2025-01-21 10:27 ` [PATCH v12 1/2] dt-bindings: mtd: Add Loongson-1 NAND Controller Keguang Zhang via B4 Relay
2025-01-21 10:27 ` [PATCH v12 2/2] mtd: rawnand: Add Loongson-1 NAND Controller Driver Keguang Zhang via B4 Relay
2025-02-06 17:17   ` Miquel Raynal
2025-03-04 11:46     ` Keguang Zhang
2025-03-04 13:52       ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5a0299m.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+keguang.zhang.gmail.com@kernel.org \
    --cc=keguang.zhang@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).