From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7559CC4320A for ; Wed, 1 Sep 2021 12:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AABE610C9 for ; Wed, 1 Sep 2021 12:45:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346053AbhIAMqV (ORCPT ); Wed, 1 Sep 2021 08:46:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:42970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245055AbhIAMmg (ORCPT ); Wed, 1 Sep 2021 08:42:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED3D7611F0; Wed, 1 Sep 2021 12:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630499869; bh=Vz1TA47llC7a59hhyNGoaeEiKl47puwT1GS5TQq5ado=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=YdxJ445rGLT787Ao50jV8Np6uKoGqrJdbGH9KahNCNKH/45AAoVWJAx5KWZdNEg/7 JMEGKO849LZKAoBLVIwYNSuQEmPNjT939maSN46cIfLRHKn56Q9eGLg0IMzcc8MiAO MBr+YdTOrCy2We2dTlXfDnbNwmm582bhnn6iOlPY5RSIacLhnBuK+DdR22fUwuXQP0 N1UY7QoOcDuWzgBg201DHlnLGb1CTSo4wLgNg9lJYmlqrFhpYTJBOWi1gjYf68l28+ cSp5H5BVsu1v+P6hskX8HYLCzadfrpX/jVZqHfWZ2u+jMxvjpET9odm57F6+YAI7SB rVmXtHwMQIJhw== References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-38-maxime@cerno.tech> User-agent: mu4e 1.6.5; emacs 27.2 From: Felipe Balbi To: Maxime Ripard Cc: devicetree@vger.kernel.org, Rob Herring , Frank Rowand , Chen-Yu Tsai , Jernej =?utf-8?Q?=C5=A0krabec?= , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH v2 37/52] dt-bindings: usb: dwc3: Fix usb-phy check Date: Wed, 01 Sep 2021 15:36:35 +0300 In-reply-to: <20210901091852.479202-38-maxime@cerno.tech> Message-ID: <87a6kwcvzb.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Maxime Ripard writes: > The original binding was allowing any combination of usb2-phy and > usb3-phy in the phys and phy-names properties. > > However, the current binding enforces that those properties must be a > list of usb2-phy and usb3-phy, with exactly one element, effectively > making usb2-phy the only value being valid. > > Let's rework the properties description to allow either one or two > element picked with values either usb2-phy or usb3-phy. The rest of the > tooling makes sure that we don't get any duplicate value, so this should > be what we want. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 078fb7889593..c1c970073681 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -73,15 +73,15 @@ properties: > > phys: > minItems: 1 > - items: > - - description: USB2/HS PHY > - - description: USB3/SS PHY > + maxItems: 2 I'm not sure you should enforce a maximum of 2 PHYs. Some systems may use more than one USB2 PHY to take care of different parts of the USB link. IIRC N900 was a USB2-only system which shipped with two USB2 PHYs: one handling the communication proper and one handling charger detection and the like. -- balbi