[PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Lubomir Rintel]

Notable difference from the other Raspberry Pi boards is the lack of PWR LED.

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/Makefile             |  3 ++-
 arch/arm/boot/dts/bcm2835-rpi-zero.dts | 24 ++++++++++++++++++++++++
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/bcm2835-rpi-zero.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d000814..5d38b88 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -64,7 +64,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
 	bcm2835-rpi-b-rev2.dtb \
 	bcm2835-rpi-b-plus.dtb \
 	bcm2835-rpi-a-plus.dtb \
-	bcm2836-rpi-2-b.dtb
+	bcm2836-rpi-2-b.dtb \
+	bcm2835-rpi-zero.dtb
 dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm4708-asus-rt-ac56u.dtb \
 	bcm4708-asus-rt-ac68u.dtb \
diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
new file mode 100644
index 0000000..f9afc1a
--- /dev/null
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
@@ -0,0 +1,24 @@
+/dts-v1/;
+#include "bcm2835.dtsi"
+#include "bcm2835-rpi.dtsi"
+
+/ {
+	compatible = "raspberrypi,model-zero", "brcm,bcm2835";
+	model = "Raspberry Pi Zero";
+
+	leds {
+		act {
+			gpios = <&gpio 47 0>;
+		};
+	};
+};
+
+&gpio {
+	pinctrl-0 = <&gpioout &alt0 &i2s_alt0 &alt3>;
+
+	/* I2S interface */
+	i2s_alt0: i2s_alt0 {
+		brcm,pins = <18 19 20 21>;
+		brcm,function = <BCM2835_FSEL_ALT0>;
+	};
+};
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Noralf Trønnes]

Den 04.02.2016 08:39, skrev Lubomir Rintel:
> Notable difference from the other Raspberry Pi boards is the lack of PWR LED.

Another difference is that the ACT led is inverted.
Downstream decided to keep it [1] like that making it double as a power
indicator and an inverted disk indicator.

Noralf.

[1] https://github.com/raspberrypi/linux/pull/1239

> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
> ---
>   arch/arm/boot/dts/Makefile             |  3 ++-
>   arch/arm/boot/dts/bcm2835-rpi-zero.dts | 24 ++++++++++++++++++++++++
>   2 files changed, 26 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/boot/dts/bcm2835-rpi-zero.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d000814..5d38b88 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -64,7 +64,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
>   	bcm2835-rpi-b-rev2.dtb \
>   	bcm2835-rpi-b-plus.dtb \
>   	bcm2835-rpi-a-plus.dtb \
> -	bcm2836-rpi-2-b.dtb
> +	bcm2836-rpi-2-b.dtb \
> +	bcm2835-rpi-zero.dtb
>   dtb-$(CONFIG_ARCH_BCM_5301X) += \
>   	bcm4708-asus-rt-ac56u.dtb \
>   	bcm4708-asus-rt-ac68u.dtb \
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
> new file mode 100644
> index 0000000..f9afc1a
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
> @@ -0,0 +1,24 @@
> +/dts-v1/;
> +#include "bcm2835.dtsi"
> +#include "bcm2835-rpi.dtsi"
> +
> +/ {
> +	compatible = "raspberrypi,model-zero", "brcm,bcm2835";
> +	model = "Raspberry Pi Zero";
> +
> +	leds {
> +		act {
> +			gpios = <&gpio 47 0>;
> +		};
> +	};
> +};
> +
> +&gpio {
> +	pinctrl-0 = <&gpioout &alt0 &i2s_alt0 &alt3>;
> +
> +	/* I2S interface */
> +	i2s_alt0: i2s_alt0 {
> +		brcm,pins = <18 19 20 21>;
> +		brcm,function = <BCM2835_FSEL_ALT0>;
> +	};
> +};

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Stefan Wahren]

Hi Lubomir,

> Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> hat am 4. Februar 2016 um 08:39 geschrieben:
>
>
> Notable difference from the other Raspberry Pi boards is the lack of PWR LED.
>
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
> ---
> arch/arm/boot/dts/Makefile | 3 ++-
> arch/arm/boot/dts/bcm2835-rpi-zero.dts | 24 ++++++++++++++++++++++++
> 2 files changed, 26 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/bcm2835-rpi-zero.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d000814..5d38b88 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -64,7 +64,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
> bcm2835-rpi-b-rev2.dtb \
> bcm2835-rpi-b-plus.dtb \
> bcm2835-rpi-a-plus.dtb \
> - bcm2836-rpi-2-b.dtb
> + bcm2836-rpi-2-b.dtb \
> + bcm2835-rpi-zero.dtb
> dtb-$(CONFIG_ARCH_BCM_5301X) += \
> bcm4708-asus-rt-ac56u.dtb \
> bcm4708-asus-rt-ac68u.dtb \
> diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts
> b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
> new file mode 100644
> index 0000000..f9afc1a
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
> @@ -0,0 +1,24 @@
> +/dts-v1/;
> +#include "bcm2835.dtsi"
> +#include "bcm2835-rpi.dtsi"
> +
> +/ {
> + compatible = "raspberrypi,model-zero", "brcm,bcm2835";

please add this to

Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt

Thanks
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> writes:

> Hi Lubomir,
>
>> Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> hat am 4. Februar 2016 um 08:39 geschrieben:
>>
>>
>> Notable difference from the other Raspberry Pi boards is the lack of PWR LED.
>>
>> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
>> ---
>> arch/arm/boot/dts/Makefile | 3 ++-
>> arch/arm/boot/dts/bcm2835-rpi-zero.dts | 24 ++++++++++++++++++++++++
>> 2 files changed, 26 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/boot/dts/bcm2835-rpi-zero.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index d000814..5d38b88 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -64,7 +64,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
>> bcm2835-rpi-b-rev2.dtb \
>> bcm2835-rpi-b-plus.dtb \
>> bcm2835-rpi-a-plus.dtb \
>> - bcm2836-rpi-2-b.dtb
>> + bcm2836-rpi-2-b.dtb \
>> + bcm2835-rpi-zero.dtb
>> dtb-$(CONFIG_ARCH_BCM_5301X) += \
>> bcm4708-asus-rt-ac56u.dtb \
>> bcm4708-asus-rt-ac68u.dtb \
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts
>> b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
>> new file mode 100644
>> index 0000000..f9afc1a
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
>> @@ -0,0 +1,24 @@
>> +/dts-v1/;
>> +#include "bcm2835.dtsi"
>> +#include "bcm2835-rpi.dtsi"
>> +
>> +/ {
>> + compatible = "raspberrypi,model-zero", "brcm,bcm2835";
>
> please add this to
>
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt

If we can get this little bit fixed, I'd be happy to pull the patch.
The discussion of the LED behavior seemed like this was a reasonable way
to go.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Stefan Wahren]

Hi Lubomir,

> Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> hat am 4. Februar 2016 um 08:39 geschrieben:
> 
> 
> Notable difference from the other Raspberry Pi boards is the lack of PWR LED.
> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>

do you have any plans to submit a V2 of this patch or should i take over?

Best regards
Stefan

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> writes:

> Hi Lubomir,
>
>> Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> hat am 4. Februar 2016 um 08:39 geschrieben:
>> 
>> 
>> Notable difference from the other Raspberry Pi boards is the lack of PWR LED.
>> 
>> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
>
> do you have any plans to submit a V2 of this patch or should i take over?

It's been a while, so I'd love if you picked it up and resubmitted with
the LED changes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Stefan Wahren]

Hi Eric,

> Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> hat am 20. Juli 2016 um 21:36 geschrieben:
> 
> 
> Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> writes:
> 
> > Hi Lubomir,
> >
> >> Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> hat am 4. Februar 2016 um 08:39
> >> geschrieben:
> >> 
> >> 
> >> Notable difference from the other Raspberry Pi boards is the lack of PWR
> >> LED.
> >> 
> >> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
> >
> > do you have any plans to submit a V2 of this patch or should i take over?
> 
> It's been a while, so I'd love if you picked it up and resubmitted with
> the LED changes.

i also want to take care of those dwc2 warnings, which might need some
additional DT settings:

dwc2 20980000.usb: 256 invalid for host_nperio_tx_fifo_size. Check HW
configuration.
dwc2 20980000.usb: 512 invalid for host_perio_tx_fifo_size. Check HW
configuration.
dwc2 20980000.usb: Specified GNPTXFDEP=1024 > 32

What LED change do you expect?

Lubomir's suggestion is HIGH_ACTIVE which is more userfriendly because of the
missing PWR LED.
Changing to LOW_ACTIVE would be more stringent according to all the other RPis.

Btw the DTS for the RPi Zero has been dropped in downstream.

Regards
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: bcm2835: dt: Add Raspberry Pi Zero

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> writes:

> Hi Eric,
>
>> Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> hat am 20. Juli 2016 um 21:36 geschrieben:
>> 
>> 
>> Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> writes:
>> 
>> > Hi Lubomir,
>> >
>> >> Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> hat am 4. Februar 2016 um 08:39
>> >> geschrieben:
>> >> 
>> >> 
>> >> Notable difference from the other Raspberry Pi boards is the lack of PWR
>> >> LED.
>> >> 
>> >> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
>> >
>> > do you have any plans to submit a V2 of this patch or should i take over?
>> 
>> It's been a while, so I'd love if you picked it up and resubmitted with
>> the LED changes.
>
> i also want to take care of those dwc2 warnings, which might need some
> additional DT settings:
>
> dwc2 20980000.usb: 256 invalid for host_nperio_tx_fifo_size. Check HW
> configuration.
> dwc2 20980000.usb: 512 invalid for host_perio_tx_fifo_size. Check HW
> configuration.
> dwc2 20980000.usb: Specified GNPTXFDEP=1024 > 32
>
> What LED change do you expect?

Sorry, misremembering the thread. I think it was just the bindings
documentation change that was needed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]