devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Richard Zhao <richard.zhao@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, cpufreq@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk,
	arnd@arndb.de, patches@linaro.org, marc.zyngier@arm.com,
	catalin.marinas@arm.com, rob.herring@calxeda.com,
	rdunlap@xenotime.net, eric.miao@linaro.org,
	kernel@pengutronix.de, jamie@jamieiles.com, davej@redhat.com,
	linaro-dev@lists.linaro.org
Subject: Re: [PATCH V6 4/7] cpufreq: add clk-reg cpufreq driver
Date: Wed, 11 Jan 2012 15:22:34 -0800	[thread overview]
Message-ID: <87aa5t25ad.fsf@ti.com> (raw)
In-Reply-To: <1325213769-11752-5-git-send-email-richard.zhao@linaro.org> (Richard Zhao's message of "Fri, 30 Dec 2011 10:56:06 +0800")

Richard Zhao <richard.zhao@linaro.org> writes:

> The driver get cpu operation point table from device tree cpu0 node,

Since we already have an existing OPP infrastructure in the kernel,
seems like  this driver should get OPPs by asking the OPP layer.

This approach assumes the OPP layer is static at boot time and not
changing, however that's not the case in practice.

The OPP layer could be extended to read boot-time OPPs from DT if
desired, but since the OPPs are also populated/enabled/disabled
dynamicaly on some platforms (e.g. OMAP), I think the any generic
CPUfreq driver should use the OPP interface and not DT directly.

> and adjusts operating points using clk and regulator APIs.

For a generic driver, the regulator used should also be configurable.

For example, this driver currently assumes a regulator named "cpu" for
all instances.   If you had separate clusters with independent voltage
control, you'd likely have a separate regulator for each cluster.

Kevin

  reply	other threads:[~2012-01-11 23:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30  2:56 [PATCH V6 0/7] add a generic cpufreq driver Richard Zhao
2011-12-30  2:56 ` [PATCH V6 1/7] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp Richard Zhao
2011-12-30  2:56 ` [PATCH V6 2/7] arm/imx: cpufreq: remove loops_per_jiffy recalculate " Richard Zhao
2012-01-06  0:56   ` Richard Zhao
2012-01-06 13:19     ` Shawn Guo
2011-12-30  2:56 ` [PATCH V6 3/7] cpufreq: OMAP: " Richard Zhao
2012-01-06  1:02   ` Richard Zhao
2011-12-30  2:56 ` [PATCH V6 4/7] cpufreq: add clk-reg cpufreq driver Richard Zhao
2012-01-11 23:22   ` Kevin Hilman [this message]
2012-01-12  8:23     ` Richard Zhao
2012-01-12 22:52       ` Kevin Hilman
     [not found]         ` <874nw0sfdn.fsf-l0cyMroinI0@public.gmane.org>
2012-01-13 17:16           ` Cousson, Benoit
2011-12-30  2:56 ` [PATCH V6 5/7] dts/imx6q: add cpufreq property Richard Zhao
2011-12-30  2:56 ` [PATCH V6 6/7] arm/imx6q: register arm_clk as cpu to clkdev Richard Zhao
2011-12-30  2:56 ` [PATCH V6 7/7] arm/imx6q: select ARCH_HAS_CPUFREQ Richard Zhao
2012-01-04 22:16 ` [PATCH V6 0/7] add a generic cpufreq driver Richard Zhao
2012-01-06  0:53   ` Richard Zhao
2012-01-09 14:52     ` Richard Zhao
2012-02-03 16:28       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aa5t25ad.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@redhat.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=eric.miao@linaro.org \
    --cc=jamie@jamieiles.com \
    --cc=kernel@pengutronix.de \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=patches@linaro.org \
    --cc=rdunlap@xenotime.net \
    --cc=richard.zhao@linaro.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).