From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1753D905D; Wed, 3 Jun 2026 15:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780500278; cv=none; b=l1ayDfX7XWBdC5OE72Wh79z+Iwz1aNn6iidJwqwkXDvNHylP31MiOm71G7m1O9wed4Ayz7fK7avsm9ONgzV/6ysSn3CWrKoqqfW0gf5bHBkWINsJBzwGy/tAwkcx9/Xn+2s8FEJxCkt26HVNHKpT/oLbd5CIZI9/9Aex5PQuaV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780500278; c=relaxed/simple; bh=Wo7WvU7hG8UqR9oM2FnHyCbJ2ufNLi2uCnx5PAG0TkE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gVz+C9LnFwZrrFjnpJ3ly1uA1lygQihAk3h0Lsuom6AkQK6IWMaufyhquJ+ThehglQ2SqrQw+/WCmMgRu+zV839cDZ0TsvoXHhKfElz6zfCZWbQ7jDSgM54kQ2Ukj79lCA3UoGxObs5m8O3Z/zJiWICwRUa5qU7Ya0uLIxke0yI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G6HoOvL0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G6HoOvL0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0E651F00893; Wed, 3 Jun 2026 15:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780500277; bh=HNdlC6+cJBidtlUlePuZph88tbBAg1I6k9N5mrg/fMQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=G6HoOvL0sJEIKMxnx6ll5qujs8+SC7yKk9xA6cXa3zIRKuRU04wbyn6GA3zQgdo43 6mllWBQAm6fS+66v+cTX8r00MBIwB2MX7JraKXbUCZINs5VnGbceFvNOQz18gvtL4B pXK3agdUJ/tF0xTUwUvvONJ82RG+sUEyk62zFyex9u252DlU6pj4jFCCJDQR/l0pSS SDkt5uUiabA22dblq6QCIT63d4k46DV1nqD2zrelIZm70aC7190cOLc6cO1Q4nD7Je miHBWlzwG6Fz4kk6lxwUdcTYLtS9dG9DkbVVkBO+u7Re8hmKWmSnlZ2g9sZtlqEcKN TkutyJ+RsqAtw== From: Thomas Gleixner To: Maulik Shah , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad , Maulik Shah Subject: Re: [PATCH v2 2/8] irqchip/qcom-pdc: Move all statics to struct pdc_desc In-Reply-To: <20260526-hamoa_pdc-v2-2-f6857af1ce91@oss.qualcomm.com> References: <20260526-hamoa_pdc-v2-0-f6857af1ce91@oss.qualcomm.com> <20260526-hamoa_pdc-v2-2-f6857af1ce91@oss.qualcomm.com> Date: Wed, 03 Jun 2026 17:24:34 +0200 Message-ID: <87bjdr7ikt.ffs@fw13> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, May 26 2026 at 16:24, Maulik Shah wrote: > @@ -221,9 +231,9 @@ static void pdc_enable_intr(struct irq_data *d, bool on) > { > unsigned long flags; > > - raw_spin_lock_irqsave(&pdc_lock, flags); > - __pdc_enable_intr(d->hwirq, on); > - raw_spin_unlock_irqrestore(&pdc_lock, flags); > + raw_spin_lock_irqsave(&pdc->lock, flags); While at it please convert this to: guard(raw_spinlock_irqsave)(...); The _irqsave is not really required when invoked from the irqchip callbacks with irq desc lock held and interrupts disabled, but that's also magically invoked from other contexts. So you could spare that irqsave by wrapping the other callsite into: guard(irq)() or scoped_guard(irq) > + pdc->enable_intr(d->hwirq, on); > + raw_spin_unlock_irqrestore(&pdc->lock, flags); > } > > static void qcom_pdc_gic_disable(struct irq_data *d) > @@ -348,10 +358,10 @@ static struct pdc_pin_region *get_pin_region(int pin) > { > int i; > > - for (i = 0; i < pdc_region_cnt; i++) { > - if (pin >= pdc_region[i].pin_base && > - pin < pdc_region[i].pin_base + pdc_region[i].cnt) > - return &pdc_region[i]; > + for (i = 0; i < pdc->region_cnt; i++) { for (int i = 0; .... > + if (pin >= pdc->region[i].pin_base && > + pin < pdc->region[i].pin_base + pdc->region[i].cnt) > + return &pdc->region[i]; > > + raw_spin_lock_init(&pdc->lock); > + > pdc_domain = irq_domain_create_hierarchy(parent_domain, > IRQ_DOMAIN_FLAG_QCOM_PDC_WAKEUP, > PDC_MAX_IRQS, Please fix up the coding style here according to https://docs.kernel.org/process/maintainer-tip.html