From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: Convert marvell,armada370-thermal to DT schema
Date: Fri, 01 Aug 2025 15:56:31 +0200 [thread overview]
Message-ID: <87bjoz6t80.fsf@bootlin.com> (raw)
In-Reply-To: <20250702225530.2858649-1-robh@kernel.org> (Rob Herring's message of "Wed, 2 Jul 2025 17:55:27 -0500")
Hi Rob,
On 02/07/2025 at 17:55:27 -05, "Rob Herring (Arm)" <robh@kernel.org> wrote:
> Convert the Marvell Armada 3xx/XP thermal binding to schema.
>
> Drop the AP80x and CP110 as they have long been deprecated and have
> been replaced by a new binding.
Totally fine with that, but then I would go even further and also drop
the legacy binding implying a size of 4 on the second reg range?
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
...
> +examples:
> + - |
> + thermal@d0018300 {
> + compatible = "marvell,armada370-thermal";
> + reg = <0xd0018300 0x4
> + 0xd0018304 0x4>;
> + };
This example is showing a legacy binding. Even if we decide to keep
supporting it, I think you would prefer to replace the second line:
reg = <0xd0018300 0x4
- 0xd0018304 0x4>;
+ 0xd0018304 0x8>;
Thanks,
Miquèl
prev parent reply other threads:[~2025-08-01 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 22:55 [PATCH] dt-bindings: thermal: Convert marvell,armada370-thermal to DT schema Rob Herring (Arm)
2025-08-01 13:56 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjoz6t80.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).