From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: <broonie@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <andersson@kernel.org>,
<konradybcio@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
<manivannan.sadhasivam@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <quic_srichara@quicinc.com>,
<quic_varada@quicinc.com>
Subject: Re: [PATCH v13 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver
Date: Wed, 13 Nov 2024 10:07:08 +0100 [thread overview]
Message-ID: <87bjyjsds3.fsf@bootlin.com> (raw)
In-Reply-To: <374ea155-0970-38bd-470f-cc440ca0bab5@quicinc.com> (Md Sadre Alam's message of "Tue, 12 Nov 2024 17:45:07 +0530")
Hello,
On 12/11/2024 at 17:45:07 +0530, Md Sadre Alam <quic_mdalam@quicinc.com> wrote:
> On 11/12/2024 12:00 AM, Miquel Raynal wrote:
>> On 30/10/2024 at 17:49:13 +0530, Md Sadre Alam <quic_mdalam@quicinc.com> wrote:
>>
>>> cleanup qcom_nandc driver as below
>> Perform a global cleanup of the Qualcomm NAND controller driver with
>> the
>> following improvements:
> Ok
>>>
>>> - Remove register value indirection api
>> API
> Ok
>>
>>>
>>> - Remove set_reg() api
>> API
> Ok
>>
>>>
>>> - Convert read_loc_first & read_loc_last macro to function
>> functions
> Ok
>>
>>>
>>> - Renamed multiple variables
>> Rename
> Ok
In general when the main answer is "okay", you can probably just say a
sentence like "thanks for the comments I'll take them into account",
without answering to each and every comment. This way, it will be easier
for me to catch if you have further remarks.
Thanks,
Miquèl
next prev parent reply other threads:[~2024-11-13 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:19 [PATCH v13 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-11-11 18:30 ` Miquel Raynal
2024-11-12 12:15 ` Md Sadre Alam
2024-11-13 9:07 ` Miquel Raynal [this message]
2024-11-13 9:56 ` Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 4/8] mtd: nand: Add qpic_common API file Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 5/8] mtd: rawnand: qcom: use FIELD_PREP and GENMASK Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-10-30 12:19 ` [PATCH v13 8/8] arm64: dts: qcom: ipq9574: Remove eMMC node Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjyjsds3.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_mdalam@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).