From: Andreas Rammhold <andreas@rammhold.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mips@vger.kernel.org, Frank Rowand <frank.rowand@sony.com>,
linux-kernel@vger.kernel.org, John Crispin <john@phrozen.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v4] of/fdt: Rework early_init_dt_scan_memory() to call directly
Date: Sat, 17 Dec 2022 01:42:14 +0100 [thread overview]
Message-ID: <87bko2x3mh.fsf@rammhold.de> (raw)
In-Reply-To: <20211215150102.1303588-1-robh@kernel.org>
Hi,
I've just debugged an issue that I traced down to this commit.
My mt7621 based board relies on the soc_info.mem_detect function for
memblock init which is never being called again with this patch being
applied.
The code in the original patch as well was on 6.0 doesn't allow any of
the other (fallback?) memory initialization code to run as
early_init_dt_scan_memory() always returns 0.
Was this an oversight in the implementation or are some follow-up
patches missing? Perhaps the code just has to return a different
value when it has found some blocks of memory that should be used?
Andi
prev parent reply other threads:[~2022-12-17 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:01 [PATCH v4] of/fdt: Rework early_init_dt_scan_memory() to call directly Rob Herring
2021-12-16 5:19 ` Michael Ellerman
2022-12-17 0:42 ` Andreas Rammhold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bko2x3mh.fsf@rammhold.de \
--to=andreas@rammhold.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.rowand@sony.com \
--cc=frowand.list@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).