From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Shishkin Subject: Re: [PATCH v2 05/12] usb: chipidea: add imx driver binding Date: Tue, 22 May 2012 13:21:44 +0300 Message-ID: <87bolgbjnr.fsf@ashishki-desk.ger.corp.intel.com> References: <1337592237-5090-1-git-send-email-richard.zhao@freescale.com> <1337592237-5090-6-git-send-email-richard.zhao@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1337592237-5090-6-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Cc: B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org, B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org, marex-ynQEQJNshbs@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org, linuxzsc-MeMPY/F8WlbQT0dZR+AlfA@public.gmane.org, Peter Chen List-Id: devicetree@vger.kernel.org Richard Zhao writes: > +#include "ci.h" > + > +#define PORT0_STATUS 0x184 This doesn't seem to be used anywhere. [snip] > + ci13xxx_imx_udc_driver.phy = data->phy; See my comment to the other patch about phy pointer being a per-device thing rather then per-platform driver. Now, (at the risk of being flamed) I think it could work if you allocated the ci13xxx_imx_udc_driver dynamically in every probe, but that's not what you want to do for the actual platform data. So, I suggest we come up with a better way of passing phy to the driver. I also think that it's really about time we renamed "struct ci13xxx_udc_driver" to something that emphasizes the "platform" in it. What do you think? Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html