* [PATCH 0/2] Add initial support for various RDPs of IPQ9574 family
@ 2023-07-20 8:45 Sridharan S N
2023-07-20 8:45 ` [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on " Sridharan S N
2023-07-20 8:45 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs Sridharan S N
0 siblings, 2 replies; 9+ messages in thread
From: Sridharan S N @ 2023-07-20 8:45 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Sridharan S N
Add the initial device tree support for the Reference Design
Platform(RDPs) 433-mht-phy,433-mht-switch,437,455,456,457,458,459
461,467,469 based on IPQ9574 family of SoC.
This series depends on below patchset:
https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/
Sridharan S N (2):
dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on
IPQ9574 family
arm64: dts: qcom: ipq9574: add support for various RDPs
.../devicetree/bindings/arm/qcom.yaml | 20 ++++++
arch/arm64/boot/dts/qcom/Makefile | 11 ++++
.../boot/dts/qcom/ipq9574-rdp433-mht-phy.dts | 62 +++++++++++++++++++
.../dts/qcom/ipq9574-rdp433-mht-switch.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts | 62 +++++++++++++++++++
arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts | 15 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts | 16 +++++
13 files changed, 298 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-phy.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-switch.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
2023-07-20 8:45 [PATCH 0/2] Add initial support for various RDPs of IPQ9574 family Sridharan S N
@ 2023-07-20 8:45 ` Sridharan S N
2023-07-20 8:49 ` Krzysztof Kozlowski
2023-07-20 8:45 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs Sridharan S N
1 sibling, 1 reply; 9+ messages in thread
From: Sridharan S N @ 2023-07-20 8:45 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Sridharan S N
Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
family of SoCs.
AL02-C3 - rdp437
AL02-C7 - rdp433-mht-phy
AL02-C10 - rdp433-mht-switch
AL02-C11 - rdp467
AL02-C12 - rdp455
AL02-C13 - rdp459
AL02-C15 - rdp457
AL02-C16 - rdp456
AL02-C17 - rdp469
AL02-C19 - rdp461
AL03-C2 - rdp458
Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
.../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index dd66fd872c31..d992261da691 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -89,10 +89,20 @@ description: |
adp
ap-al01-c1
ap-al02-c2
+ ap-al02-c3
ap-al02-c6
ap-al02-c7
ap-al02-c8
ap-al02-c9
+ ap-al02-c10
+ ap-al02-c11
+ ap-al02-c12
+ ap-al02-c13
+ ap-al02-c15
+ ap-al02-c16
+ ap-al02-c17
+ ap-al02-c19
+ ap-al03-c2
ap-mi01.2
ap-mi01.3
ap-mi01.6
@@ -365,10 +375,20 @@ properties:
- enum:
- qcom,ipq9574-ap-al01-c1
- qcom,ipq9574-ap-al02-c2
+ - qcom,ipq9574-ap-al02-c3
- qcom,ipq9574-ap-al02-c6
- qcom,ipq9574-ap-al02-c7
- qcom,ipq9574-ap-al02-c8
- qcom,ipq9574-ap-al02-c9
+ - qcom,ipq9574-ap-al02-c10
+ - qcom,ipq9574-ap-al02-c11
+ - qcom,ipq9574-ap-al02-c12
+ - qcom,ipq9574-ap-al02-c13
+ - qcom,ipq9574-ap-al02-c15
+ - qcom,ipq9574-ap-al02-c16
+ - qcom,ipq9574-ap-al02-c17
+ - qcom,ipq9574-ap-al02-c19
+ - qcom,ipq9574-ap-al03-c2
- const: qcom,ipq9574
- description: Sierra Wireless MangOH Green with WP8548 Module
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs
2023-07-20 8:45 [PATCH 0/2] Add initial support for various RDPs of IPQ9574 family Sridharan S N
2023-07-20 8:45 ` [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on " Sridharan S N
@ 2023-07-20 8:45 ` Sridharan S N
2023-07-20 8:51 ` Krzysztof Kozlowski
1 sibling, 1 reply; 9+ messages in thread
From: Sridharan S N @ 2023-07-20 8:45 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Sridharan S N
Add the initial device tree support for the Reference Design
Platform(RDPs) 433-mht-phy,433-mht-switch,437,455,456,457,458,459
461,467,469 based on IPQ9574 family of SoC.
Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
This patch depends on below patchset:
https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/
arch/arm64/boot/dts/qcom/Makefile | 11 ++++
.../boot/dts/qcom/ipq9574-rdp433-mht-phy.dts | 62 +++++++++++++++++++
.../dts/qcom/ipq9574-rdp433-mht-switch.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts | 62 +++++++++++++++++++
arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts | 15 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts | 16 +++++
arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts | 16 +++++
12 files changed, 278 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-phy.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-switch.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts
create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 9c30344d08c1..81699082d838 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -15,9 +15,20 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c2.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp417.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp418.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433-mht-phy.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433-mht-switch.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp437.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp449.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp453.dtb
dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp455.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp456.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp457.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp458.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp459.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp461.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp467.dtb
+dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp469.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z00l.dtb
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-phy.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-phy.dts
new file mode 100644
index 000000000000..a0e75225051a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-phy.dts
@@ -0,0 +1,62 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 ipq9574-rdp433-mht-phy board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C7";
+ compatible = "qcom,ipq9574-ap-al02-c7", "qcom,ipq9574";
+};
+
+&sdhc_1 {
+ pinctrl-0 = <&sdc_default_state>;
+ pinctrl-names = "default";
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ max-frequency = <384000000>;
+ bus-width = <8>;
+ status = "okay";
+};
+
+&tlmm {
+ sdc_default_state: sdc-default-state {
+ clk-pins {
+ pins = "gpio5";
+ function = "sdc_clk";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "gpio4";
+ function = "sdc_cmd";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "gpio0", "gpio1", "gpio2",
+ "gpio3", "gpio6", "gpio7",
+ "gpio8", "gpio9";
+ function = "sdc_data";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
+ rclk-pins {
+ pins = "gpio10";
+ function = "sdc_rclk";
+ drive-strength = <8>;
+ bias-pull-down;
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-switch.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-switch.dts
new file mode 100644
index 000000000000..47220a31f228
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-mht-switch.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP433-mht-switch board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C10";
+ compatible = "qcom,ipq9574-ap-al02-c10", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts
new file mode 100644
index 000000000000..f3020f87f587
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp437.dts
@@ -0,0 +1,62 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP437 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C3";
+ compatible = "qcom,ipq9574-ap-al02-c3", "qcom,ipq9574";
+};
+
+&sdhc_1 {
+ pinctrl-0 = <&sdc_default_state>;
+ pinctrl-names = "default";
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ max-frequency = <384000000>;
+ bus-width = <8>;
+ status = "okay";
+};
+
+&tlmm {
+ sdc_default_state: sdc-default-state {
+ clk-pins {
+ pins = "gpio5";
+ function = "sdc_clk";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "gpio4";
+ function = "sdc_cmd";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "gpio0", "gpio1", "gpio2",
+ "gpio3", "gpio6", "gpio7",
+ "gpio8", "gpio9";
+ function = "sdc_data";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
+ rclk-pins {
+ pins = "gpio10";
+ function = "sdc_rclk";
+ drive-strength = <8>;
+ bias-pull-down;
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts
new file mode 100644
index 000000000000..d604ad9a7a2c
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp455.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP455 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C12";
+ compatible = "qcom,ipq9574-ap-al02-c12", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
new file mode 100644
index 000000000000..22d69ec8912f
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP456 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C16";
+ compatible = "qcom,ipq9574-ap-al02-c16", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts
new file mode 100644
index 000000000000..801cd9f9e672
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp457.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP457 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C15";
+ compatible = "qcom,ipq9574-ap-al02-c15", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts
new file mode 100644
index 000000000000..388a75dc1181
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp458.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP458 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL03-C2";
+ compatible = "qcom,ipq9574-ap-al03-c2", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts
new file mode 100644
index 000000000000..d445caf6fe11
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp459.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP459 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C13";
+ compatible = "qcom,ipq9574-ap-al02-c13", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts
new file mode 100644
index 000000000000..9f0f2dba81ac
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp461.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP461 board device tree source
+ *
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C19";
+ compatible = "qcom,ipq9574-ap-al02-c19", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts
new file mode 100644
index 000000000000..cba3747da2c6
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp467.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP467 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C11";
+ compatible = "qcom,ipq9574-ap-al02-c11", "qcom,ipq9574";
+};
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts
new file mode 100644
index 000000000000..0e8a7cfdfe69
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp469.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP469 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C17";
+ compatible = "qcom,ipq9574-ap-al02-c17", "qcom,ipq9574";
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
2023-07-20 8:45 ` [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on " Sridharan S N
@ 2023-07-20 8:49 ` Krzysztof Kozlowski
2023-07-20 9:48 ` Konrad Dybcio
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-20 8:49 UTC (permalink / raw)
To: Sridharan S N, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 20/07/2023 10:45, Sridharan S N wrote:
> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
> family of SoCs.
>
> AL02-C3 - rdp437
> AL02-C7 - rdp433-mht-phy
> AL02-C10 - rdp433-mht-switch
> AL02-C11 - rdp467
> AL02-C12 - rdp455
> AL02-C13 - rdp459
> AL02-C15 - rdp457
> AL02-C16 - rdp456
> AL02-C17 - rdp469
> AL02-C19 - rdp461
> AL03-C2 - rdp458
>
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
> .../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index dd66fd872c31..d992261da691 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -89,10 +89,20 @@ description: |
> adp
> ap-al01-c1
> ap-al02-c2
> + ap-al02-c3
> ap-al02-c6
> ap-al02-c7
> ap-al02-c8
> ap-al02-c9
> + ap-al02-c10
> + ap-al02-c11
> + ap-al02-c12
> + ap-al02-c13
> + ap-al02-c15
> + ap-al02-c16
> + ap-al02-c17
> + ap-al02-c19
Why? I asked once, but there was no feedback from Qualcomm.
Why do we need to do this? What's the point?
> + ap-al03-c2
> ap-mi01.2
> ap-mi01.3
> ap-mi01.6
> @@ -365,10 +375,20 @@ properties:
> - enum:
> - qcom,ipq9574-ap-al01-c1
> - qcom,ipq9574-ap-al02-c2
> + - qcom,ipq9574-ap-al02-c3
> - qcom,ipq9574-ap-al02-c6
> - qcom,ipq9574-ap-al02-c7
> - qcom,ipq9574-ap-al02-c8
> - qcom,ipq9574-ap-al02-c9
> + - qcom,ipq9574-ap-al02-c10
> + - qcom,ipq9574-ap-al02-c11
> + - qcom,ipq9574-ap-al02-c12
> + - qcom,ipq9574-ap-al02-c13
> + - qcom,ipq9574-ap-al02-c15
> + - qcom,ipq9574-ap-al02-c16
> + - qcom,ipq9574-ap-al02-c17
> + - qcom,ipq9574-ap-al02-c19
This looks fake. Sorry, but these boards have no differences.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs
2023-07-20 8:45 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs Sridharan S N
@ 2023-07-20 8:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-20 8:51 UTC (permalink / raw)
To: Sridharan S N, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 20/07/2023 10:45, Sridharan S N wrote:
> Add the initial device tree support for the Reference Design
> Platform(RDPs) 433-mht-phy,433-mht-switch,437,455,456,457,458,459
> 461,467,469 based on IPQ9574 family of SoC.
>
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
...
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
> new file mode 100644
> index 000000000000..22d69ec8912f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp456.dts
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * IPQ9574 RDP456 board device tree source
> + *
> + * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "ipq9574-rdp-common.dtsi"
> +
> +/ {
> + model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C16";
> + compatible = "qcom,ipq9574-ap-al02-c16", "qcom,ipq9574";
I am sorry folks, but what are you doing here? Why are you adding all
these DTSes? What is the point? They are all the same. Where is the
product datasheet or description so we can validate it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
2023-07-20 8:49 ` Krzysztof Kozlowski
@ 2023-07-20 9:48 ` Konrad Dybcio
2023-07-26 5:03 ` Sridharan S N
0 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2023-07-20 9:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sridharan S N, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 20.07.2023 10:49, Krzysztof Kozlowski wrote:
> On 20/07/2023 10:45, Sridharan S N wrote:
>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
>> family of SoCs.
>>
>> AL02-C3 - rdp437
>> AL02-C7 - rdp433-mht-phy
>> AL02-C10 - rdp433-mht-switch
>> AL02-C11 - rdp467
>> AL02-C12 - rdp455
>> AL02-C13 - rdp459
>> AL02-C15 - rdp457
>> AL02-C16 - rdp456
>> AL02-C17 - rdp469
>> AL02-C19 - rdp461
>> AL03-C2 - rdp458
>>
>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>> ---
>> .../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index dd66fd872c31..d992261da691 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -89,10 +89,20 @@ description: |
>> adp
>> ap-al01-c1
>> ap-al02-c2
>> + ap-al02-c3
>> ap-al02-c6
>> ap-al02-c7
>> ap-al02-c8
>> ap-al02-c9
>> + ap-al02-c10
>> + ap-al02-c11
>> + ap-al02-c12
>> + ap-al02-c13
>> + ap-al02-c15
>> + ap-al02-c16
>> + ap-al02-c17
>> + ap-al02-c19
>
> Why? I asked once, but there was no feedback from Qualcomm.
>
> Why do we need to do this? What's the point?
Another question would be, whether these boards are just one-off test
prototypes of which there exist like 5-10 units, or are they actually
going to be supported and useful.
If it's the former, I don't think it makes sense to keep the device
trees upstream.
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
2023-07-20 9:48 ` Konrad Dybcio
@ 2023-07-26 5:03 ` Sridharan S N
2023-07-26 7:21 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Sridharan S N @ 2023-07-26 5:03 UTC (permalink / raw)
To: Konrad Dybcio, Krzysztof Kozlowski, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 7/20/2023 3:18 PM, Konrad Dybcio wrote:
> On 20.07.2023 10:49, Krzysztof Kozlowski wrote:
>> On 20/07/2023 10:45, Sridharan S N wrote:
>>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
>>> family of SoCs.
>>>
>>> AL02-C3 - rdp437
>>> AL02-C7 - rdp433-mht-phy
>>> AL02-C10 - rdp433-mht-switch
>>> AL02-C11 - rdp467
>>> AL02-C12 - rdp455
>>> AL02-C13 - rdp459
>>> AL02-C15 - rdp457
>>> AL02-C16 - rdp456
>>> AL02-C17 - rdp469
>>> AL02-C19 - rdp461
>>> AL03-C2 - rdp458
>>>
>>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>>> ---
>>> .../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++
>>> 1 file changed, 20 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index dd66fd872c31..d992261da691 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -89,10 +89,20 @@ description: |
>>> adp
>>> ap-al01-c1
>>> ap-al02-c2
>>> + ap-al02-c3
>>> ap-al02-c6
>>> ap-al02-c7
>>> ap-al02-c8
>>> ap-al02-c9
>>> + ap-al02-c10
>>> + ap-al02-c11
>>> + ap-al02-c12
>>> + ap-al02-c13
>>> + ap-al02-c15
>>> + ap-al02-c16
>>> + ap-al02-c17
>>> + ap-al02-c19
>> Why? I asked once, but there was no feedback from Qualcomm.
>>
>> Why do we need to do this? What's the point?
> Another question would be, whether these boards are just one-off test
> prototypes of which there exist like 5-10 units, or are they actually
> going to be supported and useful.
>
> If it's the former, I don't think it makes sense to keep the device
> trees upstream.
>
> Konrad
These are all not test rdps and each rdps has its own configurations.
IPQ9574 has four pcie instances and one QDSP processor. Not all rdps use
all of the interfaces and it will vary for each rdp. In next version ,
will post with each rdp's configuration explicitly
Thanks,
Sridharan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
2023-07-26 5:03 ` Sridharan S N
@ 2023-07-26 7:21 ` Krzysztof Kozlowski
2023-08-03 11:11 ` Sridharan S N
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-26 7:21 UTC (permalink / raw)
To: Sridharan S N, Konrad Dybcio, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 26/07/2023 07:03, Sridharan S N wrote:
>
> On 7/20/2023 3:18 PM, Konrad Dybcio wrote:
>> On 20.07.2023 10:49, Krzysztof Kozlowski wrote:
>>> On 20/07/2023 10:45, Sridharan S N wrote:
>>>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
>>>> family of SoCs.
>>>>
>>>> AL02-C3 - rdp437
>>>> AL02-C7 - rdp433-mht-phy
>>>> AL02-C10 - rdp433-mht-switch
>>>> AL02-C11 - rdp467
>>>> AL02-C12 - rdp455
>>>> AL02-C13 - rdp459
>>>> AL02-C15 - rdp457
>>>> AL02-C16 - rdp456
>>>> AL02-C17 - rdp469
>>>> AL02-C19 - rdp461
>>>> AL03-C2 - rdp458
>>>>
>>>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>>>> ---
>>>> .../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++
>>>> 1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>> index dd66fd872c31..d992261da691 100644
>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>> @@ -89,10 +89,20 @@ description: |
>>>> adp
>>>> ap-al01-c1
>>>> ap-al02-c2
>>>> + ap-al02-c3
>>>> ap-al02-c6
>>>> ap-al02-c7
>>>> ap-al02-c8
>>>> ap-al02-c9
>>>> + ap-al02-c10
>>>> + ap-al02-c11
>>>> + ap-al02-c12
>>>> + ap-al02-c13
>>>> + ap-al02-c15
>>>> + ap-al02-c16
>>>> + ap-al02-c17
>>>> + ap-al02-c19
>>> Why? I asked once, but there was no feedback from Qualcomm.
>>>
>>> Why do we need to do this? What's the point?
>> Another question would be, whether these boards are just one-off test
>> prototypes of which there exist like 5-10 units, or are they actually
>> going to be supported and useful.
>>
>> If it's the former, I don't think it makes sense to keep the device
>> trees upstream.
>>
>> Konrad
>
> These are all not test rdps and each rdps has its own configurations.
> IPQ9574 has four pcie instances and one QDSP processor. Not all rdps use
> all of the interfaces and it will vary for each rdp. In next version ,
> will post with each rdp's configuration explicitly
So still no answer why do we need to list it as possible boards.
Especially that it messes with compatible style, because c[1-9] looks
like board version.
I suggest don't add these board types and drop existing ones.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on IPQ9574 family
2023-07-26 7:21 ` Krzysztof Kozlowski
@ 2023-08-03 11:11 ` Sridharan S N
0 siblings, 0 replies; 9+ messages in thread
From: Sridharan S N @ 2023-08-03 11:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Konrad Dybcio, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel
On 7/26/2023 12:51 PM, Krzysztof Kozlowski wrote:
> On 26/07/2023 07:03, Sridharan S N wrote:
>> On 7/20/2023 3:18 PM, Konrad Dybcio wrote:
>>> On 20.07.2023 10:49, Krzysztof Kozlowski wrote:
>>>> On 20/07/2023 10:45, Sridharan S N wrote:
>>>>> Document the below listed (Reference Design Platform) RDP boards based on IPQ9574
>>>>> family of SoCs.
>>>>>
>>>>> AL02-C3 - rdp437
>>>>> AL02-C7 - rdp433-mht-phy
>>>>> AL02-C10 - rdp433-mht-switch
>>>>> AL02-C11 - rdp467
>>>>> AL02-C12 - rdp455
>>>>> AL02-C13 - rdp459
>>>>> AL02-C15 - rdp457
>>>>> AL02-C16 - rdp456
>>>>> AL02-C17 - rdp469
>>>>> AL02-C19 - rdp461
>>>>> AL03-C2 - rdp458
>>>>>
>>>>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>>>>> ---
>>>>> .../devicetree/bindings/arm/qcom.yaml | 20 +++++++++++++++++++
>>>>> 1 file changed, 20 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> index dd66fd872c31..d992261da691 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>>>> @@ -89,10 +89,20 @@ description: |
>>>>> adp
>>>>> ap-al01-c1
>>>>> ap-al02-c2
>>>>> + ap-al02-c3
>>>>> ap-al02-c6
>>>>> ap-al02-c7
>>>>> ap-al02-c8
>>>>> ap-al02-c9
>>>>> + ap-al02-c10
>>>>> + ap-al02-c11
>>>>> + ap-al02-c12
>>>>> + ap-al02-c13
>>>>> + ap-al02-c15
>>>>> + ap-al02-c16
>>>>> + ap-al02-c17
>>>>> + ap-al02-c19
>>>> Why? I asked once, but there was no feedback from Qualcomm.
>>>>
>>>> Why do we need to do this? What's the point?
>>> Another question would be, whether these boards are just one-off test
>>> prototypes of which there exist like 5-10 units, or are they actually
>>> going to be supported and useful.
>>>
>>> If it's the former, I don't think it makes sense to keep the device
>>> trees upstream.
>>>
>>> Konrad
>> These are all not test rdps and each rdps has its own configurations.
>> IPQ9574 has four pcie instances and one QDSP processor. Not all rdps use
>> all of the interfaces and it will vary for each rdp. In next version ,
>> will post with each rdp's configuration explicitly
>
> So still no answer why do we need to list it as possible boards.
> Especially that it messes with compatible style, because c[1-9] looks
> like board version.
>
> I suggest don't add these board types and drop existing ones.
>
>
> Best regards,
> Krzysztof
Apologize for the late reply. IPQ bootloader doesn't need these info. we
will send the patch to drop the existing ones
Thanks,
Sridharan
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-08-03 11:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 8:45 [PATCH 0/2] Add initial support for various RDPs of IPQ9574 family Sridharan S N
2023-07-20 8:45 ` [PATCH 1/2] dt-bindings: arm: qcom: document AL02-Cx and AL03-C2 boards based on " Sridharan S N
2023-07-20 8:49 ` Krzysztof Kozlowski
2023-07-20 9:48 ` Konrad Dybcio
2023-07-26 5:03 ` Sridharan S N
2023-07-26 7:21 ` Krzysztof Kozlowski
2023-08-03 11:11 ` Sridharan S N
2023-07-20 8:45 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for various RDPs Sridharan S N
2023-07-20 8:51 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).