From: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
NXP S32 Linux Team <s32@nxp.com>
Subject: Re: [PATCH] arm64: dts: s32g: add the pinctrl node
Date: Tue, 23 Jul 2024 16:56:32 +0300 [thread overview]
Message-ID: <87c53abf-080e-4e70-b5e2-b38ef9443983@oss.nxp.com> (raw)
In-Reply-To: <b4985dc2-73e5-4917-9015-f891938c8880@kernel.org>
Hi Krzysztof,
Thank you for the prompt review!
On 23/07/2024 16:38, Krzysztof Kozlowski wrote:
> On 23/07/2024 14:37, Andrei Stefanescu wrote:
>> + status = "okay";
>
> Where did you disable it?
It isn't disabled anywhere. I thought we should always have it enabled since most of the
other drivers will rely on it. Should I add it here disabled and enable it in the
board specific .dts files (in this case: s32g399a-rdb3.dts, s32g274a-rdb2.dts and
s32g274a-evb.dts)?
>
>> +
>> + jtag_pins: jtag_pins {
>
> Underscores are not allowed. Please follow DTS coding style. The
> mainline one, not NXP coding style. Several other places here have also
> issues, so be sure you read if carefully.
Thank you! I will send a V2 with "jtag_pins: jtag-pins {" and
all the other subnodes renamed to "jtag-grp*".
>
>> timer {
>
> Best regards,
> Krzysztof
>
Best regards,
Andrei
next prev parent reply other threads:[~2024-07-23 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 12:37 [PATCH] arm64: dts: s32g: add the pinctrl node Andrei Stefanescu
2024-07-23 13:38 ` Krzysztof Kozlowski
2024-07-23 13:56 ` Andrei Stefanescu [this message]
2024-07-23 14:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87c53abf-080e-4e70-b5e2-b38ef9443983@oss.nxp.com \
--to=andrei.stefanescu@oss.nxp.com \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).