devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Keerthy <j-keerthy@ti.com>,
	robh+dt@kernel.org, daniel.lezcano@linaro.org,
	rui.zhang@intel.com, amitk@kernel.org, kristo@kernel.org
Cc: linux-pm@vger.kernel.org, vigneshr@ti.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] arm64: dts: ti: j721e: Add VTM node
Date: Wed, 13 Apr 2022 12:14:00 +0200	[thread overview]
Message-ID: <87c8d5ea-49e5-a85f-161b-49d0f7f1c345@linaro.org> (raw)
In-Reply-To: <20220412101409.7980-3-j-keerthy@ti.com>

On 12/04/2022 12:14, Keerthy wrote:
> VTM stands for Voltage Thermal Management
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      |  9 +++
>  arch/arm64/boot/dts/ti/k3-j721e-thermal.dtsi  | 73 +++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-j721e.dtsi          |  4 +
>  3 files changed, 86 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-j721e-thermal.dtsi
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index b4972dfb7da8..6290f563b8e7 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -418,4 +418,13 @@
>  		interrupt-names = "int0", "int1";
>  		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>  	};
> +
> +	wkup_vtm0: wkup_vtm0@42040000 {

No, same comments as Rob gave you for bindings patch.

Please fix them in entire patchset, instead of ignoring.


Best regards,
Krzysztof

  parent reply	other threads:[~2022-04-13 10:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 10:14 [PATCH v5 0/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-04-12 10:14 ` [PATCH v5 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Keerthy
2022-04-13  8:07   ` Daniel Lezcano
2022-04-13 10:13   ` Krzysztof Kozlowski
2022-04-13 12:04     ` J, KEERTHY
2022-04-13 12:25       ` Krzysztof Kozlowski
2022-04-14 15:57       ` Rob Herring
2022-04-12 10:14 ` [PATCH v5 2/4] arm64: dts: ti: j721e: Add VTM node Keerthy
2022-04-12 17:09   ` Vignesh Raghavendra
2022-04-12 23:43     ` J, KEERTHY
2022-04-13 10:14   ` Krzysztof Kozlowski [this message]
2022-04-12 10:14 ` [PATCH v5 3/4] arm64: dts: ti: j7200: " Keerthy
2022-04-13 10:14   ` Krzysztof Kozlowski
2022-04-12 10:14 ` [PATCH v5 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support Keerthy
2022-04-12 17:00   ` kernel test robot
2022-04-13 10:17   ` Krzysztof Kozlowski
2022-04-19 17:23   ` Daniel Lezcano
2022-04-20  7:01   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87c8d5ea-49e5-a85f-161b-49d0f7f1c345@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=kristo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).