Devicetree
 help / color / mirror / Atom feed
From: "Flávio Amieiro" <flavio@amieiro.net>
To: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@kernel.org>,
	Griffin Kroah-Hartman <griffin@kroah.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] leds: is31f132xx: Add support for is31fl3206
Date: Fri, 13 Nov 2026 13:51:54 -0300	[thread overview]
Message-ID: <87cxs87jyt.fsf@berlin> (raw)
In-Reply-To: <179370064610.793788.8239015594326628135@kernel.org>


Thank you very much for the review.

> Lee Jones <lee@kernel.org> writes:
> --- checkpatch.pl (1 issue) ---
> Line 83: WARNING: DT compatible string "issi,is31fl3206" appears un-documented -- check ./Documentation/devicetree/bindings/
> ----------------------------------
>

This is documented in the first patch of the series, as requested as
part of the review for v1[1].

> On Wed, 28 Oct 2026, Flavio Amieiro wrote:
>
>> + * @enable_bit_offset_in_led_control_reg determines the offset of the
>> + * enable bits from the least significant bit of the LED control
>
> Make sure you run W=1, particularly when changing Kerneldoc.
>

I checked and get no warnings with `make W=1
./drivers/leds/leds-is31fl32xx.o`, `./scripts/checkpatch.pl --strict`,
and `./scripts/kernel-doc -N drivers/leds/leds-is31fl32xx.c`. Am I
missing some other check here?

Again, thank you very much for the review. I will address the other
points and send a v5 as soon as possible.

Best regards,
Flávio Amieiro


[1]: https://lore.kernel.org/all/20261013-jolly-salamander-of-tact-7cf46e@quoll/

      reply	other threads:[~2026-11-13 16:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 21:31 [PATCH v4 0/2] leds: Add support for the is31fl3206 LED driver Flavio Amieiro
2026-10-28 21:31 ` [PATCH v4 1/2] dt-bindings: leds: Add issi,is31fl3206 to leds-is31fl32xx Flavio Amieiro
2026-10-28 21:31 ` [PATCH v4 2/2] leds: is31f132xx: Add support for is31fl3206 Flavio Amieiro
2026-10-30 13:09   ` Griffin Kroah-Hartman
2026-11-13 11:26   ` Lee Jones
2026-11-13 16:51     ` Flávio Amieiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxs87jyt.fsf@berlin \
    --to=flavio@amieiro.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=griffin@kroah.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox