Re: [PATCH v7 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM

[Steffen Trumtrar <s.trumtrar@pengutronix.de>]

Hi Alexandre,

Alexandre TORGUE <alexandre.torgue@foss.st.com> writes:
>> +		gpu_reserved: gpu@f8000000 {
>> +			reg = <0xf8000000 0x8000000>;
>> +			no-map;
>> +		};
>
> It seems that this region is not used. Furthermore if you plan to use it to GPU
> note that it doesn't respect YAMl verification. So please remove it.
>

Ack. Will remove.

>> +&ethernet0 {
>> +	pinctrl-0 = <&ethernet0_rgmii_pins_d>;
>> +	pinctrl-1 = <&ethernet0_rgmii_sleep_pins_d>;
>> +	pinctrl-names = "default", "sleep";
>> +	phy-mode = "rgmii-id";
>> +	max-speed = <1000>;
>> +	phy-handle = <&phy0>;
>> +	st,eth-clk-sel;
>> +	clock-names = "stmmaceth",
>> +		      "mac-clk-tx",
>> +		      "mac-clk-rx",
>> +		      "eth-ck",
>> +		      "syscfg-clk",
>> +		      "ethstp";
>> +	clocks = <&rcc ETHMAC>,
>> +		 <&rcc ETHTX>,
>> +		 <&rcc ETHRX>,
>> +		 <&rcc ETHCK_K>,
>> +		 <&rcc SYSCFG>,
>> +		 <&rcc ETHSTP>;
>
> Why do you re define those clocks ? They are all already defined in
> stm32mp151.dtsi
>

Just an oversight :( Will remove.


Thanks,
Steffen

--
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |