From: Kalle Valo <kvalo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: gokulsri@codeaurora.org, sboyd@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, sricharan@codeaurora.org,
ath11k@lists.infradead.org
Subject: Re: [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe
Date: Fri, 09 Oct 2020 14:27:41 +0300 [thread overview]
Message-ID: <87d01r1vwy.fsf@codeaurora.org> (raw)
In-Reply-To: <20201009082625.GD23649@linux> (Manivannan Sadhasivam's message of "Fri, 9 Oct 2020 13:56:25 +0530")
+ ath11k list
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> On Thu, Oct 08, 2020 at 11:03:42PM +0530, gokulsri@codeaurora.org wrote:
>> On 2020-10-08 18:41, Manivannan Sadhasivam wrote:
>> > Hi,
>> >
>> > On Thu, Oct 08, 2020 at 06:02:24PM +0530, Gokul Sriram Palanisamy wrote:
>> > > Enabled MHI device support over PCIe and added memory
>> > > reservation required for MHI enabled QCN9000 PCIe card.
>> > >
>> > > Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org>
>> > > ---
>> > > arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 47
>> > > ++++++++++++++++++++++++++++++
>> > > 1 file changed, 47 insertions(+)
>> > >
>> > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
>> > > b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
>> > > index 0827055..e5c1ec0 100644
>> > > --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
>> > > +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi
>
> [...]
>
>> > > + pcie0_rp: pcie0_rp {
>> > > + reg = <0 0 0 0 0>;
>> > > +
>> > > + status = "ok";
>> > > + mhi_0: qcom,mhi@0 {
>> >
>> > MHI doesn't support devicetree as of now so how is this supposed to
>> > work?
>> > Have you tested this series with mainline?
>> >
>> > Thanks,
>> > Mani
>> >
>>
>> Hi Mani,
>> This node entries will be consumed by ath11k driver and is not supposed to
>> be consumed by mhi driver.
>> And yes, it is tested on Mainline.
Upstream ath11k does not yet support QCN9074 so I don't see how this is
tested with mainline ath11k. You must be using some out-of-tree
_unofficial_ ath11k patches.
> Can you please point me to the relevant binding or the code which consumes this
> change?
>
> Also please explain what it does! For enabling MHI support over PCIe you don't
> need this node at all. You just need to define the PCIe device ID in the ath11k
> driver and that's it.
>
> Adding Kalle to this thread...
So currently QCN9074 firmware needs 55 MB of contiguous host memory and
I suspect one reason for these DT entries is an ugly hack to provide
that memory range to the firmware.
We are currently preparing QCN9074 patches for ath11k and finding a
solution how to implement these properly in ath11k. Hopefully there's no
need for hacks like this, we know more once we get the ath11k QCN9074
patches ready. Please drop this patch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-10-09 11:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 12:32 [PATCH v3 0/3] Add board support for HK10 board variants Gokul Sriram Palanisamy
2020-10-08 12:32 ` [PATCH v3 1/3] dt-bindings: qcom: Add ipq8074 bindings Gokul Sriram Palanisamy
2020-10-08 12:32 ` [PATCH v3 2/3] arm64: dts: Add board support for HK10 Gokul Sriram Palanisamy
2020-10-08 12:32 ` [PATCH v3 3/3] arm64: dts: Enabled MHI device over PCIe Gokul Sriram Palanisamy
2020-10-08 13:11 ` Manivannan Sadhasivam
2020-10-08 17:33 ` gokulsri
2020-10-09 8:26 ` Manivannan Sadhasivam
2020-10-09 11:27 ` Kalle Valo [this message]
2020-10-08 18:16 ` kernel test robot
2020-10-08 22:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d01r1vwy.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=agross@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gokulsri@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).