From: Felipe Balbi <balbi@kernel.org>
To: Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Douglas <adouglas@cadence.com>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Tue, 11 Dec 2018 14:15:39 +0200 [thread overview]
Message-ID: <87d0q8mf84.fsf@linux.intel.com> (raw)
In-Reply-To: <BYAPR07MB47095A5EEBC106EE7CD0E078DDA60@BYAPR07MB4709.namprd07.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi,
Pawel Laszczak <pawell@cadence.com> writes:
>>I think what Felipe meant was to only combine the gadget driver code into one patch.
>>
>>The series could be split into 6 patches like so.
>>-dt binding
>>-pci glue
>>-core driver
>>-host driver
>>-gadget driver
>>-drd driver
>
> Felipe wrote:
> "
> Frankly, I don't understand why this is a series. It's a single driver
> and splitting it into a series just makes it more difficult to review,
> actually.
>
> Sure, a single patch will be large, but there's no way to have a
> functional driver until all patches are applied, anyway.
> "
>
> Felipe should I split this driver as suggested by Roger ?.
> Now it's very big patch but it's still a single driver.
don't bother. It's far easier to review as it is.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-12-11 12:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-11 10:16 ` Roger Quadros
2018-12-13 9:20 ` Peter Chen
2018-12-13 9:25 ` Pawel Laszczak
2018-12-20 20:01 ` Rob Herring
2018-12-22 22:24 ` Pawel Laszczak
2018-12-27 21:01 ` Rob Herring
2018-12-31 5:35 ` Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-11 9:39 ` Roger Quadros
2018-12-11 10:01 ` Pawel Laszczak
2018-12-11 12:15 ` Felipe Balbi [this message]
2018-12-11 11:46 ` Felipe Balbi
2018-12-11 12:14 ` Felipe Balbi
2018-12-11 19:04 ` Pawel Laszczak
2018-12-12 2:04 ` Peter Chen
2018-12-12 6:55 ` Felipe Balbi
2018-12-12 7:38 ` Peter Chen
2018-12-12 8:34 ` Felipe Balbi
2018-12-12 9:24 ` Peter Chen
2018-12-12 15:53 ` Bin Liu
2018-12-13 1:21 ` Peter Chen
2018-12-12 6:52 ` Felipe Balbi
2018-12-14 3:46 ` Kishon Vijay Abraham I
2018-12-17 5:46 ` Pawel Laszczak
2018-12-17 11:25 ` Pawel Laszczak
2018-12-17 11:34 ` Felipe Balbi
2018-12-17 11:51 ` Pawel Laszczak
2018-12-17 11:56 ` Felipe Balbi
2018-12-13 9:35 ` Peter Chen
2018-12-16 13:01 ` Pawel Laszczak
2018-12-14 22:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0q8mf84.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=adouglas@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).