From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 3/5] spi: pxa2xx: use an enum for type
Date: Fri, 21 Sep 2018 22:34:03 +0200 [thread overview]
Message-ID: <87d0t64mkk.fsf@belgarion.home> (raw)
In-Reply-To: <20180910115935.163121-4-lkundrak@v3.sk> (Lubomir Rintel's message of "Mon, 10 Sep 2018 13:59:33 +0200")
Lubomir Rintel <lkundrak@v3.sk> writes:
> That seems to be the correct type.
Okay, but what happens here when adev_id->driver_data is a value out of enum
range ? Does the following assignment make sense ?
> + type = (enum pxa_ssp_type)adev_id->driver_data;
As a side note, could you join for the next throw to the review :
- Jarkko Nikula <jarkko.nikula@linux.intel.com>
- Mika Westerberg <mika.westerberg@linux.intel.com>
Even if they are Intel, I think they have worked a lot on this driver for Intel
platforms.
Cheers.
--
Robert
next prev parent reply other threads:[~2018-09-21 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 11:59 [PATCH 0/5] Make SPI work on DT MMP2 Lubomir Rintel
2018-09-10 11:59 ` [PATCH 1/5] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller Lubomir Rintel
2018-09-17 3:00 ` Rob Herring
2018-09-10 11:59 ` [PATCH 2/5] PCI: provide pci_match_id() with CONFIG_PCI=n Lubomir Rintel
2018-09-12 17:17 ` Bjorn Helgaas
2018-09-10 11:59 ` [PATCH 3/5] spi: pxa2xx: use an enum for type Lubomir Rintel
2018-09-21 20:34 ` Robert Jarzmik [this message]
2018-10-09 16:43 ` Lubomir Rintel
2018-10-10 17:26 ` Lubomir Rintel
2018-09-10 11:59 ` [PATCH 4/5] spi: pxa2xx: add devicetree support Lubomir Rintel
2018-09-10 11:59 ` [PATCH 5/5] DT: marvell,mmp2: add SSP1 and SSP3 Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0t64mkk.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).