From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v4 9/9] ASoC: add audio-graph-card support
Date: Tue, 21 Mar 2017 02:08:30 +0000
Message-ID: <87d1dbbd14.wl%kuninori.morimoto.gx@renesas.com>
References: <8760jdivfm.wl%kuninori.morimoto.gx@renesas.com>
 <87shmhhghc.wl%kuninori.morimoto.gx@renesas.com>
 <CAL_JsqJFNnBUDN4AjseZN4zWh1dH30c1ay=0sYAnY3-6td0LSg@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
In-Reply-To: <CAL_JsqJFNnBUDN4AjseZN4zWh1dH30c1ay=0sYAnY3-6td0LSg@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Rob Herring <robh+dt@kernel.org>
Cc: Linux-DT <devicetree@vger.kernel.org>, Linux-ALSA <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
List-Id: devicetree@vger.kernel.org


Hi Rob

Thank you for your review

> > +       if (rcpu_ep != cpu_ep) {
> > +               dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n",
> > +                       cpu_ep->name, codec_ep->name, rcpu_ep->name);
> > +               return -EINVAL;
> > +       }
> 
> We should have this check in dtc rather than the kernel.

We can remove this if dtc could support it

> > +       while ((np = of_parse_phandle(node, "dais", idx))) {
> 
> of_for_each_phandle
(snip)
> > +       if (of_get_property(node, "dais", NULL)) {
> > +               while (of_parse_phandle(node, "dais", count))
> 
> of_for_each_phandle

Thanks. will use it

> > +                       count++;
> > +       } else {
> > +               count = 1;
> 
> This should be an error or 0, right?

Yes, thanks. will do


Best regards
---
Kuninori Morimoto