devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Linux-DT <devicetree@vger.kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Simon <horms@verge.net.au>
Subject: [PATCH 01/10] ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_audio_routing
Date: Fri, 27 Jan 2017 06:36:50 +0000	[thread overview]
Message-ID: <87d1f9qadv.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87efzpqaf5.wl%kuninori.morimoto.gx@renesas.com>

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Because prototype of OF-graph sound card support didn't have Sound Card
node, commit 7364c8dc255232db33bcd1c5b19eb8f34cf6108a
("ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_routing")
adjusted to it on each functions.

But final discussion result of ALSA SoC / OF-graph ML, OF-graph sound
card has node. Thus, this commit became no longer needed.

This reverts commit 7364c8dc255232db33bcd1c5b19eb8f34cf6108a.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 include/sound/soc.h  | 9 ++-------
 sound/soc/soc-core.c | 9 +++------
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/include/sound/soc.h b/include/sound/soc.h
index b86168a..c7b0a5c 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -1671,13 +1671,8 @@ void snd_soc_of_parse_audio_prefix_from_node(struct snd_soc_card *card,
 				   struct snd_soc_codec_conf *codec_conf,
 				   struct device_node *of_node,
 				   const char *propname);
-
-#define snd_soc_of_parse_audio_routing(card, propname) \
-	snd_soc_of_parse_audio_routing_from_node(card, NULL, propname)
-int snd_soc_of_parse_audio_routing_from_node(struct snd_soc_card *card,
-					     struct device_node *np,
-					     const char *propname);
-
+int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
+				   const char *propname);
 unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 				     const char *prefix,
 				     struct device_node **bitclkmaster,
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index baa1afa..dcaca32 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3690,17 +3690,14 @@ void snd_soc_of_parse_audio_prefix_from_node(struct snd_soc_card *card,
 }
 EXPORT_SYMBOL_GPL(snd_soc_of_parse_audio_prefix_from_node);
 
-int snd_soc_of_parse_audio_routing_from_node(struct snd_soc_card *card,
-				   struct device_node *np,
+int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
 				   const char *propname)
 {
+	struct device_node *np = card->dev->of_node;
 	int num_routes;
 	struct snd_soc_dapm_route *routes;
 	int i, ret;
 
-	if (!np)
-		np = card->dev->of_node;
-
 	num_routes = of_property_count_strings(np, propname);
 	if (num_routes < 0 || num_routes & 1) {
 		dev_err(card->dev,
@@ -3747,7 +3744,7 @@ int snd_soc_of_parse_audio_routing_from_node(struct snd_soc_card *card,
 
 	return 0;
 }
-EXPORT_SYMBOL_GPL(snd_soc_of_parse_audio_routing_from_node);
+EXPORT_SYMBOL_GPL(snd_soc_of_parse_audio_routing);
 
 unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
 				     const char *prefix,
-- 
1.9.1

  reply	other threads:[~2017-01-27  6:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27  6:36 [PATCH 00/10] ASoC: add OF-graph base simple-card Kuninori Morimoto
2017-01-27  6:36 ` Kuninori Morimoto [this message]
2017-01-31 20:02   ` Applied "ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_audio_routing" to the asoc tree Mark Brown
     [not found] ` <87efzpqaf5.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-27  6:37   ` [PATCH 02/10] ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_audio_prefix Kuninori Morimoto
2017-01-31 20:02     ` Applied "ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_audio_prefix" to the asoc tree Mark Brown
2017-01-27  6:37   ` [PATCH 03/10] ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_audio_simple_widgets Kuninori Morimoto
2017-01-31 20:02     ` Applied "ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_audio_simple_widgets" to the asoc tree Mark Brown
2017-01-27  6:37   ` [PATCH 04/10] ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_card_name Kuninori Morimoto
2017-01-31 20:02     ` Applied "ASoC: soc-core: remove OF adjusting for snd_soc_of_parse_card_name" to the asoc tree Mark Brown
2017-01-27  6:38   ` [PATCH 05/10] of_graph: add of_graph_get_port_parent() Kuninori Morimoto
2017-01-27  6:38   ` [PATCH 06/10] of_graph: add of_graph_get_endpoint_count() Kuninori Morimoto
2017-01-27  6:39   ` [PATCH 07/10] ASoC: add snd_soc_get_dai_id() Kuninori Morimoto
2017-01-27  6:39   ` [PATCH 08/10] ASoC: simple-card-utils: add asoc_simple_card_parse_graph_dai() Kuninori Morimoto
2017-01-27  6:39   ` [PATCH 09/10] ASoC: add simple-graph-card document Kuninori Morimoto
2017-01-27  6:40   ` [PATCH 10/10] ASoC: add simple-graph-card support Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1f9qadv.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=horms@verge.net.au \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).