From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v7 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Date: Wed, 19 Nov 2014 17:49:49 +0000 Message-ID: <87d28jaxmq.fsf@approximate.cambridge.arm.com> References: <1416406451-4578-1-git-send-email-yingjoe.chen@mediatek.com> <1416406451-4578-4-git-send-email-yingjoe.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1416406451-4578-4-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> (Yingjoe Chen's message of "Wed, 19 Nov 2014 14:14:10 +0000") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yingjoe Chen Cc: Thomas Gleixner , Jiang Liu , Mark Rutland , Boris BREZILLON , Russell King , Jason Cooper , Pawel Moll , "devicetree@vger.kernel.org" , "hc.yen@mediatek.com" , "srv_heupstream@mediatek.com" , "yh.chen@mediatek.com" , "linux-kernel@vger.kernel.org" , "grant.likely@linaro.org" , Yijing Wang , Rob Herring , "nathan.chung@mediatek.com" , "yingjoe.chen@gmail.com" , Matthias Brugger , "eddie.huang@mediatek.com" List-Id: devicetree@vger.kernel.org On Wed, Nov 19 2014 at 2:14:10 pm GMT, Yingjoe Chen wrote: > Add sysirq settings for mt6589/mt8135/mt8127 > This also correct timer interrupt flag. The old setting works > because boot loader already set polarity for timer interrupt. > Without intpol support, the setting was not changed so gic > can get the irq correctly. > > Signed-off-by: Yingjoe Chen > --- > arch/arm/boot/dts/mt6589.dtsi | 14 ++++++++++++-- > arch/arm/boot/dts/mt8127.dtsi | 14 ++++++++++++-- > arch/arm/boot/dts/mt8135.dtsi | 14 ++++++++++++-- > 3 files changed, 36 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/mt6589.dtsi b/arch/arm/boot/dts/mt6589.dtsi > index e3c7600..c91b2a9 100644 > --- a/arch/arm/boot/dts/mt6589.dtsi > +++ b/arch/arm/boot/dts/mt6589.dtsi > @@ -19,7 +19,7 @@ > > / { > compatible = "mediatek,mt6589"; > - interrupt-parent = <&gic>; > + interrupt-parent = <&sysirq>; This worries me a bit. Your sysirq cannot handle PPIs, and yet you make it the top-level interrupt controller, without amending any PPI. Does it mean you do not use *any* PPI? No per-cpu timer, nothing? Thanks, M. -- Jazz is not dead. It just smells funny. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html