From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [alsa-devel] [PATCH v4] ASoC: simple-card: add Device Tree support Date: Sun, 01 Dec 2013 20:57:45 -0800 (PST) Message-ID: <87d2lfdf3v.wl%kuninori.morimoto.gx@renesas.com> References: <87eh97sqw7.wl%kuninori.morimoto.gx@renesas.com> <87txharb3o.wl%kuninori.morimoto.gx@renesas.com> <8738oiog00.wl%kuninori.morimoto.gx@renesas.com> <20131003104248.GI27287@sirena.org.uk> <87fvsh2966.wl%kuninori.morimoto.gx@renesas.com> <20131024171758.GA2461@kartoffel> <87iowm9jwv.wl%kuninori.morimoto.gx@renesas.com> <20131115155028.GE24831@e106331-lin.cambridge.arm.com> <87li0ldso8.wl%kuninori.morimoto.gx@renesas.com> <871u2aziuu.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <871u2aziuu.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux-ALSA , Lars-Peter Clausen , Pawel Moll , Stephen Warren , Takashi Iwai , Mark Brown , Ian Campbell , Liam Girdwood , Simon List-Id: devicetree@vger.kernel.org Hi Rob ping ? > > >> Still not really a fan of this generic name. Can we define in the > > >> description above what simple means. > > > > > > So, how about "simple-audio-card" ? > > > > That's missing my point. First, I think you should be defining the > > actual h/w in the DT and doing the mapping of that to a simple audio > > driver in the kernel. Otherwise how do you fix some quirk on a > > particular platform later on without updating the DTB? I'm fine with > > this being the default compatible string, but you should also require > > a more specific name. Perhaps it is just -simple-audio or > > -simple-audio. > > > > Second, you need to define in this binding document what simple means. > > What properties of the audio subsystem make it simple? The h/w has and > > doesn't have what? How do I decide if my platform can or should use > > this binding? > > Basically, on ASoC case, SoC/board needs --audio-card > (= not simple card) for matching each other, and this is start point. > This means we need many --audio-card.c driver. > But, in some case, the difference between > - <-> - <-> - <-> - > was just "name". creating too many such driver was not sane for me. > This simple-audio is used in such case. > Of course we can update simple-audio feature > (if it is very simple/common feature) > but, if you need -audio-card which needs special feature, > you need to create such driver without using simple-card. > This is very normal approach on ASoC and there are many such driver. > > Best regards > --- > Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html