From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 740B8664B4 for ; Tue, 20 Feb 2024 11:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708428072; cv=none; b=a0qME1b/u1BMoGYdezhUGbzkoyyr/PKnCvMn1yruTJpOiL1Tkd2UzfsWDBIaLVUxq+cPYOxSMsN1nf1HEXx+P+ql5Hoy3QRi3DVBbs+VaNyU9I0NM8crY0h8EqaIC00i+w+q+vj03mSWTGawjR7Pn+zEusX/2+kMqeLUzATIzYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708428072; c=relaxed/simple; bh=y2cTHdbhs+jP0V9l7RAJIUV6y6Yy4DW5bJt20AokuGg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TfGuEjKP63kq2PcMwuFoqK8/FG6OkYp0wBpYEnpHe9CPzsefw+7eCsZr1r/lnj8cySLbnUJw8mlkI8hixmm5n1ObEOORaXCcmMcD8aKw0YOopfuh68tIDnlXmDUJGdhSca0NUiJkkGylbqyh4SFioW57c5GfLGN7M6hwvff+xdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LEk8YPZy; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LEk8YPZy" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4126d65ace3so5175015e9.3 for ; Tue, 20 Feb 2024 03:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708428069; x=1709032869; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KnrvsBqw7QbtpacZxecYVdwct8vCTDyR5tnhTxKnDkI=; b=LEk8YPZyLGaFY8XqmsQsHiNRQZ0BLHCIgMKUPOkbgigjjCvKxi2l8jgLmguSiSW2Qo ufVyD1BFisTQV+GeZUxHDVspdo1lV3MxpZSDkSa/rJEphhIpPy44qPsrjmQf2h0RqNJK s/PBlhIPbtJCfX/BwzN5UvX8oZuRdnJp+/dNIGb+N6TPr9i2KmvMXrikH3b45fshd0j6 QRoyEIlO3M9/W0J3HhOnvNiD9J5z0Vs0/ohiJvbmsowaM8r/cHLUpqN54ZUjd7+r5z9P 8P5MlJkqPRn4vzWG9NTS2JK3487UIhUgghXnuTLPNThKI08IIzlJU1XEvqGn7Ftjp0Kw VMzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708428069; x=1709032869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KnrvsBqw7QbtpacZxecYVdwct8vCTDyR5tnhTxKnDkI=; b=aFItI3CsSl8mAjZ1fihSZ03i7j3GWIDCbUtW/E73gqGRf/0wQQIqybo0rtrmfR8Yzr PixQh0SBXMlRwwUu1okuDljbAOxb0PKxg8bJMR7W2eptsmNhwT0I/cC2/gjUaaTQgQRy r23N+bf+GjBCAOk6GOyR/y9eLPYu7lMf9dzvNT+z/jP+kU7fr6zqs75eT1oY40kh1g/K QIG7i1vqAnZV9ZP9SBwPMHIl2fFPoiCrL/WspJ/4E8bWAgyLUCDfwlwkS8hgaRcDXK2j DZBMcTkgfMcDLhsxmO0lfbcOdYMos56itRw7unntStwJaZmbx45PcRw8kUsi/+tmJT2y gqcA== X-Gm-Message-State: AOJu0YzyD2XC9L/cKI7kfGRTDyzWFlMSRPvgYLwnNTc3wGYu9ZuXpXWs xvEHWlSbnMe6FvCeh2CA9fGAiNa1Oy/NE2RaYxzCZzx7xEZ2SZQiH/RmRGp2ARo= X-Google-Smtp-Source: AGHT+IFPZI6mIvGokJt1X4VUEHcuPhIk2yyf27bMhmEMYYX9mw53cNbqyZDIkb1WvUBZVhkhJjcrdg== X-Received: by 2002:adf:e10f:0:b0:33d:509c:5692 with SMTP id t15-20020adfe10f000000b0033d509c5692mr3941935wrz.31.1708428068775; Tue, 20 Feb 2024 03:21:08 -0800 (PST) Received: from [192.168.232.100] (31-187-2-170.dynamic.upc.ie. [31.187.2.170]) by smtp.gmail.com with ESMTPSA id b17-20020a05600010d100b0033ce1ef4e7asm13108972wrx.13.2024.02.20.03.21.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 03:21:08 -0800 (PST) Message-ID: <87db77f7-fda4-4cf7-adfd-8545c40c3365@linaro.org> Date: Tue, 20 Feb 2024 11:21:05 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC WIP PATCH] venus: add qcom,no-low-power property Content-Language: en-US To: Marc Gonzalez , Dmitry Baryshkov , Konrad Dybcio Cc: DT , linux-media , MSM , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson References: <0843621b-386b-4173-9e3c-9538cdb4641d@freebox.fr> <81dc6452-4039-4eb4-92ba-df248215fca2@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/02/2024 10:56 a.m., Marc Gonzalez wrote: > On 19/02/2024 20:24, Bryan O'Donoghue wrote: > >> On 19/02/2024 5:44 p.m., Dmitry Baryshkov wrote: >> >>> On Mon, 19 Feb 2024 at 19:29, Konrad Dybcio wrote: >>>> >>>> On 19.02.2024 18:18, Marc Gonzalez wrote: >>>> >>>>> On our msm8998-based device, calling venus_sys_set_power_control() >>>>> breaks playback. Since the vendor kernel never calls it, we assume >>>>> it should not be called for this device/FW combo. >>>> >>>> FWIW, this is also broken on other SoCs.. 8280/8350 and 6115 >>>> to name a couple. >>> >>> Then let's just disable it until it gets unbroken? >> >> Its functional on most of our upstream stuff though, why switch if off >> unless necessary ? >> >> Maybe it should be an opt-in instead of an opt-out, TBH my own feeling >> is its better to minimize the amount of work and opt as per the proposed >> patch. >> >> Perhaps the qcom vidc team can give insights on 8280xp and 8350 when we >> come to tackling new HFI6XX and later SoCs ... > > I was wondering if the chosen property name might cause issues later... > > Thinking "qcom,no-low-power" might be a bit too general? > Perhaps would need to mention venus somewhere in the name, > to limit this to the video decoder? > > Regards > Yep, the word venus should probably appear in the property name. --- bod