[PATCH V2 0/6] imx: add i.MX8MP hdmi blk ctrl hdcp/hrv and vpu blk ctrl

[PATCH V2 0/6] imx: add i.MX8MP hdmi blk ctrl hdcp/hrv and vpu blk ctrl

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

V2:
 - Add A-b from DT maintainer for patch 1
 - Per DT maintainer, I added description for items. To
 make it consistent, I also added description to i.MX8MM.
 - Per Adam, change VPU H1/h1 to VC8000E/vc8000e in the patchset.

This patchset is to add more blk ctrl support for i.MX8MP
 - Add HDMI HDCP/HRV BLK CTRL support
 - Add VPU BLK CTRL support
 - Add PGC VPU node which supplies power domain for VPU BLK
This patchset is based on:
https://lore.kernel.org/all/20220708085632.1918323-1-peng.fan@oss.nxp.com/

repo: https://github.com/MrVan/linux/tree/imx8mp-blk-ctrl

Peng Fan (6):
  dt-bindings: power: imx8mp-power: add HDMI HDCP/HRV
  dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
  soc: imx: add i.MX8MP HDMI blk ctrl HDCP/HRV
  soc: imx: imx8m-blk-ctrl: add i.MX8MP VPU blk ctrl
  arm64: dts: imx8mp: add vpu pgc nodes
  arm64: dts: imx8mp: add VPU blk ctrl node

 .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 93 ++++++++++++++++---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi     | 45 +++++++++
 drivers/soc/imx/imx8m-blk-ctrl.c              | 43 +++++++++
 drivers/soc/imx/imx8mp-blk-ctrl.c             | 30 ++++++
 include/dt-bindings/power/imx8mp-power.h      |  6 ++
 5 files changed, 206 insertions(+), 11 deletions(-)

-- 
2.25.1

[PATCH V2 1/6] dt-bindings: power: imx8mp-power: add HDMI HDCP/HRV

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Add i.MX8MP HDMI HDCP and HRV entries.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 include/dt-bindings/power/imx8mp-power.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/dt-bindings/power/imx8mp-power.h b/include/dt-bindings/power/imx8mp-power.h
index 7789bcca3223..14b9c5ac9c82 100644
--- a/include/dt-bindings/power/imx8mp-power.h
+++ b/include/dt-bindings/power/imx8mp-power.h
@@ -49,5 +49,7 @@
 #define IMX8MP_HDMIBLK_PD_TRNG				4
 #define IMX8MP_HDMIBLK_PD_HDMI_TX			5
 #define IMX8MP_HDMIBLK_PD_HDMI_TX_PHY			6
+#define IMX8MP_HDMIBLK_PD_HDCP				7
+#define IMX8MP_HDMIBLK_PD_HRV				8
 
 #endif
-- 
2.25.1

[PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
the i.MX8MM VPU blk ctrl yaml file. And add description for the items.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 93 ++++++++++++++++---
 include/dt-bindings/power/imx8mp-power.h      |  4 +
 2 files changed, 86 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
index 26487daa64d9..d05930f61f95 100644
--- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
@@ -28,24 +28,15 @@ properties:
 
   power-domains:
     minItems: 4
-    maxItems: 4
 
   power-domain-names:
-    items:
-      - const: bus
-      - const: g1
-      - const: g2
-      - const: h1
+    minItems: 4
 
   clocks:
     minItems: 3
-    maxItems: 3
 
   clock-names:
-    items:
-      - const: g1
-      - const: g2
-      - const: h1
+    minItems: 3
 
 required:
   - compatible
@@ -55,6 +46,86 @@ required:
   - clocks
   - clock-names
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx8mm-vpu-blk-ctrl
+    then:
+      properties:
+        power-domains:
+          items:
+            - description: bus power domain
+            - description: G1 decoder power domain
+            - description: G2 decoder power domain
+            - description: H1 encoder power domain
+
+        power-domain-names:
+          items:
+            - const: bus
+            - const: g1
+            - const: g2
+            - const: h1
+
+        clocks:
+          items:
+            - description: G1 decoder clk
+            - description: G2 decoder clk
+            - description: H1 encoder clk
+
+        clock-names:
+          items:
+            - const: g1
+            - const: g2
+            - const: h1
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx8mp-vpu-blk-ctrl
+    then:
+      properties:
+        power-domains:
+          items:
+            - description: bus power domain
+            - description: G1 decoder power domain
+            - description: G2 decoder power domain
+            - description: VC8000E encoder power domain
+
+        power-domain-names:
+          items:
+            - const: bus
+            - const: g1
+            - const: g2
+            - const: vc8000e
+
+        clocks:
+          items:
+            - description: G1 decoder clk
+            - description: G2 decoder clk
+            - description: VC8000E encoder clk
+
+        clock-names:
+          items:
+            - const: g1
+            - const: g2
+            - const: vc8000e
+
+        interconnects:
+          items:
+            - description: G1 decoder interconnect
+            - description: G2 decoder interconnect
+            - description: VC8000E encoder interconnect
+
+        interconnect-names:
+          items:
+            - const: g1
+            - const: g2
+            - const: vc8000e
+
+
 additionalProperties: false
 
 examples:
diff --git a/include/dt-bindings/power/imx8mp-power.h b/include/dt-bindings/power/imx8mp-power.h
index 14b9c5ac9c82..2fe3c2abad13 100644
--- a/include/dt-bindings/power/imx8mp-power.h
+++ b/include/dt-bindings/power/imx8mp-power.h
@@ -52,4 +52,8 @@
 #define IMX8MP_HDMIBLK_PD_HDCP				7
 #define IMX8MP_HDMIBLK_PD_HRV				8
 
+#define IMX8MP_VPUBLK_PD_G1				0
+#define IMX8MP_VPUBLK_PD_G2				1
+#define IMX8MP_VPUBLK_PD_VC8000E			2
+
 #endif
-- 
2.25.1

[PATCH V2 3/6] soc: imx: add i.MX8MP HDMI blk ctrl HDCP/HRV

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

i.MX8MP HDMI supports HDCP and HRV, so add them.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/soc/imx/imx8mp-blk-ctrl.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c
index 6f983adcb47c..527d45d12a54 100644
--- a/drivers/soc/imx/imx8mp-blk-ctrl.c
+++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
@@ -235,6 +235,13 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc,
 		regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(12));
 		regmap_clear_bits(bc->regmap, HDMI_TX_CONTROL0, BIT(3));
 		break;
+	case IMX8MP_HDMIBLK_PD_HDCP:
+		regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0, BIT(11));
+		break;
+	case IMX8MP_HDMIBLK_PD_HRV:
+		regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(3) | BIT(4) | BIT(5));
+		regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(15));
+		break;
 	default:
 		break;
 	}
@@ -283,6 +290,13 @@ static void imx8mp_hdmi_blk_ctrl_power_off(struct imx8mp_blk_ctrl *bc,
 		regmap_clear_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(12));
 		regmap_clear_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(22) | BIT(24));
 		break;
+	case IMX8MP_HDMIBLK_PD_HDCP:
+		regmap_clear_bits(bc->regmap, HDMI_RTX_CLK_CTL0, BIT(11));
+		break;
+	case IMX8MP_HDMIBLK_PD_HRV:
+		regmap_clear_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(15));
+		regmap_clear_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(3) | BIT(4) | BIT(5));
+		break;
 	default:
 		break;
 	}
@@ -365,6 +379,22 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = {
 		.num_clks = 2,
 		.gpc_name = "hdmi-tx-phy",
 	},
+	[IMX8MP_HDMIBLK_PD_HRV] = {
+		.name = "hdmiblk-hrv",
+		.clk_names = (const char *[]){ "axi", "apb" },
+		.num_clks = 2,
+		.gpc_name = "hrv",
+		.path_names = (const char *[]){"hrv"},
+		.num_paths = 1,
+	},
+	[IMX8MP_HDMIBLK_PD_HDCP] = {
+		.name = "hdmiblk-hdcp",
+		.clk_names = (const char *[]){ "axi", "apb" },
+		.num_clks = 2,
+		.gpc_name = "hdcp",
+		.path_names = (const char *[]){"hdcp"},
+		.num_paths = 1,
+	},
 };
 
 static const struct imx8mp_blk_ctrl_data imx8mp_hdmi_blk_ctl_dev_data = {
-- 
2.25.1

[PATCH V2 4/6] soc: imx: imx8m-blk-ctrl: add i.MX8MP VPU blk ctrl

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

i.MX8MP has a VPU blk ctrl module that could supply clk and reset to
VPU, so add support for it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/soc/imx/imx8m-blk-ctrl.c | 43 ++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index 9b0f81dc292b..871a387c6b41 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -484,6 +484,46 @@ static const struct imx8m_blk_ctrl_data imx8mm_vpu_blk_ctl_dev_data = {
 	.num_domains = ARRAY_SIZE(imx8mm_vpu_blk_ctl_domain_data),
 };
 
+static const struct imx8m_blk_ctrl_domain_data imx8mp_vpu_blk_ctl_domain_data[] = {
+	[IMX8MP_VPUBLK_PD_G1] = {
+		.name = "vpublk-g1",
+		.clk_names = (const char *[]){ "g1", },
+		.num_clks = 1,
+		.gpc_name = "g1",
+		.rst_mask = BIT(1),
+		.clk_mask = BIT(1),
+		.path_names = (const char *[]){"g1"},
+		.num_paths = 1,
+	},
+	[IMX8MP_VPUBLK_PD_G2] = {
+		.name = "vpublk-g2",
+		.clk_names = (const char *[]){ "g2", },
+		.num_clks = 1,
+		.gpc_name = "g2",
+		.rst_mask = BIT(0),
+		.clk_mask = BIT(0),
+		.path_names = (const char *[]){"g2"},
+		.num_paths = 1,
+	},
+	[IMX8MP_VPUBLK_PD_VC8000E] = {
+		.name = "vpublk-vc8000e",
+		.clk_names = (const char *[]){ "vc8000e", },
+		.num_clks = 1,
+		.gpc_name = "vc8000e",
+		.rst_mask = BIT(2),
+		.clk_mask = BIT(2),
+		.path_names = (const char *[]){"vc8000e"},
+		.num_paths = 1,
+	},
+};
+
+static const struct imx8m_blk_ctrl_data imx8mp_vpu_blk_ctl_dev_data = {
+	.max_reg = 0x18,
+	.power_notifier_fn = imx8mm_vpu_power_notifier,
+	.domains = imx8mp_vpu_blk_ctl_domain_data,
+	.num_domains = ARRAY_SIZE(imx8mp_vpu_blk_ctl_domain_data),
+};
+
 static int imx8mm_disp_power_notifier(struct notifier_block *nb,
 				      unsigned long action, void *data)
 {
@@ -827,6 +867,9 @@ static const struct of_device_id imx8m_blk_ctrl_of_match[] = {
 	}, {
 		.compatible = "fsl,imx8mq-vpu-blk-ctrl",
 		.data = &imx8mq_vpu_blk_ctl_dev_data
+	}, {
+		.compatible = "fsl,imx8mp-vpu-blk-ctrl",
+		.data = &imx8mp_vpu_blk_ctl_dev_data
 	}, {
 		/* Sentinel */
 	}
-- 
2.25.1

[PATCH V2 5/6] arm64: dts: imx8mp: add vpu pgc nodes

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Add i.MX8MP PGC nodes for vpu, which are used to supply power for VPU.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27 +++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 0b165f98a82c..34af983b0210 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
 						reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
 						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
 					};
+
+					pgc_vpumix: power-domain@19 {
+						#power-domain-cells = <0>;
+						reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
+						clocks =<&clk IMX8MP_CLK_VPU_ROOT>;
+					};
+
+					pgc_vpu_g1: power-domain@20 {
+						#power-domain-cells = <0>;
+						power-domains = <&pgc_vpumix>;
+						reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
+						clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
+					};
+
+					pgc_vpu_g2: power-domain@21 {
+						#power-domain-cells = <0>;
+						power-domains = <&pgc_vpumix>;
+						reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
+						clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
+					};
+
+					pgc_vpu_vc8000e: power-domain@22 {
+						#power-domain-cells = <0>;
+						power-domains = <&pgc_vpumix>;
+						reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
+						clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
+					};
 				};
 			};
 		};
-- 
2.25.1

[PATCH V2 6/6] arm64: dts: imx8mp: add VPU blk ctrl node

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Add i.MX8MP VPU blk ctrl node

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 34af983b0210..493fc3ceec1f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1185,6 +1185,24 @@ gic: interrupt-controller@38800000 {
 			interrupt-parent = <&gic>;
 		};
 
+		vpumix_blk_ctrl: blk-ctrl@38330000 {
+			compatible = "fsl,imx8mp-vpu-blk-ctrl", "syscon";
+			reg = <0x38330000 0x100>;
+			#power-domain-cells = <1>;
+			power-domains = <&pgc_vpumix>, <&pgc_vpu_g1>,
+					<&pgc_vpu_g2>, <&pgc_vpu_vc8000e>;
+			power-domain-names = "bus", "g1", "g2", "vc8000e";
+			clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>,
+				 <&clk IMX8MP_CLK_VPU_G2_ROOT>,
+				 <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
+			clock-names = "g1", "g2", "vc8000e";
+			interconnects = <&noc IMX8MP_ICM_VPU_G1 &noc IMX8MP_ICN_VIDEO>,
+					<&noc IMX8MP_ICM_VPU_G2 &noc IMX8MP_ICN_VIDEO>,
+					<&noc IMX8MP_ICM_VPU_H1 &noc IMX8MP_ICN_VIDEO>;
+			interconnect-names = "g1", "g2", "vc8000e";
+		};
+
+
 		edacmc: memory-controller@3d400000 {
 			compatible = "snps,ddrc-3.80a";
 			reg = <0x3d400000 0x400000>;
-- 
2.25.1

Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

[Krzysztof Kozlowski]

On 13/07/2022 08:36, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
> the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 93 ++++++++++++++++---
>  include/dt-bindings/power/imx8mp-power.h      |  4 +
>  2 files changed, 86 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> index 26487daa64d9..d05930f61f95 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> @@ -28,24 +28,15 @@ properties:
>  
>    power-domains:
>      minItems: 4
> -    maxItems: 4

This is not correct. maxItems must stay, but you could drop minItems,
prefferrably in separate patch.

>  
>    power-domain-names:
> -    items:
> -      - const: bus
> -      - const: g1
> -      - const: g2
> -      - const: h1
> +    minItems: 4

maxItems instead

>  
>    clocks:
>      minItems: 3
> -    maxItems: 3

Same error...

Best regards,
Krzysztof

RE: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

[Peng Fan]

Hi Krzysztof,

> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
> 
> On 13/07/2022 08:36, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
> > the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 93 ++++++++++++++++---
> >  include/dt-bindings/power/imx8mp-power.h      |  4 +
> >  2 files changed, 86 insertions(+), 11 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> ctrl.ya
> > ml
> > b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> ctrl.ya
> > ml index 26487daa64d9..d05930f61f95 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> ctrl.ya
> > ml
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> ctr
> > +++ l.yaml
> > @@ -28,24 +28,15 @@ properties:
> >
> >    power-domains:
> >      minItems: 4
> > -    maxItems: 4
> 
> This is not correct. maxItems must stay, but you could drop minItems,
> prefferrably in separate patch.
[Peng Fan] 

Ok, I will only keep maxItems. For separate patch, you mean
separate adding description for i.MX8MM to one patch, right?

> 
> >
> >    power-domain-names:
> > -    items:
> > -      - const: bus
> > -      - const: g1
> > -      - const: g2
> > -      - const: h1
> > +    minItems: 4
> 
> maxItems instead

Got it. Will only keep maxItems

> 
> >
> >    clocks:
> >      minItems: 3
> > -    maxItems: 3
> 
> Same error...
Got it. Will only keep maxItems

Thanks,
Peng.
> 
> Best regards,
> Krzysztof

Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

[Krzysztof Kozlowski]

On 13/07/2022 11:03, Peng Fan wrote:
> Hi Krzysztof,
> 
>> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
>>
>> On 13/07/2022 08:36, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
>>> the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>  .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 93 ++++++++++++++++---
>>>  include/dt-bindings/power/imx8mp-power.h      |  4 +
>>>  2 files changed, 86 insertions(+), 11 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
>> ctrl.ya
>>> ml
>>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
>> ctrl.ya
>>> ml index 26487daa64d9..d05930f61f95 100644
>>> ---
>>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
>> ctrl.ya
>>> ml
>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
>> ctr
>>> +++ l.yaml
>>> @@ -28,24 +28,15 @@ properties:
>>>
>>>    power-domains:
>>>      minItems: 4
>>> -    maxItems: 4
>>
>> This is not correct. maxItems must stay, but you could drop minItems,
>> prefferrably in separate patch.
> [Peng Fan] 
> 
> Ok, I will only keep maxItems. For separate patch, you mean
> separate adding description for i.MX8MM to one patch, right?

I mean, a new patch doing cleanup. You currently have minItems and
maxItems set as the same value. In such case minItems is not necessary.
You could remove all of minItems (when equal to maxItems) before adding
new device support.


Best regards,
Krzysztof

RE: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

[Peng Fan]

> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
> 
> On 13/07/2022 11:03, Peng Fan wrote:
> > Hi Krzysztof,
> >
> >> Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu
> >> blk ctrl
> >>
> >> On 13/07/2022 08:36, Peng Fan (OSS) wrote:
> >>> From: Peng Fan <peng.fan@nxp.com>
> >>>
> >>> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
> >>> the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
> >>>
> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >>> ---
> >>>  .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml      | 93 ++++++++++++++++---
> >>>  include/dt-bindings/power/imx8mp-power.h      |  4 +
> >>>  2 files changed, 86 insertions(+), 11 deletions(-)
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> >> ctrl.ya
> >>> ml
> >>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> >> ctrl.ya
> >>> ml index 26487daa64d9..d05930f61f95 100644
> >>> ---
> >>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-
> >> ctrl.ya
> >>> ml
> >>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-
> blk-
> >> ctr
> >>> +++ l.yaml
> >>> @@ -28,24 +28,15 @@ properties:
> >>>
> >>>    power-domains:
> >>>      minItems: 4
> >>> -    maxItems: 4
> >>
> >> This is not correct. maxItems must stay, but you could drop minItems,
> >> prefferrably in separate patch.
> > [Peng Fan]
> >
> > Ok, I will only keep maxItems. For separate patch, you mean separate
> > adding description for i.MX8MM to one patch, right?
> 
> I mean, a new patch doing cleanup. You currently have minItems and
> maxItems set as the same value. In such case minItems is not necessary.
> You could remove all of minItems (when equal to maxItems) before adding
> new device support.

Thanks, got it. I will wait for a few days to collect comments on other
parts before V3.

Thanks,
Peng.
> 
> 
> Best regards,
> Krzysztof

Re: [PATCH V2 6/6] arm64: dts: imx8mp: add VPU blk ctrl node

[kernel test robot]

Hi "Peng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on linus/master v5.19-rc6 next-20220715]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/imx-add-i-MX8MP-hdmi-blk-ctrl-hdcp-hrv-and-vpu-blk-ctrl/20220713-143746
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: arm64-buildonly-randconfig-r003-20220714 (https://download.01.org/0day-ci/archive/20220716/202207161526.eF3Q4LDD-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61b9c556267086ef9b743a0b57df302eef831b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/be95b11efe846d01a6f40eda8a8c7750f53155e4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Peng-Fan-OSS/imx-add-i-MX8MP-hdmi-blk-ctrl-hdcp-hrv-and-vpu-blk-ctrl/20220713-143746
        git checkout be95b11efe846d01a6f40eda8a8c7750f53155e4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/freescale/imx8mp.dtsi:1181.26-27 syntax error
   FATAL ERROR: Unable to parse input tree

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes

[Greg Ungerer]

On 22/8/22 14:45, Peng Fan wrote:
> Add i.MX8MP PGC nodes for vpu, which are used to supply power for VPU.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27 +++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 0b165f98a82c..34af983b0210 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
>                                                 reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
>                                                 clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
>                                         };
> +
> +                                       pgc_vpumix: power-domain@19 {
> +                                               #power-domain-cells = <0>;
> +                                               reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
> +                                               clocks =<&clk IMX8MP_CLK_VPU_ROOT>;
> +                                       };
> +
> +                                       pgc_vpu_g1: power-domain@20 {
> +                                               #power-domain-cells = <0>;
> +                                               power-domains = <&pgc_vpumix>;
> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
> +                                               clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
> +                                       };
> +
> +                                       pgc_vpu_g2: power-domain@21 {
> +                                               #power-domain-cells = <0>;
> +                                               power-domains = <&pgc_vpumix>;
> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
> +                                               clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
> +                                       };
> +
> +                                       pgc_vpu_vc8000e: power-domain@22 {
> +                                               #power-domain-cells = <0>;
> +                                               power-domains = <&pgc_vpumix>;
> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> +                                               clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
> +                                       };
>                                 };
>                         };
>                 };

This change causes new error messages to come out during boot, for example:

    ...
    imx-pgc imx-pgc-domain.8: failed to command PGC
    imx-pgc imx-pgc-domain.8: failed to command PGC
    imx-pgc imx-pgc-domain.8: failed to command PGC
    30890000.serial: ttymxc1 at MMIO 0x30890000 (irq = 197, base_baud = 1500000) is a IMX
    ...
    hwmon hwmon1: temp1_input not attached to any thermal zone
    imx-pgc imx-pgc-domain.8: failed to command PGC
    imx-pgc imx-pgc-domain.8: failed to command PGC
    imx-pgc imx-pgc-domain.8: failed to command PGC
    ...

They don't seem to cause any problems on the hardware I am using, well,
at least not that I have found so far.

This first appeared for me in linux-6.1. But it is the same in todays
linux 6.3-rc4. Reverting this change (not completely trivial due to a
couple of commits after it that rely on it) fixes it - no more errors.

Regards
Greg

RE: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes

[Peng Fan]

> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
> 
> On 22/8/22 14:45, Peng Fan wrote:
> > Add i.MX8MP PGC nodes for vpu, which are used to supply power for VPU.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27
> > +++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 0b165f98a82c..34af983b0210 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
> >                                                 reg =
> <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
> >                                                 clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
> >                                         };
> > +
> > +                                       pgc_vpumix: power-domain@19 {
> > +                                               #power-domain-cells = <0>;
> > +                                               reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
> > +                                               clocks =<&clk IMX8MP_CLK_VPU_ROOT>;
> > +                                       };
> > +
> > +                                       pgc_vpu_g1: power-domain@20 {
> > +                                               #power-domain-cells = <0>;
> > +                                               power-domains = <&pgc_vpumix>;
> > +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
> > +                                               clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
> > +                                       };
> > +
> > +                                       pgc_vpu_g2: power-domain@21 {
> > +                                               #power-domain-cells = <0>;
> > +                                               power-domains = <&pgc_vpumix>;
> > +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
> > +                                               clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
> > +                                       };
> > +
> > +                                       pgc_vpu_vc8000e: power-domain@22 {
> > +                                               #power-domain-cells = <0>;
> > +                                               power-domains = <&pgc_vpumix>;
> > +                                               reg =
> <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> > +                                               clocks = <&clk
> IMX8MP_CLK_VPU_VC8KE_ROOT>;
> > +                                       };
> >                                 };
> >                         };
> >                 };
> 
> This change causes new error messages to come out during boot, for
> example:
> 
>     ...
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     30890000.serial: ttymxc1 at MMIO 0x30890000 (irq = 197, base_baud =
> 1500000) is a IMX
>     ...
>     hwmon hwmon1: temp1_input not attached to any thermal zone
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     ...
> 
> They don't seem to cause any problems on the hardware I am using, well, at
> least not that I have found so far.
> 
> This first appeared for me in linux-6.1. But it is the same in todays linux 6.3-
> rc4. Reverting this change (not completely trivial due to a couple of commits
> after it that rely on it) fixes it - no more errors.
[Peng Fan] 

The VPU BLK CTRL seems not enabled.

Regards,
Peng.

> 
> Regards
> Greg
> 

Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes

[Greg Ungerer]

Hi Peng,

On 27/3/23 20:01, Peng Fan wrote:
>> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
>>
>> On 22/8/22 14:45, Peng Fan wrote:
>>> Add i.MX8MP PGC nodes for vpu, which are used to supply power for VPU.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
>>> ---
>>>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27
>>> +++++++++++++++++++++++
>>>   1 file changed, 27 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> index 0b165f98a82c..34af983b0210 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
>>>                                                  reg =
>> <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
>>>                                                  clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
>>>                                          };
>>> +
>>> +                                       pgc_vpumix: power-domain@19 {
>>> +                                               #power-domain-cells = <0>;
>>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
>>> +                                               clocks =<&clk IMX8MP_CLK_VPU_ROOT>;
>>> +                                       };
>>> +
>>> +                                       pgc_vpu_g1: power-domain@20 {
>>> +                                               #power-domain-cells = <0>;
>>> +                                               power-domains = <&pgc_vpumix>;
>>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
>>> +                                               clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
>>> +                                       };
>>> +
>>> +                                       pgc_vpu_g2: power-domain@21 {
>>> +                                               #power-domain-cells = <0>;
>>> +                                               power-domains = <&pgc_vpumix>;
>>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
>>> +                                               clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
>>> +                                       };
>>> +
>>> +                                       pgc_vpu_vc8000e: power-domain@22 {
>>> +                                               #power-domain-cells = <0>;
>>> +                                               power-domains = <&pgc_vpumix>;
>>> +                                               reg =
>> <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
>>> +                                               clocks = <&clk
>> IMX8MP_CLK_VPU_VC8KE_ROOT>;
>>> +                                       };
>>>                                  };
>>>                          };
>>>                  };
>>
>> This change causes new error messages to come out during boot, for
>> example:
>>
>>      ...
>>      imx-pgc imx-pgc-domain.8: failed to command PGC
>>      imx-pgc imx-pgc-domain.8: failed to command PGC
>>      imx-pgc imx-pgc-domain.8: failed to command PGC
>>      30890000.serial: ttymxc1 at MMIO 0x30890000 (irq = 197, base_baud =
>> 1500000) is a IMX
>>      ...
>>      hwmon hwmon1: temp1_input not attached to any thermal zone
>>      imx-pgc imx-pgc-domain.8: failed to command PGC
>>      imx-pgc imx-pgc-domain.8: failed to command PGC
>>      imx-pgc imx-pgc-domain.8: failed to command PGC
>>      ...
>>
>> They don't seem to cause any problems on the hardware I am using, well, at
>> least not that I have found so far.
>>
>> This first appeared for me in linux-6.1. But it is the same in todays linux 6.3-
>> rc4. Reverting this change (not completely trivial due to a couple of commits
>> after it that rely on it) fixes it - no more errors.
> [Peng Fan]
> 
> The VPU BLK CTRL seems not enabled.

How to enable it?
I have the blk-ctrl config options enabled:

     #
     # i.MX SoC drivers
     #
     CONFIG_IMX_GPCV2_PM_DOMAINS=y
     CONFIG_SOC_IMX8M=y
     CONFIG_SOC_IMX9=y
     CONFIG_IMX8M_BLK_CTRL=y
     CONFIG_IMX9_BLK_CTRL=y
     # end of i.MX SoC drivers

Running with the full arm64 defconfig and using the imx8mp-evk.dtb still
outputs these messages:

     [   18.150679] imx-pgc imx-pgc-domain.8: failed to command PGC
     [   18.159241] imx-pgc imx-pgc-domain.8: failed to command PGC
     [   18.167822] imx-pgc imx-pgc-domain.8: failed to command PGC

Or do you mean something more fundamental, like the hardware block not
being enabled by boot loader?  (Something to keep in mind is that the
platform I am using has no video output, only serial console).

Regards
Greg

RE: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes

[Peng Fan]

> -----Original Message-----
> From: Greg Ungerer <gerg@linux-m68k.org>
> Sent: 2023年3月27日 21:24
> To: Peng Fan <peng.fan@nxp.com>; Peng Fan (OSS)
> <peng.fan@oss.nxp.com>
> Cc: Markus.Niebel@ew.tq-group.com; aford173@gmail.com; Aisheng Dong
> <aisheng.dong@nxp.com>; alexander.stein@ew.tq-group.com;
> devicetree@vger.kernel.org; festevam@gmail.com; kernel@pengutronix.de;
> krzysztof.kozlowski+dt@linaro.org; l.stach@pengutronix.de;
> laurent.pinchart@ideasonboard.com; linux-arm-kernel@lists.infradead.org;
> dl-linux-imx <linux-imx@nxp.com>; linux-kernel@vger.kernel.org;
> marex@denx.de; paul.elder@ideasonboard.com; robh+dt@kernel.org;
> s.hauer@pengutronix.de; shawnguo@kernel.org; gerg@kernel.org
> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
> 
> Hi Peng,
> 
> On 27/3/23 20:01, Peng Fan wrote:
> >> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
> >>
> >> On 22/8/22 14:45, Peng Fan wrote:
> >>> Add i.MX8MP PGC nodes for vpu, which are used to supply power for
> VPU.
> >>>
> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >>> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> >>> ---
> >>>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27
> >>> +++++++++++++++++++++++
> >>>   1 file changed, 27 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >>> index 0b165f98a82c..34af983b0210 100644
> >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >>> @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
> >>>                                                  reg =
> >> <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
> >>>                                                  clocks = <&clk
> IMX8MP_CLK_MEDIA_ISP_ROOT>;
> >>>                                          };
> >>> +
> >>> +                                       pgc_vpumix: power-domain@19 {
> >>> +                                               #power-domain-cells = <0>;
> >>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
> >>> +                                               clocks =<&clk IMX8MP_CLK_VPU_ROOT>;
> >>> +                                       };
> >>> +
> >>> +                                       pgc_vpu_g1: power-domain@20 {
> >>> +                                               #power-domain-cells = <0>;
> >>> +                                               power-domains = <&pgc_vpumix>;
> >>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
> >>> +                                               clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
> >>> +                                       };
> >>> +
> >>> +                                       pgc_vpu_g2: power-domain@21 {
> >>> +                                               #power-domain-cells = <0>;
> >>> +                                               power-domains = <&pgc_vpumix>;
> >>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
> >>> +                                               clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
> >>> +                                       };
> >>> +
> >>> +                                       pgc_vpu_vc8000e: power-domain@22 {
> >>> +                                               #power-domain-cells = <0>;
> >>> +                                               power-domains = <&pgc_vpumix>;
> >>> +                                               reg =
> >> <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> >>> +                                               clocks = <&clk
> >> IMX8MP_CLK_VPU_VC8KE_ROOT>;
> >>> +                                       };
> >>>                                  };
> >>>                          };
> >>>                  };
> >>
> >> This change causes new error messages to come out during boot, for
> >> example:
> >>
> >>      ...
> >>      imx-pgc imx-pgc-domain.8: failed to command PGC
> >>      imx-pgc imx-pgc-domain.8: failed to command PGC
> >>      imx-pgc imx-pgc-domain.8: failed to command PGC
> >>      30890000.serial: ttymxc1 at MMIO 0x30890000 (irq = 197,
> >> base_baud =
> >> 1500000) is a IMX
> >>      ...
> >>      hwmon hwmon1: temp1_input not attached to any thermal zone
> >>      imx-pgc imx-pgc-domain.8: failed to command PGC
> >>      imx-pgc imx-pgc-domain.8: failed to command PGC
> >>      imx-pgc imx-pgc-domain.8: failed to command PGC
> >>      ...
> >>
> >> They don't seem to cause any problems on the hardware I am using,
> >> well, at least not that I have found so far.
> >>
> >> This first appeared for me in linux-6.1. But it is the same in todays
> >> linux 6.3- rc4. Reverting this change (not completely trivial due to
> >> a couple of commits after it that rely on it) fixes it - no more errors.
> > [Peng Fan]
> >
> > The VPU BLK CTRL seems not enabled.
> 
> How to enable it?
> I have the blk-ctrl config options enabled:
> 
>      #
>      # i.MX SoC drivers
>      #
>      CONFIG_IMX_GPCV2_PM_DOMAINS=y
>      CONFIG_SOC_IMX8M=y
>      CONFIG_SOC_IMX9=y
>      CONFIG_IMX8M_BLK_CTRL=y
>      CONFIG_IMX9_BLK_CTRL=y
>      # end of i.MX SoC drivers
> 
> Running with the full arm64 defconfig and using the imx8mp-evk.dtb still
> outputs these messages:
> 
>      [   18.150679] imx-pgc imx-pgc-domain.8: failed to command PGC
>      [   18.159241] imx-pgc imx-pgc-domain.8: failed to command PGC
>      [   18.167822] imx-pgc imx-pgc-domain.8: failed to command PGC
> 
> Or do you mean something more fundamental, like the hardware block not
> being enabled by boot loader?  (Something to keep in mind is that the
> platform I am using has no video output, only serial console).
[Peng Fan] 

The imx8mp vpu blk ctrl already in imx8m-blk-ctrl.c, so it should work.
Have you enabled imx8mp interconnect driver?
CONFIG_INTERCONNECT_IMX8MP

Regards,
Peng.

> 
> Regards
> Greg

Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes

[Greg Ungerer]

On 28/3/23 12:15, Peng Fan wrote:
> 
> 
>> -----Original Message-----
>> From: Greg Ungerer <gerg@linux-m68k.org>
>> Sent: 2023年3月27日 21:24
>> To: Peng Fan <peng.fan@nxp.com>; Peng Fan (OSS)
>> <peng.fan@oss.nxp.com>
>> Cc: Markus.Niebel@ew.tq-group.com; aford173@gmail.com; Aisheng Dong
>> <aisheng.dong@nxp.com>; alexander.stein@ew.tq-group.com;
>> devicetree@vger.kernel.org; festevam@gmail.com; kernel@pengutronix.de;
>> krzysztof.kozlowski+dt@linaro.org; l.stach@pengutronix.de;
>> laurent.pinchart@ideasonboard.com; linux-arm-kernel@lists.infradead.org;
>> dl-linux-imx <linux-imx@nxp.com>; linux-kernel@vger.kernel.org;
>> marex@denx.de; paul.elder@ideasonboard.com; robh+dt@kernel.org;
>> s.hauer@pengutronix.de; shawnguo@kernel.org; gerg@kernel.org
>> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
>>
>> Hi Peng,
>>
>> On 27/3/23 20:01, Peng Fan wrote:
>>>> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
>>>>
>>>> On 22/8/22 14:45, Peng Fan wrote:
>>>>> Add i.MX8MP PGC nodes for vpu, which are used to supply power for
>> VPU.
>>>>>
>>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>>>> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
>>>>> ---
>>>>>    arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27
>>>>> +++++++++++++++++++++++
>>>>>    1 file changed, 27 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>>>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>>>> index 0b165f98a82c..34af983b0210 100644
>>>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>>>> @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
>>>>>                                                   reg =
>>>> <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
>>>>>                                                   clocks = <&clk
>> IMX8MP_CLK_MEDIA_ISP_ROOT>;
>>>>>                                           };
>>>>> +
>>>>> +                                       pgc_vpumix: power-domain@19 {
>>>>> +                                               #power-domain-cells = <0>;
>>>>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPUMIX>;
>>>>> +                                               clocks =<&clk IMX8MP_CLK_VPU_ROOT>;
>>>>> +                                       };
>>>>> +
>>>>> +                                       pgc_vpu_g1: power-domain@20 {
>>>>> +                                               #power-domain-cells = <0>;
>>>>> +                                               power-domains = <&pgc_vpumix>;
>>>>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G1>;
>>>>> +                                               clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>;
>>>>> +                                       };
>>>>> +
>>>>> +                                       pgc_vpu_g2: power-domain@21 {
>>>>> +                                               #power-domain-cells = <0>;
>>>>> +                                               power-domains = <&pgc_vpumix>;
>>>>> +                                               reg = <IMX8MP_POWER_DOMAIN_VPU_G2>;
>>>>> +                                               clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>;
>>>>> +                                       };
>>>>> +
>>>>> +                                       pgc_vpu_vc8000e: power-domain@22 {
>>>>> +                                               #power-domain-cells = <0>;
>>>>> +                                               power-domains = <&pgc_vpumix>;
>>>>> +                                               reg =
>>>> <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
>>>>> +                                               clocks = <&clk
>>>> IMX8MP_CLK_VPU_VC8KE_ROOT>;
>>>>> +                                       };
>>>>>                                   };
>>>>>                           };
>>>>>                   };
>>>>
>>>> This change causes new error messages to come out during boot, for
>>>> example:
>>>>
>>>>       ...
>>>>       imx-pgc imx-pgc-domain.8: failed to command PGC
>>>>       imx-pgc imx-pgc-domain.8: failed to command PGC
>>>>       imx-pgc imx-pgc-domain.8: failed to command PGC
>>>>       30890000.serial: ttymxc1 at MMIO 0x30890000 (irq = 197,
>>>> base_baud =
>>>> 1500000) is a IMX
>>>>       ...
>>>>       hwmon hwmon1: temp1_input not attached to any thermal zone
>>>>       imx-pgc imx-pgc-domain.8: failed to command PGC
>>>>       imx-pgc imx-pgc-domain.8: failed to command PGC
>>>>       imx-pgc imx-pgc-domain.8: failed to command PGC
>>>>       ...
>>>>
>>>> They don't seem to cause any problems on the hardware I am using,
>>>> well, at least not that I have found so far.
>>>>
>>>> This first appeared for me in linux-6.1. But it is the same in todays
>>>> linux 6.3- rc4. Reverting this change (not completely trivial due to
>>>> a couple of commits after it that rely on it) fixes it - no more errors.
>>> [Peng Fan]
>>>
>>> The VPU BLK CTRL seems not enabled.
>>
>> How to enable it?
>> I have the blk-ctrl config options enabled:
>>
>>       #
>>       # i.MX SoC drivers
>>       #
>>       CONFIG_IMX_GPCV2_PM_DOMAINS=y
>>       CONFIG_SOC_IMX8M=y
>>       CONFIG_SOC_IMX9=y
>>       CONFIG_IMX8M_BLK_CTRL=y
>>       CONFIG_IMX9_BLK_CTRL=y
>>       # end of i.MX SoC drivers
>>
>> Running with the full arm64 defconfig and using the imx8mp-evk.dtb still
>> outputs these messages:
>>
>>       [   18.150679] imx-pgc imx-pgc-domain.8: failed to command PGC
>>       [   18.159241] imx-pgc imx-pgc-domain.8: failed to command PGC
>>       [   18.167822] imx-pgc imx-pgc-domain.8: failed to command PGC
>>
>> Or do you mean something more fundamental, like the hardware block not
>> being enabled by boot loader?  (Something to keep in mind is that the
>> platform I am using has no video output, only serial console).
> [Peng Fan]
> 
> The imx8mp vpu blk ctrl already in imx8m-blk-ctrl.c, so it should work.
> Have you enabled imx8mp interconnect driver?
> CONFIG_INTERCONNECT_IMX8MP

Yes, it is enabled:

     CONFIG_INTERCONNECT=y
     CONFIG_INTERCONNECT_IMX=y
     # CONFIG_INTERCONNECT_IMX8MM is not set
     # CONFIG_INTERCONNECT_IMX8MN is not set
     # CONFIG_INTERCONNECT_IMX8MQ is not set
     CONFIG_INTERCONNECT_IMX8MP=y

Regards
Greg