From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB062C7EE29 for ; Wed, 7 Jun 2023 07:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235440AbjFGHSF (ORCPT ); Wed, 7 Jun 2023 03:18:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234478AbjFGHSE (ORCPT ); Wed, 7 Jun 2023 03:18:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC23B1732 for ; Wed, 7 Jun 2023 00:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686122237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z8ZRfR4SbsRmuStbxG9wgKBb6rXoxZXDXcGM0Hiws6Y=; b=Fzzx2ihpM0QudE3n1ophr0R7zRKkDuQ4v1ijQW8XE8hMHzOLFsgBusLtb6R+FigFTbCZmi FW0tklEbXJ5Ff+Xa7I3peqSVVMTM3bx+xTuqQCscJSsYBiGsXE2Bq8N175KB0gOwtpupGt WasGNiqkOMprYpWrfMOE689az0t7yJY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-GAfkb2c6OR2u43mCM_arMw-1; Wed, 07 Jun 2023 03:17:16 -0400 X-MC-Unique: GAfkb2c6OR2u43mCM_arMw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f6fa88a86bso39638985e9.0 for ; Wed, 07 Jun 2023 00:17:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686122235; x=1688714235; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z8ZRfR4SbsRmuStbxG9wgKBb6rXoxZXDXcGM0Hiws6Y=; b=XzASUHBHfK54h3nabhhBXD/d0HGMRUW2gb+WR/Xu0Fv9N4j/WFC/Le7jMeZNDx4ECc y0bQXxVGqEAsnu0zQ2EFy6gcfNOmpupkCz71uUnM8jeJ2s49A6nf2mQIwBtRiBtkidlf c0bKZK/PuonAf3El0kG+O0IFINNTYK9PTSHDfScaKE6NS8YfnTtYwv/L/u4R1lDvedMH QW5V/Bzk66blpWwFPLBqePfYmjL+fqTH4Hj0c6+dZfGFqTqtyduX5xT5KYeqzsrgSUql 5b7MiwB/SL2MHqXKqHqnu/5tzZWrAfLyQA0IW8AZNSnZvPWYEmDQ7qM4jNNAaqvrfx2M gegw== X-Gm-Message-State: AC+VfDyySE/g4S1Nd0WJNxQCDIfEQlq9TXkTPfyehDFy7MiGziVBitBZ niUJeC2pw8g5pyrbc8HL0CTU5HmZxbSICM7Dhd+BMvzymqifTiXFM9+Y1+x4ULDnhw5O6bHQoDC 6Y6BidWad7md4Pbu00lMLDA== X-Received: by 2002:a7b:c7d4:0:b0:3f6:117:6ed7 with SMTP id z20-20020a7bc7d4000000b003f601176ed7mr3883283wmk.35.1686122235551; Wed, 07 Jun 2023 00:17:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7+t4ruO68j5xRFuJyfpOU2/snN7eVdCEGUlFwfIVjPMhRolkXR3gPuON67Rkmj4YBG7RPArw== X-Received: by 2002:a7b:c7d4:0:b0:3f6:117:6ed7 with SMTP id z20-20020a7bc7d4000000b003f601176ed7mr3883273wmk.35.1686122235304; Wed, 07 Jun 2023 00:17:15 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id m9-20020a7bcb89000000b003f72468833esm1113666wmi.26.2023.06.07.00.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 00:17:15 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Maxime Ripard , Conor Dooley , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/5] drm/ssd130x: A few enhancements and cleanups In-Reply-To: <6b0a12bf-a8d4-43df-860c-3aa271cfc624@suse.de> References: <20230605074753.562332-1-javierm@redhat.com> <6b0a12bf-a8d4-43df-860c-3aa271cfc624@suse.de> Date: Wed, 07 Jun 2023 09:17:14 +0200 Message-ID: <87edmnhhc5.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thomas Zimmermann writes: Hello Thomas, > Hi Javierm, > > I've read through the patches and they look correct to me. > > Reviewed-by: Thomas Zimmermann > Thanks a lot for your review! > But I had one question about the page size. You round up to multiples of > page_size in several places. That could lead to an out-of-bounds access. > Do you need to allocate GEM buffers to be multiples of page_size as well? > That's a good point and I would need to have a closer look to the driver to determine if that's needed or not as well. If that's the case though, the issue is already present in the driver. We could fix it as follow-up. > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat