From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<jassisinghbrar@gmail.com>, <mathieu.poirier@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<quic_eberman@quicinc.com>, <quic_mojha@quicinc.com>,
<loic.poulain@linaro.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
<quic_kathirav@quicinc.com>, <quic_anusha@quicinc.com>,
<quic_poovendh@quicinc.com>, <quic_varada@quicinc.com>,
<quic_devipriy@quicinc.com>
Subject: Re: [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for multipd model
Date: Tue, 06 Jun 2023 16:49:40 +0300 [thread overview]
Message-ID: <87edmoitu3.fsf@kernel.org> (raw)
In-Reply-To: <feb0d11d-0930-d0b8-ab6e-cf477bbf114b@quicinc.com> (Manikanta Mylavarapu's message of "Tue, 6 Jun 2023 17:41:00 +0530")
Manikanta Mylavarapu <quic_mmanikan@quicinc.com> writes:
>>>>> +
>>>>> + properties:
>>>>> + compatible:
>>>>> + enum:
>>>>> + - qcom,ipq5018-wcss-ahb-mpd
>>>>> + - qcom,ipq9574-wcss-ahb-mpd
>>>>> + - qcom,ipq5018-wcss-pcie-mpd
>>>>
>>>> Keep rather alphabetical order (so both 5018 together).
>>>>
>>>> I also do not understand these at all. Why adding bus type to
>>>> compatible? This rarely is allowed (unless it is PCIe controller within
>>>> soc).
>>>>
>>> IPQ5018 SOC has in-built PCIE controller. Here QDSP6 will bring up
>>> external(PCIE) and internal (AHB) wifi radio's. To separate AHB, PCIE
>>> radio's properties, i have added bus type to compatible.
>>
>> It's the same device - WCSS - right? We do not create multiple nodes and
>> compatibles for the same devices. Bus suffixes are almost never parts of
>> compatibles.
>
>
> No it's not the same device. WCSS on inside IPQ5018 and WCSS attached
> via pcie to IPQ5018. Here QDSP6 managing both WCSS's.
>
> So for better clarity i will use attached SOC ID in compatible.
> Below are the new compatible's.
>
> - qcom,ipq5018-wcss-mpd //IPQ5018 internal radio
> - qcom,ipq9574-wcss-mpd //IPQ9574 internal radio
> - qcom,qcn6122-wcss-mpd //IPQ5018 attached radio
What mandates that there's just one QCN6122 device attached to PCI?
Assuming fixed PCI configurations like that makes me worried.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-06-06 13:49 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 22:28 [PATCH V2 00/13] Add multipd remoteproc support Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for multipd model Manikanta Mylavarapu
2023-05-30 10:46 ` Krzysztof Kozlowski
2023-06-05 5:58 ` Manikanta Mylavarapu
2023-05-30 10:58 ` Krzysztof Kozlowski
2023-06-05 8:03 ` Manikanta Mylavarapu
2023-06-05 12:02 ` Manikanta Mylavarapu
2023-06-06 6:14 ` Krzysztof Kozlowski
2023-06-06 12:11 ` Manikanta Mylavarapu
2023-06-06 13:49 ` Kalle Valo [this message]
2023-06-07 8:10 ` Manikanta Mylavarapu
2023-06-07 8:27 ` Krzysztof Kozlowski
2023-06-14 11:43 ` Manikanta Mylavarapu
2023-06-14 12:49 ` Manikanta Mylavarapu
2023-06-14 13:59 ` Krzysztof Kozlowski
2023-06-21 11:39 ` Manikanta Mylavarapu
2023-06-24 7:19 ` Krzysztof Kozlowski
2023-06-30 7:12 ` Manikanta Mylavarapu
2023-07-01 10:51 ` Krzysztof Kozlowski
2023-07-18 12:10 ` Manikanta Mylavarapu
2023-06-08 12:59 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 02/13] dt-bindings: mailbox: qcom: Add IPQ5018 APCS compatible Manikanta Mylavarapu
2023-05-30 10:59 ` Krzysztof Kozlowski
2023-05-21 22:28 ` [PATCH V2 03/13] dt-bindings: arm: qcom: Document the Qualcomm rdp432-c1 board Manikanta Mylavarapu
2023-05-30 10:59 ` Krzysztof Kozlowski
2023-06-05 5:29 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 04/13] dt-bindings: clock: qcom: gcc-ipq5018: remove q6 clocks macros Manikanta Mylavarapu
2023-05-30 11:01 ` Krzysztof Kozlowski
2023-06-01 18:55 ` Robert Marko
2023-06-05 6:22 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 05/13] dt-bindings: clock: qcom: gcc-ipq9574: remove q6 bring up clock macros Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 06/13] clk: qcom: ipq5018: remove q6 bring up clocks Manikanta Mylavarapu
2023-05-30 11:03 ` Krzysztof Kozlowski
2023-06-06 12:17 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 07/13] clk: qcom: ipq9574: " Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 08/13] firmware: qcom_scm: ipq5018: Add WCSS AHB pd support Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 09/13] remoteproc: qcom: q6v5: Add multipd interrupts support Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 10/13] remoteproc: qcom: Add Hexagon based multipd rproc driver Manikanta Mylavarapu
2023-06-24 7:28 ` Krzysztof Kozlowski
[not found] ` <54f06704-a849-7049-5956-31cb4765a1eb@quicinc.com>
2023-06-30 10:29 ` Manikanta Mylavarapu
2023-07-01 10:55 ` Krzysztof Kozlowski
2023-07-18 12:10 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 11/13] arm64: dtsi: qcom: ipq5018: enable nodes required for multipd Manikanta Mylavarapu
2023-05-30 11:05 ` Krzysztof Kozlowski
2023-06-05 5:35 ` Manikanta Mylavarapu
2023-06-05 5:38 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 12/13] arm64: dts: qcom: ipq5018: Add RDP432-c1 board support Manikanta Mylavarapu
2023-05-30 11:06 ` Krzysztof Kozlowski
2023-06-08 12:33 ` Manikanta Mylavarapu
2023-05-21 22:28 ` [PATCH V2 13/13] arm64: dtsi: qcom: ipq9574: Add nodes to bring up multipd Manikanta Mylavarapu
2023-06-24 7:01 ` Krzysztof Kozlowski
[not found] ` <15bdbd23-9066-ee20-1e29-1d086340c133@quicinc.com>
2023-06-30 7:11 ` Manikanta Mylavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edmoitu3.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).