From: Marek Vasut <marex@denx.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-leds@vger.kernel.org
Cc: Isai Gaspar <isaiezequiel.gaspar@nxp.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] leds: pca995x: Add support for PCA995X chips
Date: Wed, 5 Jul 2023 19:26:02 +0200 [thread overview]
Message-ID: <87ee247f-c39c-aeb6-fa3a-e3c933e5c117@denx.de> (raw)
In-Reply-To: <596e25d8-2e8b-8d6b-b6b8-9b56b58602bd@linaro.org>
On 7/5/23 09:11, Krzysztof Kozlowski wrote:
> On 05/07/2023 02:04, Marek Vasut wrote:
>> From: Isai Gaspar <isaiezequiel.gaspar@nxp.com>
>>
>> The PCA995x chips are I2C controlled LED drivers. Each chip has
>> up to 16 outputs, each one with an individual 8-bit resolution
>> PWM for brightness control.
>>
>> Signed-off-by: Isai Gaspar <isaiezequiel.gaspar@nxp.com>
>> Signed-off-by: Marek Vasut <marex@denx.de> # Basically rewrite the driver
>
> ...
>
>> +
>> +static struct i2c_driver pca995x_driver = {
>> + .driver = {
>> + .name = "leds-pca995x",
>> + .owner = THIS_MODULE,
>> + .of_match_table = of_match_ptr(pca995x_of_match),
>
> Drop of_match_ptr(), it will cause warnings and is not really helpful.
Will do , thanks.
I'll wait for the bindings review before sending V3.
next prev parent reply other threads:[~2023-07-05 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 0:04 [PATCH v2 1/2] dt-bindings: leds: pca995x: Add binding document for PCA995X chips Marek Vasut
2023-07-05 0:04 ` [PATCH v2 2/2] leds: pca995x: Add support " Marek Vasut
2023-07-05 4:29 ` kernel test robot
2023-07-05 5:41 ` kernel test robot
2023-07-05 7:11 ` Krzysztof Kozlowski
2023-07-05 17:26 ` Marek Vasut [this message]
2023-07-05 19:08 ` [PATCH v2 1/2] dt-bindings: leds: pca995x: Add binding document " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee247f-c39c-aeb6-fa3a-e3c933e5c117@denx.de \
--to=marex@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=isaiezequiel.gaspar@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).