From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v1 2/3] spi: pxa2xx: Introduce dma-burst-sz property support Date: Thu, 07 Mar 2019 20:24:24 +0100 Message-ID: <87ef7i5vyv.fsf@belgarion.home> References: <20190226092441.49198-1-andriy.shevchenko@linux.intel.com> <20190226092441.49198-2-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190226092441.49198-2-andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Tue, 26 Feb 2019 12:24:40 +0300") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko Cc: Mark Rutland , devicetree@vger.kernel.org, Mark Brown , Haojian Zhuang , linux-spi@vger.kernel.org, Rob Herring , Jarkko Nikula , linux-arm-kernel@lists.infradead.org, Daniel Mack List-Id: devicetree@vger.kernel.org Andy Shevchenko writes: > @@ -1512,6 +1513,7 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > const struct acpi_device_id *adev_id = NULL; > const struct pci_device_id *pcidev_id = NULL; > const struct of_device_id *of_id = NULL; > + struct device *dev = &pdev->dev; > enum pxa_ssp_type type; > > adev = ACPI_COMPANION(&pdev->dev); > @@ -1566,9 +1568,10 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev) > ssp->pdev = pdev; > ssp->port_id = pxa2xx_spi_get_port_id(adev); > > - pdata->is_slave = of_property_read_bool(pdev->dev.of_node, "spi-slave"); > + pdata->is_slave = device_property_read_bool(dev, "spi-slave"); Isn't this an unrelated change to the introduction of dma-burst-sz ? Other than this : Reviewed-by: Robert Jarzmik Cheers. -- Robert