From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2][resend] OF: add for_each_port_of_node()
Date: Wed, 28 Nov 2018 06:54:49 +0000 [thread overview]
Message-ID: <87efb51z0c.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAL_JsqJmYcd=SVjivse93_GyYvz9MnbOzgjkf_PSxqRCZtUAqg@mail.gmail.com>
Hi Rob again
> > + do {
> > + port = of_get_next_child(parent, port);
> > + if (!port)
> > + return NULL;
> > + } while (of_node_cmp(port->name, "port"));
>
> Use of_node_name_eq()
I tried this, but unfortunately it seems of_node_name_eq()
is not good match to this purpose.
Because it try to check with "port@n".
# I noticed that I can cleanup this patch to more simpler.
# I want to send v2 patch if this patch is not rejected
# Please let me know
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2018-11-28 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 2:33 [PATCH 0/2][resend] OF: add functions for port Kuninori Morimoto
2018-11-28 2:34 ` [PATCH 1/2][resend] OF: add of_graph_get_port() Kuninori Morimoto
2018-11-28 2:34 ` [PATCH 2/2][resend] OF: add for_each_port_of_node() Kuninori Morimoto
2018-11-28 4:37 ` Rob Herring
2018-11-28 4:46 ` Kuninori Morimoto
2018-11-28 15:46 ` Rob Herring
2018-11-30 0:47 ` Kuninori Morimoto
2018-11-30 1:55 ` Kuninori Morimoto
2018-11-28 6:54 ` Kuninori Morimoto [this message]
2018-11-28 4:29 ` [PATCH 0/2][resend] OF: add functions for port Rob Herring
2018-11-28 4:36 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efb51z0c.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).