From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Linux-ALSA <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Simon <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Laurent
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Guennadi <g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linux-DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux-Kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 10/23] ASoC: simple-card-utils: adjust for graph on asoc_simple_card_parse_card_name
Date: Mon, 17 Oct 2016 08:34:57 +0000 [thread overview]
Message-ID: <87eg3f4c20.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87shrv4c8x.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
It is assuming that the card related information is located on
"card" node, but graph case doesn't have it.
This patch adds node parameter to adjust for graph support
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
include/sound/simple_card_utils.h | 1 +
sound/soc/generic/simple-card-utils.c | 3 ++-
sound/soc/generic/simple-card.c | 2 +-
sound/soc/generic/simple-scu-card.c | 2 +-
4 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
index fd641255..09750ac 100644
--- a/include/sound/simple_card_utils.h
+++ b/include/sound/simple_card_utils.h
@@ -32,6 +32,7 @@ int asoc_simple_card_set_dailink_name(struct device *dev,
struct snd_soc_dai_link *dai_link,
const char *fmt, ...);
int asoc_simple_card_parse_card_name(struct snd_soc_card *card,
+ struct device_node *node,
char *prefix);
#define asoc_simple_card_parse_clk_cpu(node, dai_link, simple_dai) \
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index e5b80f5..6bc1510 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -79,6 +79,7 @@ int asoc_simple_card_set_dailink_name(struct device *dev,
EXPORT_SYMBOL_GPL(asoc_simple_card_set_dailink_name);
int asoc_simple_card_parse_card_name(struct snd_soc_card *card,
+ struct device_node *node,
char *prefix)
{
char prop[128];
@@ -87,7 +88,7 @@ int asoc_simple_card_parse_card_name(struct snd_soc_card *card,
snprintf(prop, sizeof(prop), "%sname", prefix);
/* Parse the card name from DT */
- ret = snd_soc_of_parse_card_name(card, prop);
+ ret = snd_soc_of_parse_card_name_from_node(card, node, prop);
if (ret < 0)
return ret;
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index f608f8d2..342ff53 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -401,7 +401,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,
goto card_parse_end;
}
- ret = asoc_simple_card_parse_card_name(&priv->snd_card, PREFIX);
+ ret = asoc_simple_card_parse_card_name(&priv->snd_card, NULL, PREFIX);
if (ret < 0)
goto card_parse_end;
diff --git a/sound/soc/generic/simple-scu-card.c b/sound/soc/generic/simple-scu-card.c
index 348e9a7..a8164a2 100644
--- a/sound/soc/generic/simple-scu-card.c
+++ b/sound/soc/generic/simple-scu-card.c
@@ -239,7 +239,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,
i++;
}
- ret = asoc_simple_card_parse_card_name(&priv->snd_card, PREFIX);
+ ret = asoc_simple_card_parse_card_name(&priv->snd_card, NULL, PREFIX);
if (ret < 0)
return ret;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-17 8:34 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 8:30 [PATCH 0/23] ASoC: add OF graph base simple-card Kuninori Morimoto
2016-10-17 8:32 ` [PATCH 01/23] ASoC: simple-scu-card: code sync: follow to simple family style Kuninori Morimoto
[not found] ` <87r37f4c6v.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-28 18:49 ` Applied "ASoC: simple-scu-card: code sync: follow to simple family style" to the asoc tree Mark Brown
2016-10-17 8:32 ` [PATCH 02/23] ASoC: simple-scu-card: code sync: rename asoc_simple_card_priv Kuninori Morimoto
2016-10-28 18:48 ` Applied "ASoC: simple-scu-card: code sync: rename asoc_simple_card_priv" to the asoc tree Mark Brown
2016-10-17 8:33 ` [PATCH 06/23] ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_routing Kuninori Morimoto
2016-11-11 15:29 ` Applied "ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_routing" to the asoc tree Mark Brown
2016-10-17 8:34 ` [PATCH 09/23] ASoC: simple-card-utils: remove unnecessary cpu/codec pointer check Kuninori Morimoto
[not found] ` <87funv4c2j.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-28 18:48 ` Applied "ASoC: simple-card-utils: remove unnecessary cpu/codec pointer check" to the asoc tree Mark Brown
2016-10-17 8:35 ` [PATCH 11/23] Documentation: of: add type property Kuninori Morimoto
[not found] ` <87shrv4c8x.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-17 8:32 ` [PATCH 03/23] ASoC: simple-scu-card: code sync: tidyup props/link naming Kuninori Morimoto
[not found] ` <87oa2j4c5j.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-28 18:48 ` Applied "ASoC: simple-scu-card: code sync: tidyup props/link naming" to the asoc tree Mark Brown
2016-10-17 8:33 ` [PATCH 04/23] ASoC: soc-core: adjust for graph on snd_soc_of_parse_card_name Kuninori Morimoto
[not found] ` <87mvi34c51.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-11-11 15:28 ` Applied "ASoC: soc-core: adjust for graph on snd_soc_of_parse_card_name" to the asoc tree Mark Brown
2016-10-17 8:33 ` [PATCH 05/23] ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_simple_widgets Kuninori Morimoto
2016-11-11 15:28 ` Applied "ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_simple_widgets" to the asoc tree Mark Brown
2016-10-17 8:34 ` [PATCH 07/23] ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_prefix Kuninori Morimoto
[not found] ` <87insr4c3i.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-11-11 15:28 ` Applied "ASoC: soc-core: adjust for graph on snd_soc_of_parse_audio_prefix" to the asoc tree Mark Brown
2016-10-17 8:34 ` [PATCH 08/23] ASoC: soc-core: snd_soc_get_dai_name() become non static Kuninori Morimoto
[not found] ` <87h98b4c30.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-18 7:27 ` [alsa-devel] " Jean-Francois Moine
2016-11-11 15:28 ` Applied "ASoC: soc-core: snd_soc_get_dai_name() become non static" to the asoc tree Mark Brown
2016-10-17 8:34 ` Kuninori Morimoto [this message]
2016-10-17 8:35 ` [PATCH 12/23] of_graph: add of_graph_get_remote_endpoint() Kuninori Morimoto
2016-10-17 8:36 ` [PATCH 13/23] of_graph: add of_graph_port_type_is() Kuninori Morimoto
2016-10-17 8:36 ` [PATCH 15/23] of_graph: add of_graph_get_top_port() Kuninori Morimoto
2016-10-17 8:37 ` [PATCH 17/23] of_graph: add of_graph_get_endpoint_count() Kuninori Morimoto
2016-10-17 8:38 ` [PATCH 19/23] ASoC: simple-card-utils: add asoc_simple_card_try_to_probe_graph_card() Kuninori Morimoto
2016-10-17 8:38 ` [PATCH 21/23] ASoC: add simple-graph-card support Kuninori Morimoto
2016-10-17 8:36 ` [PATCH 14/23] of_graph: add of_graph_get_port_parent() Kuninori Morimoto
2016-10-17 8:37 ` [PATCH 16/23] of_graph: add for_each_of_port() / for_each_of_endpoint_in_port() Kuninori Morimoto
2016-10-17 8:37 ` [PATCH 18/23] ASoC: simple-card-utils: add asoc_simple_card_parse_graph_dai() Kuninori Morimoto
2016-10-17 8:38 ` [PATCH 20/23] ASoC: add simple-graph-card document Kuninori Morimoto
[not found] ` <87zim32xbo.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-18 15:53 ` Rob Herring
[not found] ` <CAL_JsqJY-KtoR7C-vKBP1p3XRKkiVHBM9mzCdV3_P2DSp-xw9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 1:36 ` Kuninori Morimoto
[not found] ` <871szd3z8l.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-10-19 2:39 ` Rob Herring
[not found] ` <CAL_Jsq+F6yKzbZu9BA9QTmiJne4OphZB12_AvLN3mC7vm__2+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-19 6:13 ` Kuninori Morimoto
2016-10-21 5:45 ` Kuninori Morimoto
2016-10-17 8:39 ` [PATCH 22/23] ASoC: add simple-graph-scu-card document Kuninori Morimoto
2016-10-17 8:39 ` [PATCH 23/23] ASoC: add simple-graph-scu-card support Kuninori Morimoto
2016-10-18 7:10 ` [alsa-devel] [PATCH 0/23] ASoC: add OF graph base simple-card Jean-Francois Moine
2016-10-18 8:44 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg3f4c20.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx-zm6kxycvzfbbdgjk7y7tuq@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).