From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string Date: Tue, 8 Dec 2015 06:05:51 +0000 Message-ID: <87egex5vfl.wl%kuninori.morimoto.gx@renesas.com> References: <1449553911-21412-1-git-send-email-horms+renesas@verge.net.au> <1449553911-21412-2-git-send-email-horms+renesas@verge.net.au> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Horman Cc: Greg Kroah-Hartman , Yoshihiro Shimoda , Magnus Damm , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Simon > Add fallback compatibility string. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman > --- (snip) > + { > + .compatible = "renesas,usbhs", > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > + }, > { }, > }; I think this is too much. This driver is used not only from R-Car Gen2. It will work as normal mode if .data was 0. see usbhs_parse_dt() -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html