From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver Date: Mon, 3 Jun 2019 10:52:47 -0500 Message-ID: <87f98f81-8f77-3bc5-374c-f498e07cb1bd@linaro.org> References: <20190531035348.7194-1-elder@linaro.org> <065c95a8-7b17-495d-f225-36c46faccdd7@linaro.org> <3b1e12b145a273dd3ded2864d976bdc5fa90e68a.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3b1e12b145a273dd3ded2864d976bdc5fa90e68a.camel@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Dan Williams , Arnd Bergmann Cc: David Miller , Bjorn Andersson , Ilias Apalodimas , evgreen@chromium.org, Ben Chan , Eric Caruso , cpratapa@codeaurora.org, syadagir@codeaurora.org, Subash Abhinov Kasiviswanathan , abhishek.esse@gmail.com, Networking , DTML , Linux Kernel Mailing List , linux-soc@vger.kernel.org, Linux ARM , linux-arm-msm@vger.kernel.org List-Id: devicetree@vger.kernel.org On 6/3/19 9:54 AM, Dan Williams wrote: >> To be perfectly honest, at first I thought having IPA use rmnet >> was a cargo cult thing like Dan suggested, because I didn't see > To be clear I only meant cargo-culting the naming, not any > functionality. Clearly IPA/rmnet/QMAP are pretty intimately connected > at this point. But this goes back to whether IPA needs a netdev itself > or whether you need an rmnet device created on top. If the former then > I'd say no cargo-culting, if the later then it's a moot point because > the device name will be rmnet%d anyway. OK I thought you weren't sure why rmnet was a layer at all. As I said, I didn't have a very good understanding of why it was even needed when I first started working on this. I can't (or won't) comment right now on whether IPA needs its own netdev for rmnet to use. The IPA endpoints used for the modem network interfaces are enabled when the netdev is opened and disabled when closed. Outside of that, TX and RX are pretty much immediately passed through to the layer below or above. IPA currently has no other net device operations. -Alex