From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0EAB2773DE; Mon, 26 Jan 2026 15:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769442730; cv=none; b=tkMrbwu4mw9JGCAvNZ8W+Sg2+UYrGU0rLjMhgyJlHSADmL7DrkVBVMOO5hI1nnd5fO9POWOdB2sutyMp8sEVgdyifTQK2WxVqRcYne92JoItDm+3+flZJFF5znnh2Inq78Xy1p/+fsimwLA8E9NAWanZGoB50/ejdIUp0e6u518= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769442730; c=relaxed/simple; bh=+ADv4pELrdIIcbbNOkUvc+VYYWavY8uNP77ALYYtwqo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=F6pvVHj51oAv6bzvRSqYHekGQulHNJG387NGctG116pZVrAHuohYXsa1I6hfakEoLIopNIEl/7FzXCBDo379Zb1027Xerf0ZH+8i5zaJGk0IwsJ90o2UQI5kBgxSNX9j6KPay+nDVzdznqkIY61k6LMSnDTp952OrKVeP7nOhio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YQbLdhqD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YQbLdhqD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AF8CC116C6; Mon, 26 Jan 2026 15:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769442730; bh=+ADv4pELrdIIcbbNOkUvc+VYYWavY8uNP77ALYYtwqo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YQbLdhqDEzvnIE38o1MR+mhM1BOL1xnJjw4XhU9J9Uk4Ie2qP1bw99BXPjRhUQAid zha/AWEQrJ/0QgJZQ2CWYMA5aG5BdM60OP3fdI+7vdGaKDq/OF9lFv3fieLygk4/V4 ryMdCYbxWInKHNSn+egpVjM9H7Nq5HUIGgmVzByHBG6u9iFYqlmEZ9GPZNlMcnpybI yLLV/kxLKf0CxTP14fhxM5vCjmLTTCBk7a3WwqKFlpo9l2arqd/exN+mcFhC93hNaX uNq7Vhb/mM/gfAfPpD6/Tr9sehWzqrJo0t9OcfhkdsXwdjVoZwuvCA8TEazfNwkUXP R83GLAvc4HmbA== From: Thomas Gleixner To: Janne Grunau , Sven Peter , Neal Gompa , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Janne Grunau Subject: Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3" In-Reply-To: <20260125-irq-apple-aic3-v1-2-a2afe66a6ab9@jannau.net> References: <20260125-irq-apple-aic3-v1-0-a2afe66a6ab9@jannau.net> <20260125-irq-apple-aic3-v1-2-a2afe66a6ab9@jannau.net> Date: Mon, 26 Jan 2026 16:52:06 +0100 Message-ID: <87fr7scqxl.ffs@tglx> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sun, Jan 25 2026 at 12:08, Janne Grunau wrote: > +/* > + * AIC v3 registers (MMIO) > + */ > + Pointless newline and please make this a /* Oneline comment */ > +#define AIC3_IRQ_CFG 0x10000 > + > } > + case 3: > case 2: { 1 3 2 is a weird count order... Thanks, tglx