From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE645C433B4 for ; Mon, 17 May 2021 09:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8979B611ED for ; Mon, 17 May 2021 09:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235940AbhEQJae convert rfc822-to-8bit (ORCPT ); Mon, 17 May 2021 05:30:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:43952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235923AbhEQJae (ORCPT ); Mon, 17 May 2021 05:30:34 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7532D601FC; Mon, 17 May 2021 09:29:18 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1liZYq-001lgQ-90; Mon, 17 May 2021 10:29:16 +0100 Date: Mon, 17 May 2021 10:29:15 +0100 Message-ID: <87fsylvhck.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Heiko Stuebner , devicetree@vger.kernel.org Subject: Re: [PATCH RFC 5/9] arm64: dts: rockchip: rk1808k-toybrick-m0: Suppress vGIC interrupt In-Reply-To: <20210516230551.12469-6-afaerber@suse.de> References: <20210516230551.12469-1-afaerber@suse.de> <20210516230551.12469-6-afaerber@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: afaerber@suse.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 17 May 2021 00:05:47 +0100, Andreas Färber wrote: > > Avoid the kernel getting stuck after: > > [ 1.175956] kvm [1]: IPA Size Limit: 40 bits > [ 1.177164] kvm [1]: vgic-v2@ff320000 > [ 1.177545] kvm [1]: GIC system register CPU interface enabled > > or when dropping GICV reg entry: > > [ 1.176001] kvm [1]: IPA Size Limit: 40 bits > [ 1.177191] kvm [1]: GICv3: no GICV resource entry > [ 1.177664] kvm [1]: disabling GICv2 emulation > [ 1.178115] kvm [1]: GIC system register CPU interface enabled > > Signed-off-by: Andreas Färber > --- > arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts b/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts > index 2f8075d2391c..15293a8576c6 100644 > --- a/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts > +++ b/arch/arm64/boot/dts/rockchip/rk1808k-toybrick-m0.dts > @@ -48,6 +48,10 @@ &cpu1 { > cpu-supply = <&vdd_cpu>; > }; > > +&gic { > + /delete-property/ interrupts; > +}; > + > &uart2 { > status = "okay"; > clocks = <&xin24m>; As I said in my reply to the cover letter, this is not an acceptable outcome. Please add some debug to kvm_vgic_hyp_init() to understand where this is hanging and why. M. -- Without deviation from the norm, progress is not possible.