From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5247AC88CB2 for ; Mon, 12 Jun 2023 18:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237548AbjFLSb4 (ORCPT ); Mon, 12 Jun 2023 14:31:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238031AbjFLSbY (ORCPT ); Mon, 12 Jun 2023 14:31:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03820A7 for ; Mon, 12 Jun 2023 11:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686594625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ytk4CBUD5ymgdb/TV8v27oVrKqeWA1Ac0y1484kVuMA=; b=Ns2DTuh91AG7n9kAg7VJ675+fJ3EqI7ZPZhpG8UG1tmhhebeuzRJC4oqTHiGQKizRk6fly A1L2Zdyk5Df+V6BBVreZlr9dWUuSchui9W2TRgWSVZ9ec/1wWPpbkDptOZCTI71a4RASsJ ABdpwltxmK+D6g7rMXsCCVbCto6mMY8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-kE_Nl2iHOqWqY9tdL5ygWQ-1; Mon, 12 Jun 2023 14:30:23 -0400 X-MC-Unique: kE_Nl2iHOqWqY9tdL5ygWQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f7f4a7b289so88222995e9.2 for ; Mon, 12 Jun 2023 11:30:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686594622; x=1689186622; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ytk4CBUD5ymgdb/TV8v27oVrKqeWA1Ac0y1484kVuMA=; b=LML+aRYzzJLrClwWdLftFbluUXYMknOPl8hXzR3GTW7G6pU0HAMU3cnZlE3sRb9k44 GYUeoipwp1lGRogJ9MsPq1e5I98TPJjWdTELpWLw0qYeiWGdYQqU3gwO0y+gt/P1Om3K AnzDUedLBMVOzebb6unP0g95qUMtKpEUHUwkfRnZEKRvbWIzRzkVqjlhajJ5WEKFilVu vDIXaaBqJ5j2Zoy/+fwRFBS1rY672V29TP0kgRPDw3nk/cXHapHSIFIYpjvw92CEb614 n+h5RMavfp36EBJ6SSlAzKCGEP8se74cc6VIA9AE3AkHafq+q7y8Mxj17aRKkP4dOi7T q9dQ== X-Gm-Message-State: AC+VfDwtOl8Ye/5tmbh0j44+JzWkgVVSCvU10Dfq25VPPR12GrsJW8dU 0tqE5zad7bBfv2KBI4+x21uZozGMSvrP+7R4zdH3hmMi6EhRQebuH2BGbZv+JppFq8GZqd1h2fT DjGL7ovRPQta/QaJixvYWqg== X-Received: by 2002:a05:600c:2297:b0:3f7:f544:4993 with SMTP id 23-20020a05600c229700b003f7f5444993mr8211861wmf.20.1686594622650; Mon, 12 Jun 2023 11:30:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6f87goxu4tLEIjzoynyJtL5A/keJi5mHvAB0RC30rg0lgcZJDIaJ1gEOYrsjRA3uu+QEeiPA== X-Received: by 2002:a05:600c:2297:b0:3f7:f544:4993 with SMTP id 23-20020a05600c229700b003f7f5444993mr8211850wmf.20.1686594622317; Mon, 12 Jun 2023 11:30:22 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id r15-20020adfda4f000000b002fe96f0b3acsm13271835wrl.63.2023.06.12.11.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:30:21 -0700 (PDT) From: Javier Martinez Canillas To: Conor Dooley , Thomas Zimmermann Cc: devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Maxime Ripard , Rob Herring , Geert Uytterhoeven , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values In-Reply-To: <20230612-parade-sauciness-16225ce0a643@spud> References: <20230609170941.1150941-1-javierm@redhat.com> <20230609170941.1150941-3-javierm@redhat.com> <20230610-opposite-quality-81d4a1561c88@spud> <87r0qj19zs.fsf@minerva.mail-host-address-is-not-set> <20230610-unused-engaged-c1f4119cff08@spud> <87jzwa29ff.fsf@minerva.mail-host-address-is-not-set> <20230612-parade-sauciness-16225ce0a643@spud> Date: Mon, 12 Jun 2023 20:30:21 +0200 Message-ID: <87h6rc354y.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Conor Dooley writes: > On Mon, Jun 12, 2023 at 09:47:12AM +0200, Thomas Zimmermann wrote: >> Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas: > >> > But I will be OK to drop the "solomon,ssd130?fb-i2c" compatible strings >> > from the DRM driver and only match against the new "solomon,ssd130?-i2c" >> > compatible strings. And add a different DT binding schema for the ssd130x >> > driver, if that would mean being able to fix things like the one mentioned >> > in this patch. > > If there are different compatibles, then it can always be sorted out > later iff it turns out to be a problem, since new devicetrees should not > be using the deprecated compatibles anyway. I didn't realise that those > deprecated compatibles existed, thanks for your patience. > No worries, thanks for raising this question. >> > In my opinion, trying to always make the drivers backward compatible with >> > old DTBs only makes the drivers code more complicated for unclear benefit. >> > >> > Usually this just ends being code that is neither used nor tested. Because >> > in practice most people update the DTBs and kernels, instead of trying to >> > make the DTB a stable ABI like firmware. >> > >> >> From my understanding, fixing the resolution is the correct thing to do >> here. Userspace needs to be able to handle these differences. > > Fixing meaning correcting, or fixing meaning using a fixed resolution? > Not clear to me what you mean, sorry. > Fixing meaning using as a default the correct maximum resolution for each OLED controller, rather than an arbitrary 96x16 resolution that was added just to be compatible with the panel that was tested the original driver. But after talking with Thomas and Maxime about this issue, I realized that it won't even cause an issue for theoretical users that may be relying on the previous default. Changing the default resolution to something smaller could cause an issue since a user expecting a bigger default would get their display output cut but changing to something bigger just means user-space being able to write more pixels than those that will be displayed. Because there isn't really a "resolution" configured in the chip, but just how many pixels a particular controller can drive. The new default is the maximum that each controller supports according to their documentation. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat