devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Jarrah <kernel@undef.tools>, "Heiko Stübner" <heiko@sntech.de>,
	linux-kernel@vger.kernel.org
Cc: Peter Robinson <pbrobinson@gmail.com>,
	Caleb Connolly <kc@postmarketos.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Martijn Braam <martijn@brixit.nl>, Ondrej Jirman <megi@xff.cz>,
	Rob Herring <robh+dt@kernel.org>,
	Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB
Date: Tue, 04 Apr 2023 10:24:00 +0200	[thread overview]
Message-ID: <87h6twdpi7.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <d7efebcc-5b5b-185e-bec8-b6b9d5d27d93@undef.tools>

Jarrah <kernel@undef.tools> writes:

> Hi,
>
> On 4/4/23 17:51, Heiko Stübner wrote:
>> The interesting question is always if this will break someone else's setup.
>> I've never really understood the strange setting of 1.5MBps, but on the
>> other hand it _is_ a reality on most boards.
>>
>> Personally I don't care that much either way, but would like a comment
>> from the other people working on that device - if possible.
>
>
> I don't have a strong opinion either way, but I would note that 
> Tow-Boot[0] which later models of this device ship with uses 115200, 
> meaning that this would put the device out of sync with the default 
> u-boot implementation from the factory.
>

Probably we can't change then because it would break the setup of people
using Tow-Boot as a bootloader.

> At least for me it's been convenient to have both the PP and PPP use the 
> same settings while debugging.
>

Agreed, all my other boards use 115200 as well, the only exceptions are
the Rockpro64 and PinePhone Pro for me.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


  parent reply	other threads:[~2023-04-04  8:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 17:59 [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB Javier Martinez Canillas
2023-04-04  7:51 ` Heiko Stübner
2023-04-04  8:08   ` Javier Martinez Canillas
2023-04-04  8:13   ` Jarrah
2023-04-04  8:18     ` Peter Robinson
2023-04-04  8:25       ` Javier Martinez Canillas
2023-04-04  8:24     ` Javier Martinez Canillas [this message]
2023-04-04  8:38       ` Peter Robinson
2023-04-04  8:46         ` Javier Martinez Canillas
2023-04-04 11:31   ` Martijn Braam
2023-04-04 11:42     ` Javier Martinez Canillas
2023-04-04 12:02       ` Ondřej Jirman
2023-04-04 12:36   ` Ondřej Jirman
2023-04-04 14:04     ` Javier Martinez Canillas
2023-04-04 15:40       ` Ondřej Jirman
2023-04-04 12:52   ` Peter Geis
2023-04-04 16:55     ` Heiko Stübner
2023-04-18 12:11       ` Javier Martinez Canillas
2023-04-18 14:26         ` Heiko Stübner
2023-07-21 23:06           ` Javier Martinez Canillas
2023-07-28 18:59             ` Heiko Stuebner
2023-07-28 19:55               ` Maya Matuszczyk
2023-07-28 23:05                 ` Javier Martinez Canillas
2023-07-28 20:10               ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6twdpi7.fsf@minerva.mail-host-address-is-not-set \
    --to=javierm@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kc@postmarketos.org \
    --cc=kernel@undef.tools \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=pbrobinson@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).