From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16CFC433EF for ; Fri, 12 Nov 2021 15:27:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95F4861039 for ; Fri, 12 Nov 2021 15:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbhKLP3w (ORCPT ); Fri, 12 Nov 2021 10:29:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:35978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbhKLP3v (ORCPT ); Fri, 12 Nov 2021 10:29:51 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 367A660F4F; Fri, 12 Nov 2021 15:27:01 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mlYSB-00530W-25; Fri, 12 Nov 2021 15:26:59 +0000 Date: Fri, 12 Nov 2021 15:26:58 +0000 Message-ID: <87h7ch8ke5.wl-maz@kernel.org> From: Marc Zyngier To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, Christian Zigotzky , Bjorn Helgaas Subject: Re: [PATCH] of/irq: Don't ignore interrupt-controller when interrupt-map failed In-Reply-To: References: <20211112143644.434995-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robh@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, chzigotzky@xenosoft.de, bhelgaas@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 12 Nov 2021 14:57:13 +0000, Rob Herring wrote: > > On Fri, Nov 12, 2021 at 8:37 AM Marc Zyngier wrote: > > > > @@ -244,8 +245,14 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) > > > > pr_debug(" -> imaplen=%d\n", imaplen); > > } > > - if (!match) > > + if (!match) { > > + if (intc) { > > + pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar); > > Let's make this a WARN for !IS_ENABLED(CONFIG_PASEMI). (whatever the > right kconfig symbol is). I've folded this in. M. diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 508fb1717de3..b10f015b2e37 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -247,7 +247,13 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq) } if (!match) { if (intc) { - pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar); + /* + * The PASEMI Nemo is a known offender, so + * let's only warn for anyone else. + */ + WARN(!IS_ENABLED(CONFIG_PPC_PASEMI), + "%pOF interrupt-map failed, using interrupt-controller\n", + ipar); return 0; } -- Without deviation from the norm, progress is not possible.