From: Jani Nikula <jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Noralf Trønnes" <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support
Date: Mon, 06 Feb 2017 13:25:17 +0200 [thread overview]
Message-ID: <87h947blya.fsf@intel.com> (raw)
In-Reply-To: <20170131160319.9695-4-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
On Tue, 31 Jan 2017, Noralf Trønnes <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org> wrote:
> +static bool mipi_dbi_command_is_read(struct mipi_dbi *mipi, u8 cmd)
Okay this is one giant bikeshedding nitpick, but here goes anyway. Why
do you call MIPI DBI just "mipi", here and all around? Why not
"mipi_dbi" or "dbi"? We never talk about "vesa" displays or use that as
a shorthand when we refer to Display Port either.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-06 11:25 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 16:03 [PATCH v3 0/7] drm: Add support for tiny LCD displays Noralf Trønnes
2017-01-31 16:03 ` [PATCH v3 1/7] drm: Add DRM " Noralf Trønnes
2017-01-31 16:23 ` Daniel Vetter
[not found] ` <20170131162341.ejr2b3bq7tghafzj-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-01-31 18:01 ` Noralf Trønnes
2017-01-31 20:10 ` Daniel Vetter
2017-02-06 9:17 ` Thierry Reding
2017-02-06 19:23 ` Noralf Trønnes
2017-02-07 6:58 ` Daniel Vetter
2017-02-07 11:48 ` Thierry Reding
2017-02-06 10:12 ` Jani Nikula
2017-01-31 16:03 ` [PATCH v3 2/7] drm/tinydrm: Add helper functions Noralf Trønnes
2017-02-06 8:56 ` Thierry Reding
2017-02-06 9:09 ` Daniel Vetter
[not found] ` <20170206090918.6rqr6l7pd62znl5j-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-02-06 9:35 ` Thierry Reding
2017-02-06 10:07 ` Daniel Vetter
[not found] ` <CAKMK7uHgW15EPpPSU2se7r89JCGD_oTvn9ZJptYaNJAWMKb9Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-06 11:08 ` Thierry Reding
2017-02-06 15:53 ` Daniel Vetter
2017-02-06 22:11 ` Noralf Trønnes
2017-02-07 11:38 ` Thierry Reding
[not found] ` <20170206155303.2fwihmlh6ln4eskt-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2017-02-06 22:28 ` Dave Airlie
2017-02-07 7:00 ` Daniel Vetter
[not found] ` <CAPM=9tywXAt8v4VwjHA7OhsW6Xg=w8gDeY5s+fHjhdmuUUG7gg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-07 11:11 ` Thierry Reding
2017-02-07 11:21 ` Daniel Vetter
2017-02-07 11:44 ` Thierry Reding
2017-02-07 13:23 ` Daniel Vetter
[not found] ` <20170206110847.GH27607-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2017-02-06 22:55 ` Rob Herring
2017-02-07 7:08 ` Daniel Vetter
2017-02-06 10:10 ` Jani Nikula
2017-01-31 16:03 ` [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support Noralf Trønnes
2017-02-06 8:48 ` Thierry Reding
[not found] ` <20170206084848.GC27607-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2017-02-06 11:30 ` Jani Nikula
2017-02-06 11:53 ` Thierry Reding
2017-02-06 12:34 ` Andrzej Hajda
2017-02-06 15:45 ` Noralf Trønnes
[not found] ` <20170131160319.9695-4-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2017-02-06 11:25 ` Jani Nikula [this message]
[not found] ` <20170131160319.9695-1-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2017-01-31 16:03 ` [PATCH v3 4/7] of: Add vendor prefix for Multi-Inno Noralf Trønnes
2017-01-31 16:03 ` [PATCH v3 5/7] dt-bindings: display: Add common rotation property Noralf Trønnes
2017-02-01 17:41 ` Rob Herring
2017-02-03 12:16 ` Noralf Trønnes
[not found] ` <30cce12b-b6c6-c651-409e-5574b5f7576e-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2017-02-06 7:10 ` Thierry Reding
2017-01-31 16:03 ` [PATCH v3 6/7] dt-bindings: Add Multi-Inno MI0283QT binding Noralf Trønnes
2017-02-01 17:42 ` Rob Herring
2017-01-31 16:03 ` [PATCH v3 7/7] drm/tinydrm: Add support for Multi-Inno MI0283QT display Noralf Trønnes
[not found] ` <20170131160319.9695-8-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2017-02-06 8:25 ` Thierry Reding
2017-02-07 12:00 ` [PATCH v3 0/7] drm: Add support for tiny LCD displays Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h947blya.fsf@intel.com \
--to=jani.nikula-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).