From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v2 5/7] ARM: mmp: append OF support on pxa168 Date: Sun, 08 Apr 2012 21:51:08 -0400 Message-ID: <87hawtzn8z.fsf@laptop.org> References: <1330950111-30797-1-git-send-email-haojian.zhuang@marvell.com> <1330950111-30797-6-git-send-email-haojian.zhuang@marvell.com> <87y5q5znx8.fsf@laptop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Haojian Zhuang's message of "Mon, 9 Apr 2012 09:46:58 +0800") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Haojian Zhuang Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Haojian Zhuang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Sun, Apr 08 2012, Haojian Zhuang wrote: > There's a typo error in comments. MMP_DT is only for PXA168 & PXA910. > We need to append MMP2_DT for ARMv7 in arch-mmp directory. Since we > are not intended to build ARMv5 and ARMv7 together. Okay. In that case, you should make sure that MMP_DT cannot be selected when CPU_MMP2 is selected, by encoding that dependency in the Kconfig. Thanks, - Chris. -- Chris Ball One Laptop Per Child