From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E42819CC2D; Thu, 31 Oct 2024 13:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730380222; cv=none; b=lpbIbNsxJb8Slsize8DrqveMzxPEyKe8uuil8plDPeRhnMkNA9y1LiAJ9qStGNq6LVrHdv54HMsOQCND6FEw1og9mMTlOn2TVPe2Ll2ckVGIP0QOVwfP3rrGVCyFHuFCmPGJiG+Ad2DfmXSVLFJ5TYv0zOZCT89V1oH5O0uNIxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730380222; c=relaxed/simple; bh=Khel1CjCqD6GywqHIRkJC23AjuuARNeWjnIoyg8t5ys=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=VLR2+SVlKDczaRHKq+CrQgVQcEmSM0jFlYlJgRYsb1S96N9iXzS4nhQdDbcWNDlMqYFWlGTYyn1GD1R/GotuxSZAuyVoIdUXhMPQe8b4eIDf0A6P65FLm4n9jYs6zkMiDJSpwR2GVhFJiWjXPcEs6zvUYSlG7mxjSKknz37Ijgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=cZPr7c9r; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=r/WF7NtE; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="cZPr7c9r"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="r/WF7NtE" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730380218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n9KzjzVNQ8Kocvxcj31qY9sIt3lmgpdIUIkiScgCA4Y=; b=cZPr7c9reVDeCHTlZwoxBPVYMZlN3G/dTVTQdkTTDaJ89tpKCtPo8EkeU27J1U2NKhv801 5lQ0w7+al8WvIbp5qPeOp/1W71eF8XFHZovHvM873GgwnxRq/Wbt0xNjgYs67PA6+YUmqW YiJm4SpGCaaksFnT/OFSdM3lHs0Sp5MutH9zzBB5TdFzfp+a8x9ghckGs0o8Tax/4jQUOG w/PEpAZwP+Jg6A7cJMeQab4KduJXxkwIUpec86VkGxT0qh71AYiixi0+C9gztjf/KqJdG3 xU/vFXaYaRr3/+M/M+lvpCJ0JLpb3TE7ckYAMlPLqIoWf5ffv2uobiVI/rLJ4w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730380218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n9KzjzVNQ8Kocvxcj31qY9sIt3lmgpdIUIkiScgCA4Y=; b=r/WF7NtEoHc5yMmmmEgyNRfuKPAwN6UMWQX7pGgI8kOncV4SLVrtCGL1KPWEVsxsmKVtXe sWw/W+y07XAozBDQ== To: Conor Dooley , Inochi Amaoto Cc: Conor Dooley , Chen Wang , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Peter Zijlstra , Inochi Amaoto , Guo Ren , Lad Prabhakar , Yangyu Chen , Anup Patel , Hal Feng , Geert Uytterhoeven , Yixun Lan , Longbin Li , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Sophgo SG2044 ACLINT SSWI In-Reply-To: <20241031-armored-marbled-36cfb6d599e3@spud> References: <20241031060859.722258-1-inochiama@gmail.com> <20241031060859.722258-2-inochiama@gmail.com> <20241031-armored-marbled-36cfb6d599e3@spud> Date: Thu, 31 Oct 2024 14:10:18 +0100 Message-ID: <87ikt8wh8l.ffs@tglx> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Oct 31 2024 at 12:38, Conor Dooley wrote: > On Thu, Oct 31, 2024 at 02:14:40PM +0800, Inochi Amaoto wrote: >> On Thu, Oct 31, 2024 at 02:08:57PM +0800, Inochi Amaoto wrote: >> > Sophgo SG2044 has a new version of T-HEAD C920, which implement >> > a fully featured T-HEAD ACLINT device. This ACLINT device contains >> > a SSWI device to support fast S-mode IPI. >> > >> > Add necessary compatible string for the T-HEAD ACLINT sswi device. >> > >> > Link: https://www.xrvm.com/product/xuantie/C920 >> > Signed-off-by: Inochi Amaoto >> >> Hi, Conor, >> >> Could you review it again? I have updated the description of >> the binding and mark the device is T-HEAD specific. > > Only thing I would say is that > title: Sophgo sg2044 ACLINT Supervisor-level Software Interrupt Device > should probably be > title: T-Head c900 ACLINT Supervisor-level Software Interrupt Device > or similar, since this isn't Sophgo's IP. > > w/ that, > Reviewed-by: Conor Dooley > (dunno if Thomas is willing to change that on application) Yes