From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41459C4363A for ; Mon, 5 Oct 2020 06:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC5A12080A for ; Mon, 5 Oct 2020 06:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="45xAOsHg"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="mZ2LdqX7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725853AbgJEGOc (ORCPT ); Mon, 5 Oct 2020 02:14:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgJEGOc (ORCPT ); Mon, 5 Oct 2020 02:14:32 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30ADDC0613CE; Sun, 4 Oct 2020 23:14:32 -0700 (PDT) From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1601878470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vMU4E8sDuXXKfLR81j2vp/9okWJ1wi2vlEdx+O5fKXw=; b=45xAOsHg3KUy8lU8CnAwoaagLxZeIWtAUCBsIBZGpyasUgIN1FyEM6xCMsUOEp3cqAyRpe GZfjkInMJjxzquXCMFdKQo2VwD1DG5s/iwLrx3h7UnG3q9NlvawlguUhnkGkxo6VKwEuMK xaxs8KjdF0/adgXnyeyGhCXr7amKRTLl3UfDBwjo4CqdlnXeZMCdd5CiVutuXYrDqpO5OF rjBv5pc8UOQyM9pu+U0Y1GQlRBnEDW9H/Lq/7hbDPUpfefGwx9ywJPWhJzaZzpy9E0FE1E wQRfdptDxX6VV9yYs7aALOtZ7CxksSvPtVGk0HkUA4isv1X7RUH96FiWHj+hhQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1601878470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vMU4E8sDuXXKfLR81j2vp/9okWJ1wi2vlEdx+O5fKXw=; b=mZ2LdqX7hF0Q/YlR0Ujdc2OYgJV8TAJYC5R+NQ4q0JKEKzkhGg6N+jVZRF4e2h6bxJfE1p uwASjFJRGrQLFPBw== To: Vladimir Oltean Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Sebastian Andrzej Siewior , Richard Cochran , Kamil Alkhouri , ilias.apalodimas@linaro.org Subject: Re: [PATCH net-next v6 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches In-Reply-To: <20201004115649.i5w7r4djxwpnjx5w@skbuf> References: <20201004112911.25085-1-kurt@linutronix.de> <20201004112911.25085-2-kurt@linutronix.de> <20201004115649.i5w7r4djxwpnjx5w@skbuf> Date: Mon, 05 Oct 2020 08:14:29 +0200 Message-ID: <87imbptd16.fsf@kurt> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --=-=-= Content-Type: text/plain On Sun Oct 04 2020, Vladimir Oltean wrote: > On Sun, Oct 04, 2020 at 01:29:05PM +0200, Kurt Kanzenbach wrote: >> +static const struct dsa_device_ops hellcreek_netdev_ops = { >> + .name = "hellcreek", >> + .proto = DSA_TAG_PROTO_HELLCREEK, >> + .xmit = hellcreek_xmit, >> + .rcv = hellcreek_rcv, >> + .overhead = HELLCREEK_TAG_LEN, > > After the changes in "Generic adjustment for flow dissector in DSA": > https://patchwork.ozlabs.org/project/netdev/list/?series=204347&state=* > you might want to set ".tail_tag = true" (see patch 07/15), either now > or later. > > Either way, > > Reviewed-by: Vladimir Oltean Added it. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEooWgvezyxHPhdEojeSpbgcuY8KYFAl96ucUACgkQeSpbgcuY 8KZ8Bw//VvZLSyPAK4qKR/nhN4LVdAQgw72bbKlVEVj4GDU3b0hxKwsDtiy66kqX IrdJ2FzUHAl3o1Uc5T5kX6zIasRA0V7lrLl+37uGDXJ3UX4e4fq8B72/GcQDXpeZ XEJskgr5x8X8ixV+kTBp4u3reQDgZqBlCHGzpuhQdHyajkLCPVQvLoTiF8BgX7ps MdSYnscoAjebdjPsr6pFQ1/nJGTt/EcHZ3f60uvv7Em4pt1DMiD0nmd1B/5sLWSb 3aRpFjM4xdemC73XQ4wve2B+rIuGevui7Du57h2eEgGOQeUiproZt8sV/+GW7a+z QVTEAur2UjzwvACrlJh0shw9PY5tdQDlnt36bxfyP1+JFpZqK/TL0u2WD+o/y9LT Sw0cpfIJyLYnyqaiwjaeqgtwulGLHXIezKDsUdCCkBydzBIdBMuoPklsDZgVn+of ZwjV4PK/hgDGp4i8l7YrlN02fuVRJgtplZO3DDP8KhyJq8Bgm9oZf0yJghIWm4Ui CFv3xhleQ7n3FfcJT4MQgZtqYlMypnldzh11sxO+iiShv1ppEy9bYeYhPnfVho2W WZs4iKN7RwuolA4sfVQcrxeCdRTT2Hn3n72q6HMpaW6vd9dfmSTg0WSVHnoZHkUH zCFfjfrS5xNS2lQBcuQfX4U+sI6DCTJ7YpL5qkKZTJXhVaYEdtw= =G5b8 -----END PGP SIGNATURE----- --=-=-=--