From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB19CA0ECA for ; Tue, 12 Sep 2023 12:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234715AbjILMmE (ORCPT ); Tue, 12 Sep 2023 08:42:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231248AbjILMmC (ORCPT ); Tue, 12 Sep 2023 08:42:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B299F; Tue, 12 Sep 2023 05:41:58 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 808A3C433C8; Tue, 12 Sep 2023 12:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694522518; bh=h3OJqaREq1rQ96Kkn6wCU6LIKOZUXBEtwJ0dIladPvw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sVuQJ7dHhztQen5pysGvSzw0rwM+JroJTBHrdBw3NVSAmovSlGp2mJHZDPfZRni7m L047vntKITLuxQ/Y6uIaF/2aPKqzh5+0bwLzf9bQ1HP71c1onfFnzRnVy3aHkpXpUh haYNLNuAbgVVl4ndvy57N1V1P4B4A0Lwb5+XcFau4684KDaJPSqIu8siTmhiGaUTuv frJL+aalFKyRWqBdNmA0k9S3dVuR3wjwsTFOAv0PgxsIWbTjdJJHEEGC4EyMN1jeLd fY05MvzdWAc5T4Kn08h6g3h0pBLxzYwigNKA2OYs0TB+OEvYkPOk+W/WJx4iYpKdca D0mnF5+eBzEzg== Received: from [104.132.96.100] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qg2iJ-00CGRW-Pl; Tue, 12 Sep 2023 13:41:56 +0100 Date: Tue, 12 Sep 2023 13:41:50 +0100 Message-ID: <87jzsv4l81.wl-maz@kernel.org> From: Marc Zyngier To: Geert Uytterhoeven Cc: Lad Prabhakar , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Prabhakar , Biju Das Subject: Re: [PATCH v3 2/3] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update description for '#interrupt-cells' property In-Reply-To: References: <20220722151155.21100-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220722151155.21100-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <8735eqdbav.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 104.132.96.100 X-SA-Exim-Rcpt-To: geert@linux-m68k.org, prabhakar.mahadev-lad.rj@bp.renesas.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, prabhakar.csengg@gmail.com, biju.das.jz@bp.renesas.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 08 Sep 2023 10:31:35 +0100, Geert Uytterhoeven wrote: >=20 > Hi Marc, >=20 > On Thu, Aug 11, 2022 at 4:50=E2=80=AFPM Geert Uytterhoeven wrote: > > On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier wrote: > > > On Fri, 22 Jul 2022 16:11:54 +0100, > > > Lad Prabhakar wrote: > > > > > > > > Update description for '#interrupt-cells' property to utilize the > > > > RZG2L_{NMI,IRQX} for the first cell defined in the > > > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file. > > > > > > > > Signed-off-by: Lad Prabhakar > > > > --- > > > > v3: > > > > * New patch > > > > > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesa= s,rzg2l-irqc.yaml > > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesa= s,rzg2l-irqc.yaml > > > > @@ -31,8 +31,9 @@ properties: > > > > - const: renesas,rzg2l-irqc > > > > > > > > '#interrupt-cells': > > > > - description: The first cell should contain external interrupt = number (IRQ0-7) and the > > > > - second cell is used to specify the flag. > > > > + description: The first cell should contain a macro RZG2L_{NMI,= IRQX} included in the > > > > + include/dt-bindings/interrupt-controller/irqc-rzg= 2l.h and the second > > > > + cell is used to specify the flag. > > > > > > I think a binding should be self describing, and not rely on an opaque > > > macro. Mentioning that there is a macro that encodes it is fine, but > > > the values are what matter, specially when considering that other OSs > > > could (and should be able to) write their own DTs from scratch without > > > depending on something that is very much Linux-specific. > > > > The macros are not Linux-specific, and are part of the bindings. > > But the only hard dependency on > > is the DT source file describing the board. > > > > Reviewed-by: Geert Uytterhoeven >=20 > Looks like this fell through the cracks? > The two other patches from this series were applied in v6.1. >=20 > Note that the current DT bindings are incorrect, as they do not take into > account that the value of zero is used to represent the NMI. >=20 > Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add > Renesas RZ/G2L Interrupt Controller") >=20 > Should we resend instead? It applied cleanly to v6.6-rc1, so there should be no need. Thanks, M. --=20 Without deviation from the norm, progress is not possible.