From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D64CC6FD1D for ; Mon, 27 Mar 2023 18:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbjC0SQx (ORCPT ); Mon, 27 Mar 2023 14:16:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232345AbjC0SQs (ORCPT ); Mon, 27 Mar 2023 14:16:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EDBF30E9 for ; Mon, 27 Mar 2023 11:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679940957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UK/vUrhHuqntUFN+BgSrVc4SUZdQT7VSDoiLy/b5Axs=; b=NNwE4krVkJRl1kRk9dgNeddDXT6qBNoT9lYT/anhqIt1e0C/CB1FfHZFhPEWbXl81TNP7x 9n4xO9Dn9pRHQHCJ4QS+xo6pSaPckhWYzHJxfZHEVlcm2Z8sq1IKcG8p5H0n3gBasKtOD8 0ZxLJffwMkZFWJNsNEhkG2HQ6aKeNSA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-kF892kRyMO2VXh9m2gUZoQ-1; Mon, 27 Mar 2023 14:15:56 -0400 X-MC-Unique: kF892kRyMO2VXh9m2gUZoQ-1 Received: by mail-wm1-f71.google.com with SMTP id bg13-20020a05600c3c8d00b003ed40f09355so5113485wmb.5 for ; Mon, 27 Mar 2023 11:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679940954; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UK/vUrhHuqntUFN+BgSrVc4SUZdQT7VSDoiLy/b5Axs=; b=A/NScQhUD5I+tDl09xXGbHAzdQHXJyVFNwJbJi8B+5NtngQh6XWeF6bna69JHE+GVl GCNWpFFm+59ld0X9nQUE3qGIO+B523Ay8YKmbljwD856Y2u4iLze5EO0dX9YIyYSOX3U ObiCA3XzxuOmrbHF78HoC1mUmQaQbJedJdYJ52h9nQmubd4dSbNHyt+cu73ft9GGBMVT OrdHLvjP48YSElduY2JomvThK4fch3L/mASuLCC3ketP1dIHiT0OVgIbBVJ34R2RzXTd k9BlKXvYElRgAtNK8715dma6Lb7Cxjv9jNt5Rsxp47DcdKhpruZ9+FbaBMAZ3rEy5Dl6 YFfA== X-Gm-Message-State: AAQBX9fs3iK+tRkVr2+886BSlqIkjGcxhVHOv04tJkAhI3kVHgT2SUJ3 3TqebutTHAMBSUEzI9rsp24uW8xsgZeMlgFiMnBXdN8cjWDH/GvD2xN/LoM+WNdkkvE9/uXCZS8 aYU7HGbqloS06nTQf4bUB3g== X-Received: by 2002:adf:e98b:0:b0:2c5:4ffb:b5d4 with SMTP id h11-20020adfe98b000000b002c54ffbb5d4mr10067890wrm.19.1679940953967; Mon, 27 Mar 2023 11:15:53 -0700 (PDT) X-Google-Smtp-Source: AKy350ZaT6ahYHthFl0PUIe9zMPk4lKHZv5UbJklHs82pkUCUN/DtNmeerfQ+58giM6OUYgp3Y5NMA== X-Received: by 2002:adf:e98b:0:b0:2c5:4ffb:b5d4 with SMTP id h11-20020adfe98b000000b002c54ffbb5d4mr10067876wrm.19.1679940953689; Mon, 27 Mar 2023 11:15:53 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p17-20020adfcc91000000b002c71dd1109fsm25758248wrj.47.2023.03.27.11.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 11:15:53 -0700 (PDT) From: Javier Martinez Canillas To: =?utf-8?Q?Ond=C5=99ej?= Jirman Cc: Heiko =?utf-8?Q?St=C3=BCbner?= , linux-kernel@vger.kernel.org, Robert Mader , Laurent Pinchart , Peter Robinson , Jacopo Mondi , Martijn Braam , Kamil =?utf-8?Q?Trzci=C5=84ski?= , Caleb Connolly , Jarrah Gosbell , Krzysztof Kozlowski , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support In-Reply-To: <20230327174855.xpxrdfldqcxk463r@core> References: <20230327074136.1459212-1-javierm@redhat.com> <20230327130147.wgxl2qayhzsi2xak@core> <87wn32rynm.fsf@minerva.mail-host-address-is-not-set> <1924921.PYKUYFuaPT@diego> <87mt3yrwzo.fsf@minerva.mail-host-address-is-not-set> <20230327174855.xpxrdfldqcxk463r@core> Date: Mon, 27 Mar 2023 20:15:52 +0200 Message-ID: <87jzz2rrfr.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Ond=C5=99ej Jirman writes: > On Mon, Mar 27, 2023 at 06:15:55PM +0200, Javier Martinez Canillas wrote: [...] >>=20 >> It is broken though? This is what is in Ondrej downstream tree and I see >> no issues on my Pinephone Pro. He mentioned some flicker when looking at >> the signals with a scope and hooking a photoresistor. > > LED regulator is driven out of spec by a frequency that's 20x lower than > recommended, if you want short version of what's broken about the DT patc= h. > >> But that's fair. I'll let Ondrej then post a v3 if he wants to address t= he >> issues he pointed out, since is his patch after all. > > It's not my patch. Original author of the DT is Martijn or Kamil. I just = carry > their DT work in split-up patches in my tree, and I sometimes try to find= solutions > to bugs I find when using PPP. That's the story of these DT changes you'r= e posting. > > Since you posted this DT patch for upstreaming, I wanted to help you by r= eviewed > it more completely, so I opened the schematic and datasheets for the comp= onents > that are described in this patch, and discovered these new issues I comme= nted > about. And I also tested it on top of linus/master. > > Just because something is in my tree doesn't mean it's mine, or that I re= viewed > it in detail and prepared it for upstreaming, or that I'm interested in Thanks for the clarification. Because the patch had your authorship I wrongly assumed that came from you. Sorry about the confusion. > upstreaming it. I'm just trying to help you with your upstreaming effort = by > testing and review since I got to know the hardware quite well over the l= ast > years and can check the schematics and datasheets quickly, and I like to = think > upstream code is held to higher standard. That's all. > Appreciate your help and I agree that upstream code should be held to a high standard. But since the DTS in mainline is pretty basic anyways (you can only boot to serial right now), is not really usable for other thing than development and keep adding the missing support. So I thought that we could do it in steps without creating that much work for the people trying to post the downstream patches and having to re-spin too many times. --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat