From: Kalle Valo <kvalo@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
"Tony Lindgren" <tony@atomide.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Felipe Balbi" <balbi@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Russell King" <linux@armlinux.org.uk>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] p54spi: convert to devicetree
Date: Wed, 15 Mar 2023 07:32:57 +0200 [thread overview]
Message-ID: <87jzziwpdi.fsf@kernel.org> (raw)
In-Reply-To: <e8dc9acb-6f85-e0a9-a145-d101ca6da201@gmail.com> (Christian Lamparter's message of "Tue, 14 Mar 2023 21:18:55 +0100")
Christian Lamparter <chunkeey@gmail.com> writes:
> Hi,
>
> On 3/14/23 17:30, Arnd Bergmann wrote:
>> The Prism54 SPI driver hardcodes GPIO numbers and expects users to
>> pass them as module parameters, apparently a relic from its life as a
>> staging driver. This works because there is only one user, the Nokia
>> N8x0 tablet.
>>
>> Convert this to the gpio descriptor interface and move the gpio
>> line information into devicetree to improve this and simplify the
>> code at the same time.
>
> Yes, this is definitely the right idea/way. From what I remember, Kalle
> Valo was partially involved in p54spi/stlc45xx. The details are very fuzzy.
> So, I could be totally wrong. From what I remember Kalle was working
> for Nokia (or as a contractor for Nokia?) at the time.
I wrote stlc45xx driver as part of my thesis when working for Nokia and
I think then someone wrote p54spi after that. Oh man, this was a long
time ago so hard to remember :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-03-15 5:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 16:30 [PATCH] p54spi: convert to devicetree Arnd Bergmann
2023-03-14 16:44 ` Johannes Berg
2023-03-14 19:57 ` Krzysztof Kozlowski
2023-03-14 21:40 ` Arnd Bergmann
2023-03-15 6:32 ` Krzysztof Kozlowski
2023-03-15 6:50 ` Arnd Bergmann
2023-03-15 7:11 ` Krzysztof Kozlowski
2023-03-14 20:18 ` Christian Lamparter
2023-03-15 5:32 ` Kalle Valo [this message]
2023-03-17 21:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzziwpdi.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=balbi@kernel.org \
--cc=bcousson@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).