* [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
@ 2021-03-22 0:39 Marcin Wojtas
2021-03-22 12:14 ` Andrew Lunn
2021-06-17 13:14 ` Gregory CLEMENT
0 siblings, 2 replies; 6+ messages in thread
From: Marcin Wojtas @ 2021-03-22 0:39 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: andrew, gregory.clement, robh+dt, Marcin Wojtas
A recent switch to a dedicated AP807 compatible string for the Xenon
SD/MMC controller result in the driver not being probed when
using updated device tree with the older kernel revisions.
It may also be problematic for other OSs/firmware that use
Linux device tree sources as a reference. Resolve the problem
with backward compatibility by restoring a previous compatible
string as secondary one.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
index d9bbbfa4b4eb..4a23f65d475f 100644
--- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
@@ -29,6 +29,7 @@ cpu_clk: clock-cpu {
};
&ap_sdhci0 {
- compatible = "marvell,armada-ap807-sdhci";
+ compatible = "marvell,armada-ap807-sdhci",
+ "marvell,armada-ap806-sdhci"; /* Backward compatibility */
};
--
2.29.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
2021-03-22 0:39 [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon Marcin Wojtas
@ 2021-03-22 12:14 ` Andrew Lunn
2021-05-12 15:50 ` Marcin Wojtas
2021-06-17 13:14 ` Gregory CLEMENT
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2021-03-22 12:14 UTC (permalink / raw)
To: Marcin Wojtas
Cc: linux-arm-kernel, devicetree, linux-kernel, gregory.clement,
robh+dt
On Mon, Mar 22, 2021 at 01:39:15AM +0100, Marcin Wojtas wrote:
> A recent switch to a dedicated AP807 compatible string for the Xenon
> SD/MMC controller result in the driver not being probed when
> using updated device tree with the older kernel revisions.
> It may also be problematic for other OSs/firmware that use
> Linux device tree sources as a reference. Resolve the problem
> with backward compatibility by restoring a previous compatible
> string as secondary one.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
2021-03-22 12:14 ` Andrew Lunn
@ 2021-05-12 15:50 ` Marcin Wojtas
2021-06-16 19:12 ` Marcin Wojtas
0 siblings, 1 reply; 6+ messages in thread
From: Marcin Wojtas @ 2021-05-12 15:50 UTC (permalink / raw)
To: Grégory Clement
Cc: linux-arm-kernel, Andrew Lunn, devicetree,
Linux Kernel Mailing List, Rob Herring
Hi Gregory,
pon., 22 mar 2021 o 13:14 Andrew Lunn <andrew@lunn.ch> napisał(a):
>
> On Mon, Mar 22, 2021 at 01:39:15AM +0100, Marcin Wojtas wrote:
> > A recent switch to a dedicated AP807 compatible string for the Xenon
> > SD/MMC controller result in the driver not being probed when
> > using updated device tree with the older kernel revisions.
> > It may also be problematic for other OSs/firmware that use
> > Linux device tree sources as a reference. Resolve the problem
> > with backward compatibility by restoring a previous compatible
> > string as secondary one.
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
Do you have any feedback about this patch? I just noticed it's not
merged in v5.13-rc1, it would be great to have it in the next release
though.
Best regards,
Marcin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
2021-05-12 15:50 ` Marcin Wojtas
@ 2021-06-16 19:12 ` Marcin Wojtas
0 siblings, 0 replies; 6+ messages in thread
From: Marcin Wojtas @ 2021-06-16 19:12 UTC (permalink / raw)
To: Grégory Clement
Cc: linux-arm-kernel, Andrew Lunn, devicetree,
Linux Kernel Mailing List, Rob Herring
Hi!
śr., 12 maj 2021 o 17:50 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> Hi Gregory,
>
> pon., 22 mar 2021 o 13:14 Andrew Lunn <andrew@lunn.ch> napisał(a):
> >
> > On Mon, Mar 22, 2021 at 01:39:15AM +0100, Marcin Wojtas wrote:
> > > A recent switch to a dedicated AP807 compatible string for the Xenon
> > > SD/MMC controller result in the driver not being probed when
> > > using updated device tree with the older kernel revisions.
> > > It may also be problematic for other OSs/firmware that use
> > > Linux device tree sources as a reference. Resolve the problem
> > > with backward compatibility by restoring a previous compatible
> > > string as secondary one.
> > >
> > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> >
>
> Do you have any feedback about this patch? I just noticed it's not
> merged in v5.13-rc1, it would be great to have it in the next release
> though.
>
Kind reminder. We are approaching v5.13 and it would be really great
to have this fix in time.
Thanks,
Marcin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
2021-03-22 0:39 [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon Marcin Wojtas
2021-03-22 12:14 ` Andrew Lunn
@ 2021-06-17 13:14 ` Gregory CLEMENT
2021-06-17 13:49 ` Marcin Wojtas
1 sibling, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2021-06-17 13:14 UTC (permalink / raw)
To: Marcin Wojtas, linux-arm-kernel, devicetree, linux-kernel
Cc: andrew, robh+dt, Marcin Wojtas
Hi Marcin,
> A recent switch to a dedicated AP807 compatible string for the Xenon
> SD/MMC controller result in the driver not being probed when
> using updated device tree with the older kernel revisions.
> It may also be problematic for other OSs/firmware that use
> Linux device tree sources as a reference. Resolve the problem
> with backward compatibility by restoring a previous compatible
> string as secondary one.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> index d9bbbfa4b4eb..4a23f65d475f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> @@ -29,6 +29,7 @@ cpu_clk: clock-cpu {
> };
>
> &ap_sdhci0 {
> - compatible = "marvell,armada-ap807-sdhci";
> + compatible = "marvell,armada-ap807-sdhci",
> + "marvell,armada-ap806-sdhci"; /* Backward compatibility */
> };
>
> --
> 2.29.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
2021-06-17 13:14 ` Gregory CLEMENT
@ 2021-06-17 13:49 ` Marcin Wojtas
0 siblings, 0 replies; 6+ messages in thread
From: Marcin Wojtas @ 2021-06-17 13:49 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: linux-arm-kernel, devicetree, Linux Kernel Mailing List,
Andrew Lunn, Rob Herring
czw., 17 cze 2021 o 15:14 Gregory CLEMENT
<gregory.clement@bootlin.com> napisał(a):
>
> Hi Marcin,
>
> > A recent switch to a dedicated AP807 compatible string for the Xenon
> > SD/MMC controller result in the driver not being probed when
> > using updated device tree with the older kernel revisions.
> > It may also be problematic for other OSs/firmware that use
> > Linux device tree sources as a reference. Resolve the problem
> > with backward compatibility by restoring a previous compatible
> > string as secondary one.
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> Applied on mvebu/dt64
>
Thank you!
Marcin
>
> > ---
> > arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> > index d9bbbfa4b4eb..4a23f65d475f 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> > @@ -29,6 +29,7 @@ cpu_clk: clock-cpu {
> > };
> >
> > &ap_sdhci0 {
> > - compatible = "marvell,armada-ap807-sdhci";
> > + compatible = "marvell,armada-ap807-sdhci",
> > + "marvell,armada-ap806-sdhci"; /* Backward compatibility */
> > };
> >
> > --
> > 2.29.0
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> Gregory Clement, Bootlin
> Embedded Linux and Kernel engineering
> http://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-17 13:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22 0:39 [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon Marcin Wojtas
2021-03-22 12:14 ` Andrew Lunn
2021-05-12 15:50 ` Marcin Wojtas
2021-06-16 19:12 ` Marcin Wojtas
2021-06-17 13:14 ` Gregory CLEMENT
2021-06-17 13:49 ` Marcin Wojtas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).