Re: [PATCH] arm64: dts: marvell: mark CP110 ahci as dma-coherent

[Gregory CLEMENT <gregory.clement@bootlin.com>]

Hi Mark,
 
 On sam., mars 31 2018, Mark Kettenis <kettenis@openbsd.org> wrote:

> The hardware is clearly DMA coherent and not marking it as such leads
> to cache coherency problems, at least with the OpenBSD kernel.

The reason to not having this flag from the beginning was that there was
some issue around it in the very first revision (A0) of the SoC. But now
all the SoC publicly released belongs to a newer revision that don't
have anymore this issue, so your patch make sense.

Applied on mvebu/dt64-for-4.18

Thanks,

Gregory


>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> index a8af4136dbe7..7e9177ef7b7d 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> @@ -231,6 +231,7 @@
>  			compatible = "marvell,armada-8k-ahci",
>  			"generic-ahci";
>  			reg = <0x540000 0x30000>;
> +			dma-coherent;
>  			interrupts = <ICU_GRP_NSR 107 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&CP110_LABEL(clk) 1 15>;
>  			status = "disabled";
> -- 
> 2.16.2
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com