From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: [PATCH] Revert "h8300: clocksource" Date: Sat, 31 Oct 2015 13:13:38 +0900 Message-ID: <87k2q3wu8d.wl-ysato@users.sourceforge.jp> References: <1446200775-23898-1-git-send-email-daniel.lezcano@linaro.org> <7633294.svub55eV7t@wuerfel> <56335924.408@linaro.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-2022-JP Return-path: In-Reply-To: <56335924.408@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano Cc: Arnd Bergmann , tglx@linutronix.de, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:OPEN FIRMWARE AND..." , "moderated list:H8/300 ARCHITECTURE" List-Id: devicetree@vger.kernel.org On Fri, 30 Oct 2015 20:48:52 +0900, Daniel Lezcano wrote: > > On 10/30/2015 12:19 PM, Arnd Bergmann wrote: > > On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote: > >> This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483. > > [ ... ] > > > I found that Yoshinori Sato has always addressed all review comments very > > quickly by rewriting the code in a proper manner when mistakes were > > pointed out in the other drivers. Maybe you can describe now what the > > problems are with the three drivers to give him a chance to fix them? > > I agree it is a good argument to give him the opportunity to fix the code. > > Yoshinori Sato, can you please do a cleanup in the init functions to > comply with the other drivers, use CLOCKSOURCE_OF_DECLARE and remove > the module exit code ? > > Thanks. OK. Please wait few days. > -- Daniel > > -- > Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog > -- Yoshinori Sato