From: Marc Zyngier <maz@kernel.org>
To: Anirudha Sarangi <anirudha.sarangi@xilinx.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Michal Simek <michal.simek@xilinx.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Douglas Anderson <dianders@chromium.org>,
Hans de Goede <hdegoede@redhat.com>,
Maulik Shah <mkshah@codeaurora.org>,
Zhen Lei <thunder.leizhen@huawei.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
<devicetree@vger.kernel.org>, <git@xilinx.com>
Subject: Re: [PATCH 2/3] irqchip: Add support to remove irqchip driver modules.
Date: Tue, 27 Apr 2021 13:35:10 +0100 [thread overview]
Message-ID: <87lf93oqgx.wl-maz@kernel.org> (raw)
In-Reply-To: <20210427113136.12469-3-anirudha.sarangi@xilinx.com>
On Tue, 27 Apr 2021 12:31:35 +0100,
Anirudha Sarangi <anirudha.sarangi@xilinx.com> wrote:
>
> The existing irqchip implementation does not fully support use cases
> where an irqchip driver has to be used as a module. In particular there
> is no support to remove an irqchip driver module.
> The use cases where an irqchip driver has to be loaded and then removed
> as a module are really relevant in fpga world. A user can decide to
> have a irqchip as part of a removable partial fpga region. In such cases
> not only the corresponding irqchip driver has to be loaded as a module,
> but must also be removed when the removable partial region is removed.
>
> The existing implementation updates the existing framework to achieve
> the above said goal.
>
> Signed-off-by: Anirudha Sarangi <anirudha.sarangi@xilinx.com>
There is absolutely no way we can entertain the removal of an
interrupt controller based on *this*.
What happen to the irqdesc structures? What happen when a client
driver decides to do a disable_irq(), or any other interaction with
the interrupt controller that now has dangling pointers everywhere (if
your third patch is supposed to be an example of how to use this
functionality)?
So no, you can't do that until you figure out all the dependencies
that need to be accounted for to safely remove an interrupt
controller.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-04-27 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 11:31 [PATCH 0/3] Updates in irqchip framework to remove irqchip Anirudha Sarangi
2021-04-27 11:31 ` [PATCH 1/3] irqchip: xilinx: Avoid __init macro usage for xilinx_intc_of_init Anirudha Sarangi
2021-04-27 12:17 ` Marc Zyngier
2021-04-27 11:31 ` [PATCH 2/3] irqchip: Add support to remove irqchip driver modules Anirudha Sarangi
2021-04-27 12:35 ` Marc Zyngier [this message]
2021-04-27 11:31 ` [PATCH 3/3] irqchip: xilinx: Add support to remove the Xilinx INTC driver module Anirudha Sarangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf93oqgx.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=anirudha.sarangi@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=git@xilinx.com \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkshah@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).