From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C65C433DB for ; Tue, 22 Dec 2020 15:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9A27230FC for ; Tue, 22 Dec 2020 15:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbgLVPK5 (ORCPT ); Tue, 22 Dec 2020 10:10:57 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:35594 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727904AbgLVPK5 (ORCPT ); Tue, 22 Dec 2020 10:10:57 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1608649832; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=k4T60vC2s1dNLZaTWXiVi917FKafMfvtENzWjJYqIVo=; b=T624itySPdp8Y12VOuGfU4/Mj0ZPeyqM/cXnm48FOtf6gCwBVvcy/bUGvel6h30KSPJoNmwH Zct2RgEUscmmSmPdm32YcjSQw2sHlwI7mpUgszQOBIJAGyjzpjIh8zZ8RbIcs89evt0J+ok9 Yvz/MLWuGbOnUJMbqDnDiMnog/Y= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5fe20c58da47198188df83a1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 22 Dec 2020 15:10:16 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 89E4FC43462; Tue, 22 Dec 2020 15:10:16 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4A212C433C6; Tue, 22 Dec 2020 15:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4A212C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Jerome Pouiller Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S . Miller" , devicetree@vger.kernel.org, Rob Herring , linux-mmc@vger.kernel.org, Pali =?utf-8?Q?Roh?= =?utf-8?Q?=C3=A1r?= , Ulf Hansson Subject: Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h References: <20201104155207.128076-1-Jerome.Pouiller@silabs.com> <20201104155207.128076-10-Jerome.Pouiller@silabs.com> Date: Tue, 22 Dec 2020 17:10:11 +0200 In-Reply-To: <20201104155207.128076-10-Jerome.Pouiller@silabs.com> (Jerome Pouiller's message of "Wed, 4 Nov 2020 16:51:52 +0100") Message-ID: <87lfdp98rw.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Jerome Pouiller writes: > +/* > + * Internal helpers. > + * > + * About CONFIG_VMAP_STACK: > + * When CONFIG_VMAP_STACK is enabled, it is not possible to run DMA on stack > + * allocated data. Functions below that work with registers (aka functions > + * ending with "32") automatically reallocate buffers with kmalloc. However, > + * functions that work with arbitrary length buffers let's caller to handle > + * memory location. In doubt, enable CONFIG_DEBUG_SG to detect badly located > + * buffer. > + */ This sounds very hacky to me, I have understood that you should never use stack with DMA. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches