From: Kevin Hilman <khilman@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Benoit Cousson <benoit.cousson@linaro.org>,
Paul Walmsley <paul@pwsan.com>, Ohad Ben-Cohen <ohad@wizery.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv3 7/8] mailbox/omap: add code to support the wkupm3 operations
Date: Mon, 26 Aug 2013 20:50:43 -0700 [thread overview]
Message-ID: <87li3n6bcc.fsf@linaro.org> (raw)
In-Reply-To: <1375825238-18299-1-git-send-email-s-anna@ti.com> (Suman Anna's message of "Tue, 6 Aug 2013 16:40:38 -0500")
Suman Anna <s-anna@ti.com> writes:
> The WkupM3 mailbox used for triggering PM operations such as suspend
> and resume on AM33x/AM43x is special in that the M3 processor cannot
> access the mailbox registers. However, an interrupt is needed to be
> sent to request the M3 to perform a desired PM operation. This patch
> adds the support for this special mailbox through separate ops for
> this mailbox. These ops are designed to have the WkupM3's Rx interrupt
> programmed within the driver, during transmission of a message. The
> message is immediately read back and the internal mailbox interrupt
> acknowledged as well to avoid triggering any spurious interrupts to
> the M3.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
Dumb Q: why does all this extra logic belong in the mailbox driver and
not in the wkup_m3 driver? To me, this seems like part of the IPC
protocol between the MPU and M3 firmware, and not an inherent part of
the AM33xx mbox.
Kevin
next parent reply other threads:[~2013-08-27 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375825238-18299-1-git-send-email-s-anna@ti.com>
2013-08-27 3:50 ` Kevin Hilman [this message]
2013-08-27 16:03 ` [PATCHv3 7/8] mailbox/omap: add code to support the wkupm3 operations Suman Anna
2013-08-27 21:25 ` Kevin Hilman
2013-08-28 16:24 ` Suman Anna
2013-08-29 16:57 ` Kevin Hilman
2013-09-04 20:18 ` Suman Anna
2013-09-04 22:22 ` Kevin Hilman
2013-09-05 20:12 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li3n6bcc.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=benoit.cousson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=paul@pwsan.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).